-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composer enable_ip_masq_agent flag support (beta) (#9698) #5277
Composer enable_ip_masq_agent flag support (beta) (#9698) #5277
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @c2thorn, please review this PR or find an appropriate assignee. |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccComposerEnvironment_withNodeConfig|TestAccServiceNetworkingPeeredDNSDomain_basic You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=209142 |
mmv1/third_party/terraform/resources/resource_composer_environment.go.erb
Show resolved
Hide resolved
@@ -1011,16 +1011,17 @@ func testAccComposerEnvironment_nodeCfg(environment, network, subnetwork, servic | |||
return fmt.Sprintf(` | |||
resource "google_composer_environment" "test" { | |||
name = "%s" | |||
region = "us-central1" | |||
region = "us-east1" # later should be changed to us-central1, when feature is accessible globally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we specify we are talking about the enable_ip_masq_agent
feature specifically?
tests passed in a previous run, merging now. |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccBigQueryDataTable_bigtable|TestAccServiceNetworkingPeeredDNSDomain_basic You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=209179 |
Add enable_ip_masq_agent to google_composer_environment (beta)
fixes hashicorp/terraform-provider-google#9698
I should be applied instead of similar PR: #5142
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)