Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Composer IP masq agent flag #9698

Closed
gor-obr opened this issue Aug 2, 2021 · 3 comments · Fixed by GoogleCloudPlatform/magic-modules#5277, #10256 or hashicorp/terraform-provider-google-beta#3705
Assignees
Milestone

Comments

@gor-obr
Copy link
Contributor

gor-obr commented Aug 2, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Add support for Cloud Composer flag which enables IP masq agent.

https://cloud.google.com/composer/docs/reference/rest/v1beta1/projects.locations.environments
config.nodeConfig.enableIpMasqAgent

New or Affected Resource(s)

google_composer_environment

@gor-obr
Copy link
Contributor Author

gor-obr commented Aug 2, 2021

I wish to work on this item.

@ScottSuarez
Copy link
Collaborator

cool @gor-obr

So feel free to make these changes locally but when you are ready to commit make a pull request upstream against our repository and tag me on the change!

To work locally you can add the field to the resource here
https://github.com/hashicorp/terraform-provider-google/blob/master/google/resource_composer_environment.go

Then when you are ready to upstream you can make the changes to tests, docs, and resource are the following locations.

Let me know if you have any questions ^^

docs: https://github.com/GoogleCloudPlatform/magic-modules/blob/master/mmv1/third_party/terraform/website/docs/r/composer_environment.html.markdown
test: https://github.com/GoogleCloudPlatform/magic-modules/blob/master/mmv1/third_party/terraform/tests/resource_composer_environment_test.go.erb
resource: https://github.com/GoogleCloudPlatform/magic-modules/blob/master/mmv1/third_party/terraform/resources/resource_composer_environment.go.erb

@github-actions
Copy link

github-actions bot commented Nov 5, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.