-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved Cloud Run secret support to ga #5410
Moved Cloud Run secret support to ga #5410
Conversation
…naged. The integration enables binding secret values to environment variables or to the content of files.
…d Run Managed." This reverts commit 2170b50.
Moves the support for environment variables and filesystem based secrets from beta to ga since the feature is now generally available.
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @ndmckinley, please review this PR or find an appropriate assignee. |
The VCRCommunity failure shows this message in the details: "Needs` /gcbrun from a collaborator" So I think someone has to run this for me? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as the tests pass.
@@ -1,9 +1,9 @@ | |||
data "google_project" "project" { | |||
provider = google-beta | |||
provider = google |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you probably want to just remove all these lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
/gcbrun |
/gcbrun |
@@ -1,35 +1,23 @@ | |||
data "google_project" "project" { | |||
provider = google-beta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're still going to want this empty block, I bet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Trying to run the tests on my local machine for ga and beta.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests ran successfully both for ga and beta.
for ga:
=== RUN TestAccCloudRunService_secretEnvironmentVariable
=== PAUSE TestAccCloudRunService_secretEnvironmentVariable
=== CONT TestAccCloudRunService_secretEnvironmentVariable
--- PASS: TestAccCloudRunService_secretEnvironmentVariable (76.99s)
PASS
=== RUN TestAccCloudRunService_secretVolume
=== PAUSE TestAccCloudRunService_secretVolume
=== CONT TestAccCloudRunService_secretVolume
--- PASS: TestAccCloudRunService_secretVolume (74.17s)
PASS
for beta:
=== RUN TestAccCloudRunService_secretEnvironmentVariable
=== PAUSE TestAccCloudRunService_secretEnvironmentVariable
=== CONT TestAccCloudRunService_secretEnvironmentVariable
--- PASS: TestAccCloudRunService_secretEnvironmentVariable (78.51s)
PASS
=== RUN TestAccCloudRunService_secretVolume
=== PAUSE TestAccCloudRunService_secretVolume
=== CONT TestAccCloudRunService_secretVolume
--- PASS: TestAccCloudRunService_secretVolume (85.45s)
PASS
/gcbrun |
1 similar comment
LGTM. I'll merge. |
Moves the support for environment variables and filesystem based secrets from
beta to ga since the feature is now generally available.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)