Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved Cloud Run secret support to ga #5410

Merged

Conversation

jeremiele
Copy link
Contributor

@jeremiele jeremiele commented Nov 2, 2021

Moves the support for environment variables and filesystem based secrets from
beta to ga since the feature is now generally available.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudrun: Added support for secrets to ga terraform module.

…naged.

The integration enables binding secret values to environment variables or
to the content of files.
Moves the support for environment variables and filesystem based secrets from
beta to ga since the feature is now generally available.
@google-cla google-cla bot added the cla: yes label Nov 2, 2021
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@ndmckinley, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 949 insertions(+), 25 deletions(-))
Terraform Beta: Diff ( 3 files changed, 25 insertions(+), 31 deletions(-))

@jeremiele
Copy link
Contributor Author

The VCRCommunity failure shows this message in the details:

"Needs` /gcbrun from a collaborator"

So I think someone has to run this for me?

Copy link
Contributor

@nat-henderson nat-henderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as the tests pass.

@@ -1,9 +1,9 @@
data "google_project" "project" {
provider = google-beta
provider = google
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you probably want to just remove all these lines.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@nat-henderson
Copy link
Contributor

/gcbrun

@nat-henderson
Copy link
Contributor

/gcbrun

@@ -1,35 +1,23 @@
data "google_project" "project" {
provider = google-beta
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're still going to want this empty block, I bet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Trying to run the tests on my local machine for ga and beta.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests ran successfully both for ga and beta.

for ga:

=== RUN TestAccCloudRunService_secretEnvironmentVariable
=== PAUSE TestAccCloudRunService_secretEnvironmentVariable
=== CONT TestAccCloudRunService_secretEnvironmentVariable
--- PASS: TestAccCloudRunService_secretEnvironmentVariable (76.99s)
PASS

=== RUN TestAccCloudRunService_secretVolume
=== PAUSE TestAccCloudRunService_secretVolume
=== CONT TestAccCloudRunService_secretVolume
--- PASS: TestAccCloudRunService_secretVolume (74.17s)
PASS

for beta:

=== RUN TestAccCloudRunService_secretEnvironmentVariable
=== PAUSE TestAccCloudRunService_secretEnvironmentVariable
=== CONT TestAccCloudRunService_secretEnvironmentVariable
--- PASS: TestAccCloudRunService_secretEnvironmentVariable (78.51s)
PASS

=== RUN TestAccCloudRunService_secretVolume
=== PAUSE TestAccCloudRunService_secretVolume
=== CONT TestAccCloudRunService_secretVolume
--- PASS: TestAccCloudRunService_secretVolume (85.45s)
PASS

@nat-henderson
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 921 insertions(+), 33 deletions(-))
Terraform Beta: Diff ( 3 files changed, 5 insertions(+), 47 deletions(-))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 921 insertions(+), 33 deletions(-))
Terraform Beta: Diff ( 3 files changed, 5 insertions(+), 47 deletions(-))

@nat-henderson
Copy link
Contributor

LGTM. I'll merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants