Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved Cloud Run secret support to ga #10519

Conversation

modular-magician
Copy link
Collaborator

Moves the support for environment variables and filesystem based secrets from
beta to ga since the feature is now generally available.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudrun: Added support for secrets to ga terraform module.

Derived from GoogleCloudPlatform/magic-modules#5410

* Added support for the integration with Secret Manager in Cloud Run Managed.
The integration enables binding secret values to environment variables or
to the content of files.

* Revert "Added support for the integration with Secret Manager in Cloud Run Managed."

This reverts commit 2170b507ee540108a8f08641e4997c9d449f2e28.

* Moved Cloud Run secret support to ga.

Moves the support for environment variables and filesystem based secrets from
beta to ga since the feature is now generally available.

* Completely removed provider setup for secret examples for Cloud Run.

* Added back data block.

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 1723732 into hashicorp:master Nov 8, 2021
@github-actions
Copy link

github-actions bot commented Dec 9, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant