Revert "Reimplemented compute service attachment using the DCL (#5342)" #5442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b932c48. /cc @trodge
I don't think that this PR was ready to merge, and believe that it introduced multiple breaking changes to the provider in addition to major regressions in terms of documentation. Before moving forward with a replacement for the PR I'd request the following are resolved:
ForceNew
property. This field is extemely unlikely to be updatable. If it is, that's worth explaining in the migration PR.Possibly harmless, but also worth resolving:
Additionally, I think we'll want to improve the documentation as was done in #5325 for this or any other brownfield resource. I believe this requires manual work in the DCL.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)