Compute serviceattachment dcl #5444

trodge · 2021-11-12T01:52:30Z

Moved compute service attachment back to DCL implementation, fixing issues outlined in #5442

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

modular-magician · 2021-11-12T02:07:24Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 747 insertions(+), 997 deletions(-))
Terraform Beta: Diff ( 9 files changed, 747 insertions(+), 997 deletions(-))

trodge · 2021-11-12T03:02:42Z

/gcbrun

modular-magician · 2021-11-12T03:15:22Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 11 files changed, 751 insertions(+), 998 deletions(-))
Terraform Beta: Diff ( 12 files changed, 796 insertions(+), 998 deletions(-))

rileykarson

Thanks for making these changes @trodge!

I have some first-pass comments, inline- the documentation (inline) and a few remaining schema changes are the big things:

google_compute_service_attachment.consumer_accept_lists.connection_limit went from required -> optional
google_compute_service_attachment.enable_proxy_protocol went from required -> optional
google_compute_service_attachment.service_attachment_id does not appear to be returned by the API, so I'm unsure why it is supported by the DCL

Once those are resolved there's a couple pieces of tooling I'd like to run- I want to try out the release diff tester (ack that Scott already did, it's mostly for my own learning) and the schema diff tool.

rileykarson · 2021-11-12T17:58:12Z

mmv1/third_party/terraform/go.mod.erb

@@ -3,7 +3,7 @@ module github.com/hashicorp/terraform-provider-google<%= "-" + version unless ve

 require (
 	cloud.google.com/go/bigtable v1.10.1
-	github.com/GoogleCloudPlatform/declarative-resource-client-library v0.0.0-20211027225138-ef28ca390518


@ndmckinley can you verify that the newly-available fields in CloudBuild WorkerPool are intentional? It seems so, but I was surprised by the etag.

Are you referring to the fields that were added to beta in cl/408655015 ?

Yeah - #5356 will add those to GA. They work in beta as of now! Would you like etag exluded? I don't mind either way, I forget what we decided on fingerprints. Could you comment on that PR with that?

rileykarson · 2021-11-12T18:02:09Z

mmv1/third_party/terraform/tests/resource_compute_service_attachment_test.go

@@ -25,7 +25,7 @@ func TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate(t *test
 				ResourceName:            "google_compute_service_attachment.psc_ilb_service_attachment",
 				ImportState:             true,
 				ImportStateVerify:       true,
-				ImportStateVerifyIgnore: []string{"target_service", "region"},
+				ImportStateVerifyIgnore: []string{"target_service", "region", "nat_subnets.0"},


Why does this newly need to be set? Generally, having to set an ISVI value indicates that something's changed that will affect end users.

Without this the test still fails with:

provider_test.go:278: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected. (map[string]string) (len=1) { (string) (len=13) "nat_subnets.0": (string) (len=121) "https://www.googleapis.com/compute/beta/projects/tjr-dm-test-1/regions/us-west2/subnetworks/tf-test-psc-ilb-natn86tr1bw0e" } (map[string]string) (len=1) { (string) (len=13) "nat_subnets.0": (string) (len=81) "projects/tjr-dm-test-1/regions/us-west2/subnetworks/tf-test-psc-ilb-natn86tr1bw0e" }

nat_subnets Elem.DiffSuppressFunc is compareSelfLinkOrResourceName, so I'm fairly confident this is a problem that only occurs in testing.

rileykarson · 2021-11-12T18:10:41Z

tpgtools/overrides/compute/beta/service_attachment.yaml

@@ -0,0 +1,8 @@
+- type: EXCLUDE
+  field: region


Ah, weird- the base DCL resource includes a (presumably output-only) region field but also a location field which maps to the region field in the API?

Yes, this is the way KCC requested we name the fields. location corresponds to the URL parameter.

rileykarson · 2021-11-12T18:11:58Z

mmv1/third_party/terraform/go.mod.erb

@@ -3,7 +3,7 @@ module github.com/hashicorp/terraform-provider-google<%= "-" + version unless ve

 require (
 	cloud.google.com/go/bigtable v1.10.1
-	github.com/GoogleCloudPlatform/declarative-resource-client-library v0.0.0-20211027225138-ef28ca390518
+	github.com/GoogleCloudPlatform/declarative-resource-client-library v0.0.0-20211111235242-eee3ce55868a


Note, we'll want to handwrite documentation in the DCL and add reference links such as was done in #5325. That'll put the generated docs are at parity with the original ones. See the current diff:

Not sure on the process- you may have to look at @ndmckinley's history, and/or pester them to document it if it isn't intuitive.

cl/409490555 should add the documentation to the DCL schema that the template needs to generate the page as it already exists.

trodge · 2021-11-12T22:08:14Z

Thanks for making these changes @trodge!

I have some first-pass comments, inline- the documentation (inline) and a few remaining schema changes are the big things:

google_compute_service_attachment.consumer_accept_lists.connection_limit went from required -> optional

google_compute_service_attachment.enable_proxy_protocol went from required -> optional

google_compute_service_attachment.service_attachment_id does not appear to be returned by the API, so I'm unsure why it is supported by the DCL

Once those are resolved there's a couple pieces of tooling I'd like to run- I want to try out the release diff tester (ack that Scott already did, it's mostly for my own learning) and the schema diff tool.

I have verified that the two fields which went from required to optional are in fact optional. I don't want to make them required in the DCL because this resource is already in KCC with the optional fields.

I meant to exclude service_attachment_id since it is not in the existing schema, but excluded the id field instead. I have fixed that in the latest commit.

modular-magician · 2021-11-12T22:18:41Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 11 files changed, 739 insertions(+), 998 deletions(-))
Terraform Beta: Diff ( 12 files changed, 784 insertions(+), 998 deletions(-))

modular-magician · 2021-11-12T23:52:45Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccAssuredWorkloadsWorkload_BasicHandWritten|TestAccAssuredWorkloadsWorkload_FullHandWritten|TestAccCloudFunctionsFunction_vpcConnector|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample|TestAccComputeInstanceFromMachineImage_basic|TestAccComputeInstanceFromMachineImage_overrideMetadataDotStartupScript|TestAccComputeInstanceFromMachineImage_diffProject|TestAccComputeRegionHealthCheck_tcp_update|TestAccComputeRegionHealthCheck_typeTransition|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample|TestAccComputeServiceAttachment_BasicHandWritten|TestAccContainerCluster_withILBSubsetting|TestAccContainerCluster_regionalWithNodePool|TestAccContainerCluster_withNodePoolBasic|TestAccContainerCluster_withNodePoolResize|TestAccContainerCluster_withNodePoolUpdateVersion|TestAccContainerCluster_withNodePoolMultiple|TestAccContainerCluster_withNodePoolAutoscaling|TestAccContainerCluster_withNodePoolNodeConfig|TestAccContainerCluster_withEnableKubernetesAlpha|TestAccContainerNodePool_basic|TestAccContainerNodePool_basicWithClusterId|TestAccContainerNodePool_nodeLocations|TestAccContainerNodePool_maxPodsPerNode|TestAccContainerNodePool_withNodeConfig|TestAccContainerNodePool_withWorkloadIdentityConfig|TestAccContainerNodePool_withSandboxConfig|TestAccContainerNodePool_withKubeletConfig|TestAccContainerNodePool_withLinuxNodeConfig|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerNodePool_withManagement|TestAccContainerNodePool_withInvalidUpgradeSettings|TestAccContainerNodePool_withGPU|TestAccContainerNodePool_withNodeConfigScopeAlias|TestAccContainerNodePool_autoscaling|TestAccContainerNodePool_regionalAutoscaling|TestAccContainerNodePool_resize|TestAccContainerNodePool_regionalClusters|TestAccContainerNodePool_version|TestAccContainerNodePool_012_ConfigModeAttr|TestAccContainerNodePool_EmptyGuestAccelerator|TestAccContainerNodePool_ephemeralStorageConfig|TestAccDataprocWorkflowTemplate_basic|TestAccEventarcTrigger_BasicHandWritten|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccMonitoringMonitoredProject_BasicMonitoredProject|TestAccNetworkServicesEdgeCacheOrigin_networkServicesEdgeCacheOriginBasicExample|TestAccNetworkServicesEdgeCacheOrigin_networkServicesEdgeCacheOriginAdvancedExample|TestAccNetworkServicesEdgeCacheService_networkServicesEdgeCacheServiceAdvancedExample|TestAccOrgPolicyPolicy_EnforcePolicy|TestAccOrgPolicyPolicy_FolderPolicy|TestAccOrgPolicyPolicy_ProjectPolicy|TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate|TestAccSqlDatabaseInstance_withPrivateNetwork|TestAccSqlUser_postgresIAM You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=218087

modular-magician · 2021-11-13T00:29:21Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 16 files changed, 760 insertions(+), 1004 deletions(-))
Terraform Beta: Diff ( 17 files changed, 805 insertions(+), 1004 deletions(-))

modular-magician · 2021-11-13T02:05:31Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccAssuredWorkloadsWorkload_BasicHandWritten|TestAccAssuredWorkloadsWorkload_FullHandWritten|TestAccCloudFunctionsFunction_vpcConnector|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample|TestAccComputeInstanceFromMachineImage_basic|TestAccComputeInstanceFromMachineImage_overrideMetadataDotStartupScript|TestAccComputeInstanceFromMachineImage_diffProject|TestAccComputeRegionHealthCheck_tcp_update|TestAccComputeRegionHealthCheck_typeTransition|TestAccComputeRegionHealthCheck_logConfigDisabled|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample|TestAccComputeServiceAttachment_BasicHandWritten|TestAccContainerCluster_withILBSubsetting|TestAccContainerCluster_regionalWithNodePool|TestAccContainerCluster_withNodePoolBasic|TestAccContainerCluster_withNodePoolResize|TestAccContainerCluster_withNodePoolUpdateVersion|TestAccContainerCluster_withNodePoolAutoscaling|TestAccContainerCluster_withNodePoolMultiple|TestAccContainerCluster_withNodePoolNodeConfig|TestAccContainerCluster_withEnableKubernetesAlpha|TestAccContainerNodePool_basic|TestAccContainerNodePool_basicWithClusterId|TestAccContainerNodePool_nodeLocations|TestAccContainerNodePool_maxPodsPerNode|TestAccContainerNodePool_withNodeConfig|TestAccContainerNodePool_withWorkloadIdentityConfig|TestAccContainerNodePool_withSandboxConfig|TestAccContainerNodePool_withKubeletConfig|TestAccContainerNodePool_withLinuxNodeConfig|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerNodePool_withInvalidUpgradeSettings|TestAccContainerNodePool_withGPU|TestAccContainerNodePool_withManagement|TestAccContainerNodePool_withNodeConfigScopeAlias|TestAccContainerNodePool_regionalAutoscaling|TestAccContainerNodePool_autoscaling|TestAccContainerNodePool_resize|TestAccContainerNodePool_regionalClusters|TestAccContainerNodePool_version|TestAccContainerNodePool_012_ConfigModeAttr|TestAccContainerNodePool_EmptyGuestAccelerator|TestAccContainerNodePool_ephemeralStorageConfig|TestAccDataprocWorkflowTemplate_basic|TestAccEventarcTrigger_BasicHandWritten|TestAccMonitoringMonitoredProject_BasicMonitoredProject|TestAccNetworkServicesEdgeCacheOrigin_networkServicesEdgeCacheOriginBasicExample|TestAccNetworkServicesEdgeCacheOrigin_networkServicesEdgeCacheOriginAdvancedExample|TestAccNetworkServicesEdgeCacheService_networkServicesEdgeCacheServiceAdvancedExample|TestAccOrgPolicyPolicy_EnforcePolicy|TestAccOrgPolicyPolicy_FolderPolicy|TestAccOrgPolicyPolicy_ProjectPolicy|TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate|TestAccSqlDatabaseInstance_withPrivateNetwork|TestAccSqlUser_postgresIAM You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=218106

modular-magician · 2021-11-13T03:41:20Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 16 files changed, 764 insertions(+), 1002 deletions(-))
Terraform Beta: Diff ( 17 files changed, 809 insertions(+), 1002 deletions(-))

modular-magician · 2021-11-13T05:18:41Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudFunctionsFunction_vpcConnector|TestAccComputeInstanceFromMachineImage_basic|TestAccComputeInstanceFromMachineImage_overrideMetadataDotStartupScript|TestAccComputeInstanceFromMachineImage_diffProject|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample|TestAccContainerNodePool_withInvalidUpgradeSettings|TestAccEventarcTrigger_BasicHandWritten|TestAccSqlUser_postgresIAM You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=218308

modular-magician · 2021-11-13T05:41:32Z

Tests failed during RECORDING mode: TestAccEventarcTrigger_BasicHandWritten|TestAccComputeInstanceFromMachineImage_overrideMetadataDotStartupScript|TestAccComputeInstanceFromMachineImage_basic|TestAccCloudFunctionsFunction_vpcConnector|TestAccComputeInstanceFromMachineImage_diffProject|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample|TestAccContainerNodePool_withInvalidUpgradeSettings|TestAccSqlUser_postgresIAM Please fix these to complete your PR

modular-magician · 2021-11-17T00:23:30Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 16 files changed, 891 insertions(+), 1051 deletions(-))
Terraform Beta: Diff ( 17 files changed, 936 insertions(+), 1051 deletions(-))

nat-henderson · 2021-11-17T00:29:10Z

Nice - the new docs are just as good as the old ones, thanks for being diligent on that point.

modular-magician · 2021-11-17T19:46:53Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 16 files changed, 889 insertions(+), 1049 deletions(-))
Terraform Beta: Diff ( 17 files changed, 934 insertions(+), 1049 deletions(-))

rileykarson · 2021-11-17T20:48:31Z

Note: terraform-validator-test doesn't appear related

modular-magician · 2021-11-17T21:25:32Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccCloudFunctionsFunction_vpcConnector|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample|TestAccComputeServiceAttachment_ConsumerListsHandWritten|TestAccComputeServiceAttachment_BasicHandWritten|TestAccContainerNodePool_withInvalidUpgradeSettings|TestAccEventarcTrigger_BasicHandWritten|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccServiceDirectoryEndpoint_serviceDirectoryEndpointWithNetworkExample|TestAccSqlUser_postgresIAM You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=220259

trodge · 2021-11-19T00:59:14Z

/gcbrun

modular-magician · 2021-11-19T01:19:25Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 16 files changed, 889 insertions(+), 1049 deletions(-))
Terraform Beta: Diff ( 17 files changed, 934 insertions(+), 1049 deletions(-))

rileykarson · 2021-11-19T21:12:54Z

Ran both manual checks. I believe that we'll need to correct the last diff.go change as it causes a negative change in behaviour for some users, so it'd count as a backwards incompatibility:

DiffSuppressFunc for path region, was: compareSelfLinkOrResourceName is now

diff.go:

------------Diffing resource google_compute_service_attachment------------
Fields added in tpgtools: [psc_service_attachment_id]
Fields added in tpgtools: [connected_endpoints.psc_connection_id]
Required status different for path consumer_accept_lists.connection_limit, was: true is now false
Optional status different for path consumer_accept_lists.connection_limit, was: false is now true
DiffSuppressFunc for path consumer_accept_lists.project_id_or_num, was:  is now compareSelfLinkOrResourceName
DiffSuppressFunc for path consumer_reject_lists.elem, was:  is now compareSelfLinkOrResourceName
Required status different for path enable_proxy_protocol, was: true is now false
Optional status different for path enable_proxy_protocol, was: false is now true
DiffSuppressFunc for path project, was:  is now compareSelfLinkOrResourceName
DiffSuppressFunc for path region, was: compareSelfLinkOrResourceName is now
------------Done------------

RELEASE_DIFF=true:

$ RELEASE_DIFF=true make testacc TEST=./google-beta TESTARGS='-run=TestAccComputeServiceAttachment_'
==> Checking source code against gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google-beta -v -run=TestAccComputeServiceAttachment_ -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google-beta/version.ProviderVersion=acc"
=== RUN   TestAccComputeServiceAttachment_BasicHandWritten
=== PAUSE TestAccComputeServiceAttachment_BasicHandWritten
=== RUN   TestAccComputeServiceAttachment_ConsumerListsHandWritten
=== PAUSE TestAccComputeServiceAttachment_ConsumerListsHandWritten
=== CONT  TestAccComputeServiceAttachment_BasicHandWritten
=== CONT  TestAccComputeServiceAttachment_ConsumerListsHandWritten
--- PASS: TestAccComputeServiceAttachment_ConsumerListsHandWritten (204.11s)
--- PASS: TestAccComputeServiceAttachment_BasicHandWritten (228.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-google-beta/google-beta	229.410s

modular-magician · 2021-11-20T00:28:53Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 16 files changed, 889 insertions(+), 1048 deletions(-))
Terraform Beta: Diff ( 17 files changed, 934 insertions(+), 1048 deletions(-))

modular-magician · 2021-11-20T02:06:26Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccRedisInstanceDatasource_basic|TestAccCloudFunctionsFunction_vpcConnector|TestAccComputeBackendBucket_withCdnPolicy|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample|TestAccContainerNodePool_withWorkloadIdentityConfig|TestAccEventarcTrigger_BasicHandWritten|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccRedisInstance_redisInstanceBasicExample|TestAccRedisInstance_redisInstanceFullExample|TestAccRedisInstance_update|TestAccRedisInstance_regionFromLocation|TestAccRedisInstance_redisInstanceAuthEnabled|TestAccRedisInstance_downgradeRedisVersion|TestAccSqlUser_postgresIAM You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=221745

rileykarson

Do you mind redoing the DCL upgrade to resolve conflicts? (upgrades are fairly annoying as they'll cause them fairly frequently)

rileykarson · 2021-11-17T20:57:03Z

tpgtools/resource.go

@@ -166,7 +166,7 @@ func (l Link) Markdown() string {
 }

 func (r *Resource) fillLinksFromExtensionsMap(m map[string]interface{}) {
-	ref, ok := m["x-dcl-ref"].(map[string]interface{})
+	ref, ok := m["x-dcl-ref"].(map[interface{}]interface{})


What prompted this change? Given I can't see any key changes, these still seems to be strings all of the time.

With the previous line, ref is always an empty map and ok is always false and that's not the case with the new line. I suspect this has something to do with how the yaml is being read, but I'm not sure why the value is a map[interface{}]interface{} rather than a map[string]interface{}.

modular-magician · 2021-11-23T00:53:34Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 16 files changed, 887 insertions(+), 1058 deletions(-))
Terraform Beta: Diff ( 16 files changed, 887 insertions(+), 1058 deletions(-))

GoogleCloudPlatform#5342)" (GoogleCloudPlatform#5442)" This reverts commit fefeebf.

Fixed bug related to diff suppress function on array elements. Renamed variables in service attachment handwritten samples.

trodge requested a review from rileykarson November 12, 2021 01:52

google-cla bot added the cla: yes label Nov 12, 2021

rileykarson reviewed Nov 12, 2021

View reviewed changes

trodge marked this pull request as ready for review November 12, 2021 23:46

trodge force-pushed the compute-serviceattachment-dcl branch from 71e222e to c47d39f Compare November 13, 2021 00:18

trodge force-pushed the compute-serviceattachment-dcl branch from 546d960 to 4f43639 Compare November 19, 2021 01:08

rileykarson reviewed Nov 22, 2021

View reviewed changes

trodge force-pushed the compute-serviceattachment-dcl branch from e9ecf8c to f8be99c Compare November 23, 2021 00:41

trodge added 8 commits February 16, 2022 13:18

Revert "Revert "Reimplemented compute service attachment using the DCL (

0986c14

GoogleCloudPlatform#5342)" (GoogleCloudPlatform#5442)" This reverts commit fefeebf.

Reverted changes to diff suppress function.

6487202

Fixed bug related to diff suppress function on array elements. Renamed variables in service attachment handwritten samples.

Removed now redundant override from compute firewall policy rule.

1336e6a

Fixed name of excluded field.

22b7fbc

Fixed issue causing how-to guides to not appear in docs.

dc16847

Moved mmv1 handwritten test into tpgtools.

8c700cc

Renamed variables to match previous values.

5e9d1f0

Added diff suppress function to region field via override.

4db6dbc

trodge force-pushed the compute-serviceattachment-dcl branch from f8be99c to 4db6dbc Compare February 16, 2022 21:21

trodge closed this Nov 28, 2022

Compute serviceattachment dcl #5444

Compute serviceattachment dcl #5444

Conversation

trodge commented Nov 12, 2021

modular-magician commented Nov 12, 2021

Diff report:

trodge commented Nov 12, 2021

modular-magician commented Nov 12, 2021

Diff report:

rileykarson left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nat-henderson Nov 15, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

trodge commented Nov 12, 2021

modular-magician commented Nov 12, 2021

Diff report:

modular-magician commented Nov 12, 2021

modular-magician commented Nov 13, 2021

Diff report:

modular-magician commented Nov 13, 2021

modular-magician commented Nov 13, 2021

Diff report:

modular-magician commented Nov 13, 2021

modular-magician commented Nov 13, 2021

modular-magician commented Nov 17, 2021

Diff report:

nat-henderson commented Nov 17, 2021

modular-magician commented Nov 17, 2021

Diff report:

rileykarson commented Nov 17, 2021

modular-magician commented Nov 17, 2021

trodge commented Nov 19, 2021

modular-magician commented Nov 19, 2021

Diff report:

rileykarson commented Nov 19, 2021

modular-magician commented Nov 20, 2021

Diff report:

modular-magician commented Nov 20, 2021

rileykarson left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

modular-magician commented Nov 23, 2021

Diff report:

nat-henderson Nov 15, 2021 •

edited

Loading