-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Properties field to ApigeeOrganization #5556
Conversation
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @ndmckinley, please review this PR or find an appropriate assignee. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 181 insertions(+), 18 deletions(-)) |
This PR tries to solve the issue that, running I have tested with a local build of this PR, the problem still exists, however we now have a workaround.
A workaround is to add the properties explicitly in main.tf:
Then
A question for the reviewer: |
I would try setting
Yeah - that'll be server-side, internal to google - we aren't doing anything special to zero it out except not sending it! The service team would need to fix that, which seems a lot harder than the approach I suggest! |
* work in progress, assure if everything works * added support for composer v2 ga. Also some minor bugs in tests are fixed * moved tests to us-east1 for some time
…atform#5583) Co-authored-by: Adrien Vercoutere <avercoutere@users.noreply.github.com>
Co-authored-by: upodroid <cy@borg.dev>
… tags (GoogleCloudPlatform#5514) * docs(private-samples): added privateca quickstart sample and region tags * removed region tags * skipping tests for quickstart sample
…gleCloudPlatform#5593) * Updated docs related to localityLbPolicy and loadBalancingSchema * Updated the other localityLbPolicy occurrence * Forced newlines after nested bullet lists for localityLbPolicy * switched to snake case
* Updated terraform-plugin-sdk to 2.10.0 upstreamed hashicorp/terraform-provider-google#10717 * Bumped to v2.10.1 * updated go.sum * Updated go.sum * Added test dependencies to go.sum
* Fixing all the names commit. plus, move all the name types to their own file for clarity. * add back in a name that we actually do need which i removed too hastily. * Go back to guessing (it's a better guess this time) the package name from the filepath.
Thanks, I added default_from_api: true to terraform.yaml. Looks like it has worked! |
This PR is on an old branch and has a few conflicts. I've handpicked the relevant changes to another PR: #6464 |
This PR fixes hashicorp/terraform-provider-google#10083 by adding a Properties field to ApigeeOrganization.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)