-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make provisioning_model o+c #5698
make provisioning_model o+c #5698
Conversation
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGoogleFolder_lookupOrganization|TestAccDataSourceGoogleFolders_basic|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccCloudbuildWorkerPool_basic|TestAccComputeInstance_guestAccelerator|TestAccComputeInstance_guestAcceleratorSkip|TestAccComputeRegionNetworkEndpointGroup_negWithServerlessDeployment|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccFolderIamAuditConfig_addFirstExemptMember|TestAccFolderIamAuditConfig_removeLastExemptMember|TestAccFolderIamBinding_basic|TestAccFolderIamMember_basic|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeReplica|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeClone|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange|TestAccStorageTransferJob_posixSink You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=254920 |
@rileykarson This field will be release next Monday. Do we need to cherry pick this fix to include it in the next release, as this is a |
Yeah, we'll want to cherry-pick it or revert the original change from the release branch. You can work out the option to take w/ BOD! FYI @melinath |
Thanks @rileykarson ! I'll discuss with @melinath on this! |
Closing the loop - we decided to revert this from the 4.11.0 release. |
This field was added in PR #5662
Some of the tests start to fail in our nightly tests due to permadiff https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaGoogleProject/255295?buildTab=tests&status=failed&name=TestAccComputeInstance&pager.currentPage=1&expandedTest=-3022451123674774073
Therefore, making the field optional + computed.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)