make provisioning_model O+C in google_compute_instance_template #4052
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
provisioning_model
field was originally added in PR GoogleCloudPlatform/magic-modules#5662Some of the compute_instance_template related tests start to fail in our nightly tests yesterday https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaGoogleProject/255845?buildTab=tests&status=failed&name=TestAccComputeInstanceTemplate&pager.currentPage=1
Just reached out to the product team, and it seems like it has started to set a default value
STANDARD
for thisprovisioning_model
field for non-preemptible VMs from this Monday. Therefore, making this field optional computed.Already added
computed
togoogle_compute_instance
resource in GoogleCloudPlatform/magic-modules#5698, and now adding this togoogle_compute_instance_template
resourceIf this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#5705