Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery Authorized datasets #5700

Merged
merged 4 commits into from
Feb 11, 2022

Conversation

slevenick
Copy link
Contributor

Fixes: hashicorp/terraform-provider-google#10555

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

bigquery: added support for authorized datasets to `google_bigquery_dataset.access` and `google_bigquery_dataset_access`

@slevenick slevenick changed the title Authorized datasets BigQuery Authorized datasets Feb 10, 2022
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 543 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 7 files changed, 543 insertions(+), 6 deletions(-))
TF Validator: Diff ( 4 files changed, 78 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 119 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccBigQueryDataset_basic|TestAccBigQueryDatasetAccess_authorizedDataset|TestAccBigQueryDataset_access|TestAccBigQueryDataset_bigqueryDatasetAuthorizedDatasetExample|TestAccCloudbuildWorkerPool_basic|TestAccComputeInstance_guestAccelerator|TestAccComputeInstance_guestAcceleratorSkip|TestAccContainerCluster_withAuthenticatorGroupsConfig You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=255342

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccBigQueryDataset_bigqueryDatasetAuthorizedDatasetExample|TestAccCloudbuildWorkerPool_basic|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccComputeInstance_guestAcceleratorSkip|TestAccComputeInstance_guestAccelerator Please fix these to complete your PR

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 621 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 7 files changed, 621 insertions(+), 6 deletions(-))
TF Validator: Diff ( 4 files changed, 78 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 158 insertions(+))

mmv1/products/bigquery/api.yaml Show resolved Hide resolved
mmv1/products/bigquery/api.yaml Show resolved Hide resolved
@@ -248,6 +273,7 @@ objects:
- specialGroup
- iamMember
- view
- dataset
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing an identity- spooky! That one's been a while. VCR thinks it's safe, so seems fine though.

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccBigQueryDataset_bigqueryDatasetAuthorizedDatasetExample|TestAccCloudbuildWorkerPool_basic|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccServiceNetworkingPeeredDNSDomain_basic You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=255468

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 621 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 7 files changed, 621 insertions(+), 6 deletions(-))
TF Validator: Diff ( 4 files changed, 78 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 158 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccBigQueryDataset_bigqueryDatasetAuthorizedDatasetExample|TestAccCloudbuildWorkerPool_basic|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccServiceNetworkingPeeredDNSDomain_basic You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=255840

@slevenick slevenick merged commit ca9b0cf into GoogleCloudPlatform:master Feb 11, 2022
lcaggio pushed a commit to lcaggio/magic-modules that referenced this pull request Mar 16, 2022
* Add authorized views to bigquery_dataset

* Add authorized view to dataset_access

* Fix test file

* Add required to nested dataset field
lcaggio pushed a commit to lcaggio/magic-modules that referenced this pull request Mar 17, 2022
* Add authorized views to bigquery_dataset

* Add authorized view to dataset_access

* Fix test file

* Add required to nested dataset field
betsy-lichtenberg pushed a commit to betsy-lichtenberg/magic-modules that referenced this pull request Apr 25, 2022
* Add authorized views to bigquery_dataset

* Add authorized view to dataset_access

* Fix test file

* Add required to nested dataset field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support BigQuery authorized datasets
3 participants