Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery Authorized datasets #192

Conversation

modular-magician
Copy link
Collaborator

Fixes: hashicorp/terraform-provider-google#10555

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

bigquery: added support for authorized datasets to `google_bigquery_dataset.access` and `google_bigquery_dataset_access`

Derived from GoogleCloudPlatform/magic-modules#5700

* Add authorized views to bigquery_dataset

* Add authorized view to dataset_access

* Fix test file

* Add required to nested dataset field

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 40cef37 into terraform-google-modules:master Feb 11, 2022
@modular-magician modular-magician deleted the downstream-pr-ca9b0cfefb4ffa8c44304d520cc7d67f1172226d branch November 18, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support BigQuery authorized datasets
1 participant