-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new terraform sample - CDN XLB with Backend Bucket #5869
Add new terraform sample - CDN XLB with Backend Bucket #5869
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @slevenick, please review this PR or find an appropriate assignee. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 1 file changed, 145 insertions(+)) |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataprocMetastoreServiceDatasource_basic|TestAccComputeGlobalForwardingRule_externalCdnLbWithBackendBucketExample|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccFirebaserulesRelease_BasicRelease|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccSpannerDatabase_postgres You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=274382 |
Whats the reason for adding this example? I'm worried because it's a fairly large example with a lot of config and it will be added to our docs page here: https://github.com/modular-magician/terraform-provider-google-beta/compare/auto-pr-5869-old..auto-pr-5869#diff-0bd72faa5634a22f080fa06fe8346998911d494e1f50499d29d1bb67586aaa7eR40 Can we restrict this to only the cloud docs if that is the intended target? |
Hi @slevenick Thank you for your comment. This code sample was requested earlier and merged - Github PR Request, but was later missing in the Master Branch. This sample code is requested for users, as a demonstration. For more information, refer to http://b/227467966. Most of the Terraform Load balancers samples are usually big as this one and I guess we did not restrict them. For this code sample, if it's too much trouble, I see it okay restrict to the Docs. |
Looks like |
Huh, then why did it pass in VCR? I guess I'll revert again! |
I think VCR got timeout and did not run this test https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaMmUpstreamVcr/274382?buildTab=tests&status=all&pager.currentPage=1 |
If a beta-only test does not have
|
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)