Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new terraform sample - CDN XLB with Backend Bucket #5869

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Add new terraform sample - CDN XLB with Backend Bucket #5869

merged 1 commit into from
Apr 6, 2022

Conversation

msampathkumar
Copy link
Member

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@slevenick, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 145 insertions(+))
Terraform Beta: Diff ( 2 files changed, 310 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 236 insertions(+))
TF Cloud Doc Samples: Diff ( 1 file changed, 137 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataprocMetastoreServiceDatasource_basic|TestAccComputeGlobalForwardingRule_externalCdnLbWithBackendBucketExample|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccFirebaserulesRelease_BasicRelease|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccSpannerDatabase_postgres You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=274382

@slevenick
Copy link
Contributor

Whats the reason for adding this example? I'm worried because it's a fairly large example with a lot of config and it will be added to our docs page here: https://github.com/modular-magician/terraform-provider-google-beta/compare/auto-pr-5869-old..auto-pr-5869#diff-0bd72faa5634a22f080fa06fe8346998911d494e1f50499d29d1bb67586aaa7eR40

Can we restrict this to only the cloud docs if that is the intended target?

@msampathkumar
Copy link
Member Author

Hi @slevenick Thank you for your comment.

This code sample was requested earlier and merged - Github PR Request, but was later missing in the Master Branch.

This sample code is requested for users, as a demonstration. For more information, refer to http://b/227467966.

Most of the Terraform Load balancers samples are usually big as this one and I guess we did not restrict them. For this code sample, if it's too much trouble, I see it okay restrict to the Docs.

@shuyama1
Copy link
Member

shuyama1 commented Apr 8, 2022

@slevenick
Copy link
Contributor

Huh, then why did it pass in VCR?

I guess I'll revert again!

@shuyama1
Copy link
Member

shuyama1 commented Apr 8, 2022

slevenick added a commit that referenced this pull request Apr 8, 2022
@shuyama1
Copy link
Member

shuyama1 commented Apr 8, 2022

If a beta-only test does not have provider = google-beta on the resources, it will fail in our nightly test but pass in VCR (#5852). I will look into the problem and try to get it fixed next week.
While this PR is more than that I guess. It seems lack of provider = google-beta on some resources but after adding it I still got errors

    provider_test.go:309: Step 1/2 error: Error running pre-apply refresh: exit status 1
        
        Error: Invalid resource type
        
          on terraform_plugin_test.tf line 118, in resource "local_file" "index_page":
         118: resource "local_file" "index_page" {
        
        The provider hashicorp/google-beta does not support resource type
        "local_file".
        
        Error: Invalid resource type
        
          on terraform_plugin_test.tf line 129, in resource "local_file" "error_page":
         129: resource "local_file" "error_page" {
        
        The provider hashicorp/google-beta does not support resource type
        "local_file".
        
        Error: Invalid resource type
        
          on terraform_plugin_test.tf line 140, in resource "null_resource" "test_image":
         140: resource "null_resource" "test_image" {
        
        The provider hashicorp/google-beta does not support resource type
        "null_resource".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants