Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new terraform sample - CDN XLB with Backend Bucket #6252

Merged
merged 5 commits into from
Jul 21, 2022

Conversation

betsy-lichtenberg
Copy link
Contributor

@betsy-lichtenberg betsy-lichtenberg commented Jul 12, 2022

Intending to use this sample on the following page:

https://cloud.google.com/cdn/docs/setting-up-cdn-with-bucket

This PR is an update to #5869 and fixes the following issues:

  • Adds granular region tags so that we can include subsets of the sample in the various doc sections
  • Removes dependencies on the local provider

@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • NONE

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @rileykarson, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 346 insertions(+), 62 deletions(-))
Terraform Beta: Diff ( 2 files changed, 346 insertions(+), 62 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 1 file changed, 20 insertions(+), 34 deletions(-))
TF Cloud Doc Samples: Diff ( 1 file changed, 45 insertions(+), 34 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Failed tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 334 insertions(+), 62 deletions(-))
Terraform Beta: Diff ( 2 files changed, 334 insertions(+), 62 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 1 file changed, 20 insertions(+), 40 deletions(-))
TF Cloud Doc Samples: Diff ( 1 file changed, 45 insertions(+), 40 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Failed tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

@rileykarson
Copy link
Member

Note, the error here indicates the provider failed to build:

==> Checking source code against linters...
google/resource_compute_backend_bucket_generated_test.go:389:36: missing ',' in argument list (typecheck)
# Delete after uncommenting above `source` and `content_type` attributes
                                   ^
make: *** [lint] Error 1
GNUmakefile:26: recipe for target 'lint' failed

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 271 insertions(+))
Terraform Beta: Diff ( 2 files changed, 271 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 1 file changed, 20 insertions(+), 40 deletions(-))
TF Cloud Doc Samples: Diff ( 1 file changed, 45 insertions(+), 40 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2095
Passed tests 1865
Skipped tests: 226
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccComputeBackendBucket_externalCdnLbWithBackendBucketExample|TestAccFirebaserulesRelease_BasicRelease|TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccComputeBackendBucket_externalCdnLbWithBackendBucketExample[view]
TestAccFirebaserulesRelease_BasicRelease[view]

Tests failed during RECORDING mode:
TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation[view]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]

Please fix these to complete your PR
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 145 insertions(+))
Terraform Beta: Diff ( 1 file changed, 145 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 1 file changed, 20 insertions(+), 40 deletions(-))
TF Cloud Doc Samples: Diff ( 1 file changed, 45 insertions(+), 40 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2096
Passed tests 1867
Skipped tests: 226
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccSqlUser_mysqlDisabled

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]
TestAccSqlUser_mysqlDisabled[view]

Tests failed during RECORDING mode:
TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation[view]

Please fix these to complete your PR
View the build log or the debug log for each test

@betsy-lichtenberg
Copy link
Contributor Author

Log says:

"Anonymous caller does not have storage.objects.get access to the Google Cloud Storage object."

I think I need to make the object public.

@betsy-lichtenberg
Copy link
Contributor Author

Log says:

"Anonymous caller does not have storage.objects.get access to the Google Cloud Storage object."

I think I need to make the object public.

Nope, I already did that with this:

# make bucket public
resource "google_storage_bucket_iam_member" "default" {
  bucket = google_storage_bucket.default.name
  role   = "roles/storage.objectViewer"
  member = "allUsers"
}

So I don't know why I'm getting this error.

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a conflict that needs to be resolved, otherwise LGTM

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 145 insertions(+))
Terraform Beta: Diff ( 1 file changed, 145 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 1 file changed, 20 insertions(+), 40 deletions(-))
TF Cloud Doc Samples: Diff ( 1 file changed, 45 insertions(+), 40 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2113
Passed tests 1883
Skipped tests: 226
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeBackendBucket_externalCdnLbWithBackendBucketExample|TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccComputeBackendBucket_externalCdnLbWithBackendBucketExample[view]

Tests failed during RECORDING mode:
TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation[view]
TestAccComputeInstance_soleTenantNodeAffinities[view]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]

Please fix these to complete your PR
View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants