Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deleting google_logging_*_bucket_config #5949

Merged

Conversation

ichbinfrog
Copy link
Contributor

@ichbinfrog ichbinfrog commented Apr 17, 2022

Allows deleting log bucket configuration (fixes hashicorp/terraform-provider-google#11412 since I have the same use case as tracked by that issue).

The upstream API already returns a 403: Bucket _Default cannot be deleted (for undeletable buckets) but I opted not to use it because deleting _Default or _Required would always fail then.

I'm not sure whether or not there are e2e tests involved in resource deletion so I had to test them semi-manually (override provider to local built and then creating and destroying resources).

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

logging: made `google_logging_*_bucket_config` deletable

Signed-off-by: Trung <trung.hoang@pricehubble.com>
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@ScottSuarez, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 19 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 1 file changed, 19 insertions(+), 3 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1986
Passed tests 1743
Skipped tests: 240
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccLoggingBucketConfig_CreateBuckets_withCustomId|TestAccFirebaserulesRelease_BasicRelease|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic[view]
TestAccLoggingBucketConfig_CreateBuckets_withCustomId[view]
TestAccFirebaserulesRelease_BasicRelease[view]

All tests passed
View the build log or the debug log for each test

@ScottSuarez
Copy link
Contributor

Could you update your release note to follow the Release Notes Guide

@ichbinfrog
Copy link
Contributor Author

My bad, I've updated the release note on the PR

@ScottSuarez
Copy link
Contributor

thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow deleting the Logging Buckets
3 participants