-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow deleting google_logging_*_bucket_config
#5949
Allow deleting google_logging_*_bucket_config
#5949
Conversation
Signed-off-by: Trung <trung.hoang@pricehubble.com>
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @ScottSuarez, please review this PR or find an appropriate assignee. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 1 file changed, 19 insertions(+), 3 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccLoggingBucketConfig_CreateBuckets_withCustomId|TestAccFirebaserulesRelease_BasicRelease|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic |
Could you update your release note to follow the Release Notes Guide |
My bad, I've updated the release note on the PR |
thanks ! |
Allows deleting log bucket configuration (fixes hashicorp/terraform-provider-google#11412 since I have the same use case as tracked by that issue).
The upstream API already returns a
403: Bucket _Default cannot be deleted
(for undeletable buckets) but I opted not to use it because deleting_Default
or_Required
would always fail then.I'm not sure whether or not there are e2e tests involved in resource deletion so I had to test them semi-manually (override provider to local built and then creating and destroying resources).
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)