Allow deleting google_logging_*_bucket_config
#4234
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows deleting log bucket configuration (fixes hashicorp/terraform-provider-google#11412 since I have the same use case as tracked by that issue).
The upstream API already returns a
403: Bucket _Default cannot be deleted
(for undeletable buckets) but I opted not to use it because deleting_Default
or_Required
would always fail then.I'm not sure whether or not there are e2e tests involved in resource deletion so I had to test them semi-manually (override provider to local built and then creating and destroying resources).
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#5949