Support serviceAccount field for AppEngine flex #6391

ranjithkumar-glean · 2022-08-08T17:47:06Z

Fixes hashicorp/terraform-provider-google#11813

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

appengine: Added field `serviceAccount` to `app_engine_flexible_app_version`

google-cla · 2022-08-08T17:47:09Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

modular-magician · 2022-08-08T17:48:05Z

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @melinath, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

Ensuring it's backwards compatible, covers common error cases, etc.
Summarizing the change into a user-facing changelog note.
Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

modular-magician · 2022-08-08T17:59:24Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 34 insertions(+))
Terraform Beta: Diff ( 2 files changed, 34 insertions(+))
TF Validator: Diff ( 3 files changed, 13 insertions(+), 3 deletions(-))

modular-magician · 2022-08-08T18:44:42Z

Tests analytics

Total tests: 2125
Passed tests 1889
Skipped tests: 227
Failed tests: 9

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccAccessApprovalSettings|TestAccComputeInstance_networkPerformanceConfig|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccCloudFunctions2Function_fullUpdate

modular-magician · 2022-08-08T18:52:00Z

Tests passed during RECORDING mode:
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]
TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample[view]
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[view]
TestAccCloudFunctions2Function_fullUpdate[view]
TestAccAccessApprovalSettings[view]

Tests failed during RECORDING mode:
TestAccComputeInstance_networkPerformanceConfig[view]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[view]
TestAccComputeInstance_soleTenantNodeAffinities[view]
TestAccCloudRunService_cloudRunServiceStaticOutboundExample[view]

Please fix these to complete your PR
View the build log or the debug log for each test

melinath

Thanks for your contribution! Please complete the third checkbox by adding this field to an example or (if that's not possible) to a handwritten test in the third_party folder

ranjithkumar-glean · 2022-08-09T07:26:06Z

Thanks for your contribution! Please complete the third checkbox by adding this field to an example or (if that's not possible) to a handwritten test in the third_party folder

Added field to existing example

modular-magician · 2022-08-09T07:37:02Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 46 insertions(+))
Terraform Beta: Diff ( 3 files changed, 46 insertions(+))
TF Validator: Diff ( 3 files changed, 13 insertions(+), 3 deletions(-))

modular-magician · 2022-08-09T08:12:50Z

Tests analytics

Total tests: 2128
Passed tests 1891
Skipped tests: 227
Failed tests: 10

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccComputeInstance_networkPerformanceConfig|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccCloudFunctions2Function_fullUpdate|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample|TestAccSqlUser_mysqlDisabled

modular-magician · 2022-08-09T08:26:57Z

Tests passed during RECORDING mode:
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]
TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample[view]
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[view]
TestAccCloudFunctions2Function_fullUpdate[view]
TestAccSqlUser_mysqlDisabled[view]

Tests failed during RECORDING mode:
TestAccComputeInstance_networkPerformanceConfig[view]
TestAccComputeInstance_soleTenantNodeAffinities[view]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[view]
TestAccCloudRunService_cloudRunServiceStaticOutboundExample[view]
TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample[view]

Please fix these to complete your PR
View the build log or the debug log for each test

ranjithkumar-glean · 2022-08-09T11:28:41Z

@melinath i added an example, but unable to view failed test cases and logs. It says I don't have access to Google cloud bucket.

mmv1/templates/terraform/examples/app_engine_flexible_app_version.tf.erb

modular-magician · 2022-08-10T08:54:45Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 46 insertions(+))
Terraform Beta: Diff ( 3 files changed, 46 insertions(+))
TF Validator: Diff ( 3 files changed, 13 insertions(+), 3 deletions(-))

modular-magician · 2022-08-10T09:37:08Z

Tests analytics

Total tests: 2128
Passed tests 1892
Skipped tests: 227
Failed tests: 9

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeInstance_networkPerformanceConfig|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccCloudFunctions2Function_fullUpdate|TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample

modular-magician · 2022-08-10T09:44:36Z

Tests passed during RECORDING mode:
TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample[view]
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[view]
TestAccCloudFunctions2Function_fullUpdate[view]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]

Tests failed during RECORDING mode:
TestAccComputeInstance_networkPerformanceConfig[view]
TestAccComputeInstance_soleTenantNodeAffinities[view]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[view]
TestAccCloudRunService_cloudRunServiceStaticOutboundExample[view]
TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample[view]

Please fix these to complete your PR
View the build log or the debug log for each test

edwardsPaul421 · 2022-08-11T09:00:53Z

I think this feature could be easily added the google_app_engine_standard_app_version resource

modular-magician · 2022-08-11T18:21:34Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 37 insertions(+))
Terraform Beta: Diff ( 3 files changed, 37 insertions(+))
TF Validator: Diff ( 3 files changed, 13 insertions(+), 3 deletions(-))

modular-magician · 2022-08-11T18:56:03Z

Tests analytics

Total tests: 2128
Passed tests 1892
Skipped tests: 227
Failed tests: 9

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccComputeInstance_networkPerformanceConfig|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccCloudFunctions2Function_fullUpdate|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample

modular-magician · 2022-08-11T19:07:22Z

Tests passed during RECORDING mode:
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]
TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample[view]
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[view]
TestAccCloudFunctions2Function_fullUpdate[view]

Tests failed during RECORDING mode:
TestAccComputeInstance_networkPerformanceConfig[view]
TestAccComputeInstance_soleTenantNodeAffinities[view]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[view]
TestAccCloudRunService_cloudRunServiceStaticOutboundExample[view]
TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample[view]

Please fix these to complete your PR
View the build log or the debug log for each test

melinath · 2022-08-11T22:33:30Z

It looks like still the same failure - I'm out until next Tuesday but I can take a deeper look next week unless you figure it out in the meantime.

melinath · 2022-08-18T22:31:01Z

Looking at this again - it looks like the error message did change slightly, actually - I think this is a configuration issue in our CI/CD environment. I'll take a look tomorrow.

melinath

okay, I see what's happening here: because this test creates a new project, the cloudservices default service account for that project doesn't have permissions on the service account running the tests overall.

Sorry for getting this wrong previously. I recommend the following:

Go back to creating a new service account in this test (like in 2adaef1) but with a few changes:

set a custom account name like my-account that has a hyphen
using the vars map (not test_env_vars)
make sure you set the project field so that the service account is created inside the project for this test (so that the cloudservices service account will have correct access to it by default)

I think that should do it!

ranjithkumar-glean · 2022-08-22T07:37:17Z

okay, I see what's happening here: because this test creates a new project, the cloudservices default service account for that project doesn't have permissions on the service account running the tests overall.

Sorry for getting this wrong previously. I recommend the following:

Go back to creating a new service account in this test (like in 2adaef1) but with a few changes:

set a custom account name like my-account that has a hyphen

using the vars map (not test_env_vars)

make sure you set the project field so that the service account is created inside the project for this test (so that the cloudservices service account will have correct access to it by default)

I think that should do it!

Thanks, I will update PR by EOD today.

modular-magician · 2022-08-26T19:43:06Z

Tests analytics

Total tests: 2146
Passed tests 1903
Skipped tests: 233
Failed tests: 10

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeInstance_advancedMachineFeatures|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeInstanceTemplate_AdvancedMachineFeatures|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange|TestAccSqlDatabaseInstance_SqlServerAuditConfig|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccComputeInstance_soleTenantNodeAffinities

modular-magician · 2022-08-26T19:58:06Z

Tests passed during RECORDING mode:
TestAccComputeInstance_advancedMachineFeatures[view]
TestAccComputeInstanceTemplate_AdvancedMachineFeatures[view]

Tests failed during RECORDING mode:
TestAccComputeGlobalForwardingRule_internalLoadBalancing[view]
TestAccCloudRunService_cloudRunServiceStaticOutboundExample[view]
TestAccCGCSnippet_eventarcWorkflowsExample[view]
TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample[view]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange[view]
TestAccSqlDatabaseInstance_SqlServerAuditConfig[view]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]
TestAccComputeInstance_soleTenantNodeAffinities[view]

Please fix these to complete your PR
View the build log or the debug log for each test

melinath · 2022-08-26T20:24:28Z

hmm, rerunning tests because the failure looks potentially transient

melinath · 2022-08-26T20:24:33Z

/gcbrun

modular-magician · 2022-08-26T20:36:11Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 62 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 62 insertions(+), 2 deletions(-))
TF Validator: Diff ( 3 files changed, 13 insertions(+), 3 deletions(-))

modular-magician · 2022-08-26T21:39:39Z

Tests analytics

Total tests: 2147
Passed tests 1903
Skipped tests: 233
Failed tests: 11

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccSqlDatabaseInstance_SqlServerAuditConfig|TestAccComputeInstance_advancedMachineFeatures|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeInstanceTemplate_AdvancedMachineFeatures|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccFirebaserulesRelease_BasicRelease|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange

modular-magician · 2022-08-26T21:54:43Z

Tests passed during RECORDING mode:
TestAccComputeInstance_advancedMachineFeatures[view]
TestAccComputeInstanceTemplate_AdvancedMachineFeatures[view]
TestAccFirebaserulesRelease_BasicRelease[view]

Tests failed during RECORDING mode:
TestAccSqlDatabaseInstance_SqlServerAuditConfig[view]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[view]
TestAccCloudRunService_cloudRunServiceStaticOutboundExample[view]
TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample[view]
TestAccComputeInstance_soleTenantNodeAffinities[view]
TestAccCGCSnippet_eventarcWorkflowsExample[view]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange[view]

Please fix these to complete your PR
View the build log or the debug log for each test

melinath · 2022-08-29T21:27:41Z

Hmm, this is still failing - now with the following message:

  | Error waiting to create FlexibleAppVersion: Error waiting for Creating FlexibleAppVersion: Error code 9, message: An internal error occurred while processing task /app-engine-flex/flex_await_healthy/flex_await_healthy>2022-08-26T21:45:22.256Z223209.jc.0: 
  | There was an error while pulling the application's docker image: the image does
  | not exist, one of the image layers is missing or the default service account
  | does not have  permission to pull the image. Please check if the image exists.
  | Also check if the default service account has the role Storage Object Viewer
  | (roles/storage.objectViewer) to pull images from Google Container
  | Registry or Artifact Registry Reader (roles/artifactregistry.reader) to pull
  | images from Artifact Registry. Refer to https://cloud.google.com/container-registry/docs/access-control
  | in granting access to pull images from GCR. Refer to https://cloud.google.com/artifact-registry/docs/access-control#roles
  | in granting access to pull images from Artifact Registry.

I'm going to rerun just the impacted test (TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample) to see if it's just a flake. https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaMmUpstream/331628

ranjithkumar-glean · 2022-08-30T10:41:24Z

Hmm, this is still failing - now with the following message:

  | Error waiting to create FlexibleAppVersion: Error waiting for Creating FlexibleAppVersion: Error code 9, message: An internal error occurred while processing task /app-engine-flex/flex_await_healthy/flex_await_healthy>2022-08-26T21:45:22.256Z223209.jc.0: 
  | There was an error while pulling the application's docker image: the image does
  | not exist, one of the image layers is missing or the default service account
  | does not have  permission to pull the image. Please check if the image exists.
  | Also check if the default service account has the role Storage Object Viewer
  | (roles/storage.objectViewer) to pull images from Google Container
  | Registry or Artifact Registry Reader (roles/artifactregistry.reader) to pull
  | images from Artifact Registry. Refer to https://cloud.google.com/container-registry/docs/access-control
  | in granting access to pull images from GCR. Refer to https://cloud.google.com/artifact-registry/docs/access-control#roles
  | in granting access to pull images from Artifact Registry.

I'm going to rerun just the impacted test (TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample) to see if it's just a flake. https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaMmUpstream/331628

Thanks, but i am not able to open the link to see status. May be we can try adding roles/storage.objectViewerto service account roles if the test run had failed

modular-magician · 2022-09-01T16:52:02Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 74 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 74 insertions(+), 2 deletions(-))
TF Validator: Diff ( 3 files changed, 13 insertions(+), 3 deletions(-))

modular-magician · 2022-09-01T17:39:06Z

Tests analytics

Total tests: 2151
Passed tests 1911
Skipped tests: 233
Failed tests: 7

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccSqlDatabaseInstance_SqlServerAuditConfig|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample

modular-magician · 2022-09-01T17:52:53Z

Tests passed during RECORDING mode:
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[Debug log]

Tests failed during RECORDING mode:
TestAccSqlDatabaseInstance_SqlServerAuditConfig[Error message] [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange[Error message] [Debug log]
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceStaticOutboundExample[Error message] [Debug log]
TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

melinath · 2022-09-01T18:29:14Z

hmm, now it's failing to enable the API - that seems likely a flake. I'm doing a manual run of the test: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloud_ProviderGoogleCloudMmUpstream/333356

ranjithkumar-glean · 2022-09-02T09:33:21Z

Thank you, yeah sounds flaky. what was the result? which API?

melinath · 2022-09-02T16:16:26Z

Thank you, yeah sounds flaky. what was the result? which API?

The flakeyness was in trying to enable the appengine API. The manual run has passed, so I think your change may have been the last fix. I'm going to trigger another full test run out of an abundance of caution. /gcbrun

modular-magician · 2022-09-02T16:29:12Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 74 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 74 insertions(+), 2 deletions(-))
TF Validator: Diff ( 3 files changed, 13 insertions(+), 3 deletions(-))

modular-magician · 2022-09-02T17:32:53Z

Tests analytics

Total tests: 2156
Passed tests 1914
Skipped tests: 234
Failed tests: 8

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange|TestAccSqlDatabaseInstance_SqlServerAuditConfig

modular-magician · 2022-09-02T17:46:44Z

Tests passed during RECORDING mode:
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[Debug log]
TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceStaticOutboundExample[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange[Error message] [Debug log]
TestAccSqlDatabaseInstance_SqlServerAuditConfig[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

ranjithkumar-glean · 2022-09-03T09:26:20Z

Thanks @melinath for helping to get this in, feels nice to contribute back to terraform community.

melinath · 2022-09-06T16:40:02Z

for sure, this was a rough one - thanks for sticking with it!

…6391) * Support serviceAccount field for AppEngine flex * Add service account example * Update account_id * Use vars instead of test env vars * Move account id to right tf example * Update mmv1/templates/terraform/examples/app_engine_flexible_app_version.tf.erb Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Add logs writer and network user role * Update mmv1/templates/terraform/examples/app_engine_flexible_app_version.tf.erb Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Add objectViewer role Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

Support serviceAccount field for AppEngine flex

69a6503

modular-magician requested a review from melinath August 8, 2022 17:48

ranjithkumar-glean mentioned this pull request Aug 8, 2022

Support non default service accounts for AppEngine Flex hashicorp/terraform-provider-google#11813

Closed

melinath requested changes Aug 8, 2022

View reviewed changes

Add service account example

2adaef1

modular-magician requested a review from melinath August 9, 2022 07:26

melinath requested changes Aug 9, 2022

View reviewed changes

mmv1/templates/terraform/examples/app_engine_flexible_app_version.tf.erb Show resolved Hide resolved

Update account_id

0751333

modular-magician requested a review from melinath August 10, 2022 08:44

melinath requested changes Aug 19, 2022

View reviewed changes

Add objectViewer role

17df6b6

melinath approved these changes Sep 2, 2022

View reviewed changes

melinath merged commit f76af3c into GoogleCloudPlatform:main Sep 2, 2022

ranjithkumar-glean deleted the app_sa branch September 3, 2022 09:26

melinath mentioned this pull request Sep 9, 2022

Failing test(s): google_app_engine_flexible_app_version.service_account (permadiff) hashicorp/terraform-provider-google#12527

Closed

roaks3 mentioned this pull request Sep 20, 2022

Support user-managed service account for app engine STANDARD hashicorp/terraform-provider-google#12607

Closed

Support serviceAccount field for AppEngine flex #6391

Support serviceAccount field for AppEngine flex #6391

Conversation

ranjithkumar-glean commented Aug 8, 2022 • edited Loading

google-cla bot commented Aug 8, 2022

modular-magician commented Aug 8, 2022

modular-magician commented Aug 8, 2022

Diff report:

modular-magician commented Aug 8, 2022

Tests analytics

Action taken

modular-magician commented Aug 8, 2022

melinath left a comment

Choose a reason for hiding this comment

ranjithkumar-glean commented Aug 9, 2022

modular-magician commented Aug 9, 2022

Diff report:

modular-magician commented Aug 9, 2022

Tests analytics

Action taken

modular-magician commented Aug 9, 2022

ranjithkumar-glean commented Aug 9, 2022 • edited Loading

modular-magician commented Aug 10, 2022

Diff report:

modular-magician commented Aug 10, 2022

Tests analytics

Action taken

modular-magician commented Aug 10, 2022

edwardsPaul421 commented Aug 11, 2022

modular-magician commented Aug 11, 2022

Diff report:

modular-magician commented Aug 11, 2022

Tests analytics

Action taken

modular-magician commented Aug 11, 2022

melinath commented Aug 11, 2022

melinath commented Aug 18, 2022

melinath left a comment

Choose a reason for hiding this comment

ranjithkumar-glean commented Aug 22, 2022

modular-magician commented Aug 26, 2022

Tests analytics

Action taken

modular-magician commented Aug 26, 2022

melinath commented Aug 26, 2022

melinath commented Aug 26, 2022

modular-magician commented Aug 26, 2022

Diff report:

modular-magician commented Aug 26, 2022

Tests analytics

Action taken

modular-magician commented Aug 26, 2022

melinath commented Aug 29, 2022

ranjithkumar-glean commented Aug 30, 2022

modular-magician commented Sep 1, 2022

Diff report:

modular-magician commented Sep 1, 2022

Tests analytics

Action taken

modular-magician commented Sep 1, 2022

melinath commented Sep 1, 2022

ranjithkumar-glean commented Sep 2, 2022

melinath commented Sep 2, 2022

modular-magician commented Sep 2, 2022

Diff report:

modular-magician commented Sep 2, 2022

Tests analytics

Action taken

modular-magician commented Sep 2, 2022

ranjithkumar-glean commented Sep 3, 2022

melinath commented Sep 6, 2022

ranjithkumar-glean commented Aug 8, 2022 •

edited

Loading

ranjithkumar-glean commented Aug 9, 2022 •

edited

Loading