Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test(s): google_app_engine_flexible_app_version.service_account (permadiff) #12527

Closed
melinath opened this issue Sep 9, 2022 · 3 comments · Fixed by GoogleCloudPlatform/magic-modules#6747, hashicorp/terraform-provider-google-beta#4858 or #12982

Comments

@melinath
Copy link
Collaborator

melinath commented Sep 9, 2022

Failure rate: 100% since Sept 3 2022

Impacted tests:

  • TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample

Nightly builds:

Message:

Terraform will perform the following actions:
# google_app_engine_flexible_app_version.appengine_neg will be updated in-place
~ resource "google_app_engine_flexible_app_version" "appengine_neg" {
id                        = "apps/project-id/services/appengine-network-endpoint-group/versions/v1"
name                      = "apps/project-id/services/appengine-network-endpoint-group/versions/v1"
- service_account           = "project-id@appspot.gserviceaccount.com" -> null
# (9 unchanged attributes hidden)
~ handlers {
# (4 unchanged attributes hidden)
~ static_files {
+ http_headers          = {}
# (5 unchanged attributes hidden)
}
}
# (5 unchanged blocks hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.
@melinath
Copy link
Collaborator Author

melinath commented Sep 9, 2022

This is almost certainly a bug in the implementation of GoogleCloudPlatform/magic-modules#6391 - attn @ranjithkumar-glean in case you want to take a stab at fixing it!

Probably what's happening is that the API is always returning a service account even if one isn't set, causing TF to try to unset it to match the config - the fix is likely to use default_from_api: https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/README.md#terraformyaml

This is not a blocking bug since it doesn't cause a recreate.

@melinath melinath changed the title Failing test(s): TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample (permadiff) Failing test(s): google_app_engine_flexible_app_version.service_account (permadiff) Sep 9, 2022
@melinath
Copy link
Collaborator Author

b/247158627

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.