-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix google_app_engine_flexible_app_version.service_account permadiff #6747
Conversation
Documentation updated for the type field to be in sync with the API docs located at https://cloud.google.com/compute/docs/reference/rest/v1/securityPolicies
Documentation updated for the 'type' field to be in sync with the API docs located at https://cloud.google.com/compute/docs/reference/rest/v1/securityPolicies
…sion in AppEngine
…sion in AppEngine
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @melinath, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 1 insertion(+)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccFirebaserulesRelease_BasicRelease |
Non-VCR test run of the failing test just to make sure everything's good: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloud_ProviderGoogleCloudMmUpstream/349457 |
…oogleCloudPlatform#6747) * Update compute_security_policy documentation for type field Documentation updated for the type field to be in sync with the API docs located at https://cloud.google.com/compute/docs/reference/rest/v1/securityPolicies * Update compute_security_policy documentation for type field Documentation updated for the 'type' field to be in sync with the API docs located at https://cloud.google.com/compute/docs/reference/rest/v1/securityPolicies * Add default_from_api:true flag to serviceAccount under FlexibleAppVersion in AppEngine * Add default_from_api:true flag to serviceAccount under FlexibleAppVersion in AppEngine
thank you @NickElliot and @melinath for fixing this. |
Fixes hashicorp/terraform-provider-google#12527
Adds default_from_api:true to ServiceAccount under FlexibleAppVerison in AppEngine terraform.yaml to resolve permadiff.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)