Support for egress_settings on google_app_engine_standard_app_version…

[millouzgc]

hashicorp/terraform-provider-google#9825

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

appengine: Added `egress_setting` for field `vpc_access_connector` to `google_app_engine_standard_app_version`

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[modular-magician]

Oops! It looks like you're using an unknown release-note type in your changelog entries:

• REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @ScottSuarez, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[modular-magician]

Oops! It looks like you're using an unknown release-note type in your changelog entries:

• REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 94 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 4 files changed, 94 insertions(+), 1 deletion(-))
TF Validator: Diff ( 3 files changed, 14 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2170
Passed tests 1929
Skipped tests: 236
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccAppEngineStandardAppVersion_appEngineStandardAppVersionExample|TestAccAppEngineStandardAppVersion_update

[modular-magician]

Tests passed during RECORDING mode:
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[Debug log]
TestAccAppEngineStandardAppVersion_update[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]
TestAccAppEngineStandardAppVersion_appEngineStandardAppVersionExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 103 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 4 files changed, 103 insertions(+), 9 deletions(-))
TF Validator: Diff ( 3 files changed, 14 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2170
Passed tests 1929
Skipped tests: 236
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccAppEngineStandardAppVersion_appEngineStandardAppVersionExample|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]
TestAccAppEngineStandardAppVersion_appEngineStandardAppVersionExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[millouzgc]

Hello, this is my first attempt, I see that there are failures on some tests. I don't have access to the Logs, can you give me the procedure to follow?
Best Regards.

[ScottSuarez]

This was the failure from the test. If possible, try to run the test locally. You can checkout the built branch if need.

=== RUN   TestAccAppEngineStandardAppVersion_appEngineStandardAppVersionExample
=== PAUSE TestAccAppEngineStandardAppVersion_appEngineStandardAppVersionExample
=== CONT  TestAccAppEngineStandardAppVersion_appEngineStandardAppVersionExample
    provider_test.go:315: Step 1/2 error: Error running apply: exit status 1
        
        Error: Error creating StandardAppVersion: googleapi: Error 400: The value for version.vpc_access_connector.name must be in format "projects/<project ID>/locations/<location ID>/connectors/<connector ID>".
        
          with google_app_engine_standard_app_version.myapp_python_private_vpc,
          on terraform_plugin_test.tf line 65, in resource "google_app_engine_standard_app_version" "myapp_python_private_vpc":
          65: resource "google_app_engine_standard_app_version" "myapp_python_private_vpc" {
        
--- FAIL: TestAccAppEngineStandardAppVersion_appEngineStandardAppVersionExample (116.59s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-google-beta/google-beta	116.650s
FAIL

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 177 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 4 files changed, 177 insertions(+), 9 deletions(-))
TF Validator: Diff ( 3 files changed, 14 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2172
Passed tests 1925
Skipped tests: 238
Failed tests: 9

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccCloudFunctionsFunction_vpcConnector|TestAccAppEngineStandardAppVersion_appEngineStandardAppVersionOutboundExample|TestAccAppEngineStandardAppVersion_update|TestAccVPCAccessConnector_cloudrunVPCAccessConnectorExample|TestAccVPCAccessConnector_vpcAccessConnectorSharedVPCExample|TestAccVPCAccessConnector_vpcAccessConnectorExample

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceStaticOutboundExample[Error message] [Debug log]
TestAccCloudFunctionsFunction_vpcConnector[Error message] [Debug log]
TestAccAppEngineStandardAppVersion_appEngineStandardAppVersionOutboundExample[Error message] [Debug log]
TestAccAppEngineStandardAppVersion_update[Error message] [Debug log]
TestAccVPCAccessConnector_cloudrunVPCAccessConnectorExample[Error message] [Debug log]
TestAccVPCAccessConnector_vpcAccessConnectorSharedVPCExample[Error message] [Debug log]
TestAccVPCAccessConnector_vpcAccessConnectorExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 178 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 4 files changed, 178 insertions(+), 9 deletions(-))
TF Validator: Diff ( 3 files changed, 14 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2172
Passed tests 1931
Skipped tests: 238
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeInstance_soleTenantNodeAffinities|TestAccAppEngineStandardAppVersion_appEngineStandardAppVersionOutboundExample|TestAccCGCSnippet_eventarcWorkflowsExample

[modular-magician]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccAppEngineStandardAppVersion_appEngineStandardAppVersionOutboundExample[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[millouzgc]

Hi @ScottSuarez, I reviewed the test phase and passed the egress_setting variable as string type.
I tested and validated the provider, it's ok.
I tested appEngineStandardAppVersionOutboundExample by displaying it in documentation and validating the generated terraform.
Is there any other way to validate the tests?
Can you help me to finalize this modification ?

[ScottSuarez]

I've surfaced the reason for the current failure

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 37 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 3 files changed, 37 insertions(+), 9 deletions(-))
TF Validator: Diff ( 3 files changed, 14 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2173
Passed tests 1930
Skipped tests: 238
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeForwardingRule_update|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccStorageTransferJob_transferOptions

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeForwardingRule_update[Debug log]
TestAccStorageTransferJob_transferOptions[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[millouzgc]

Hi @ScottSuarez, Tell me if this is ok for you?

[ScottSuarez]

I'm fine with this approach. Thanks for the work !

[ScottSuarez]

Sorry to switch back, but realized the api.yaml example wasn't exposed to docs, so functionally serves no purpose.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 37 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 3 files changed, 37 insertions(+), 9 deletions(-))
TF Validator: Diff ( 3 files changed, 14 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2176
Passed tests 1936
Skipped tests: 238
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample

[modular-magician]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test