Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for egress_settings on google_app_engine_standard_app_version… #6535

Merged
merged 7 commits into from
Sep 20, 2022
Merged

Support for egress_settings on google_app_engine_standard_app_version… #6535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c20fdf8
Support for egress_settings on google_app_engine_standard_app_version…
millouzgc Sep 11, 2022
f18ae90
add test and docs
millouzgc Sep 11, 2022
c6c6782
Typo : tabulation in space
millouzgc Sep 12, 2022
80816aa
Change Enum to String, update tests validations
millouzgc Sep 13, 2022
d67d944
fix org_id and change ip mask
millouzgc Sep 14, 2022
3164553
skip test for app_engine_standard_app_version_outbound
millouzgc Sep 16, 2022
fb71be3
remove too long outbound example
millouzgc Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions mmv1/products/appengine/api.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,6 +477,10 @@ objects:
required: true
description: |
Full Serverless VPC Access Connector name e.g. /projects/my-project/locations/us-central1/connectors/c1.
- !ruby/object:Api::Type::String
name: 'egressSetting'
description: |
The egress setting for the connector, controlling what traffic is diverted through it.
- !ruby/object:Api::Type::Array
name: 'inboundServices'
description: |
Expand Down
20 changes: 11 additions & 9 deletions mmv1/third_party/terraform/tests/resource_app_engine_standard_app_version_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
package google

import (
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
"testing"

"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
)

func TestAccAppEngineStandardAppVersion_update(t *testing.T) {
Expand Down Expand Up @@ -166,14 +167,14 @@ resource "google_project_service" "vpcaccess_api" {
}

resource "google_vpc_access_connector" "bar" {
depends_on = [
depends_on = [
google_project_service.vpcaccess_api
]
project = google_project.my_project.project_id
name = "bar"
region = "us-central1"
ip_cidr_range = "10.8.0.0/28"
network = "default"
project = google_project.my_project.project_id
name = "bar"
region = "us-central1"
ip_cidr_range = "10.8.0.0/28"
network = "default"
}

resource "google_app_engine_standard_app_version" "foo" {
Expand All @@ -182,8 +183,9 @@ resource "google_app_engine_standard_app_version" "foo" {
service = "default"
runtime = "python38"

vpc_access_connector {
name = "${google_vpc_access_connector.bar.id}"
vpc_access_connector {
name = "${google_vpc_access_connector.bar.id}"
egress_setting = "ALL_TRAFFIC"
}

entrypoint {
Expand Down