Add Firebase AppleApp Data Source #6876

mraouffouad · 2022-11-28T00:59:21Z

A new datasource for Firebase AppleApp.

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_firebase_apple_app`

…le test

…ion so they show up in docs.

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

…pdate_test.go.erb Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

modular-magician · 2022-12-09T20:39:32Z

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccDataSourceGoogleFirebaseAppleApp[Debug log]

All tests passed
View the build log or the debug log for each test

mraouffouad · 2022-12-09T20:45:42Z

@roaks3 All tests pass and this PR is ready now.

mraouffouad · 2022-12-12T14:32:42Z

@roaks3 Ping!

roaks3

Code looks good, only a few minor comments and then this should be good to go.

roaks3 · 2022-12-13T18:09:43Z

mmv1/third_party/terraform/data_sources/data_source_google_firebase_web_app.go.erb

@@ -12,7 +12,7 @@ func dataSourceGoogleFirebaseWebApp() *schema.Resource {
 	dsSchema := datasourceSchemaFromResourceSchema(resourceFirebaseWebApp().Schema)

 	// Set 'Required' schema elements
-	addRequiredFieldsToSchema(dsSchema, "app_id")


Could you remove the whitespace changes? It doesn't look like this file has any changes of interest.

@mraouffouad just following up because I saw you made updates, but the whitespace changes have not been addressed yet. For example, this file should have no changes in the final diff.

roaks3 · 2022-12-13T18:10:29Z

mmv1/third_party/terraform/utils/provider.go.erb

@@ -216,7 +216,7 @@ func Provider() *schema.Provider {
 			"google_compute_backend_service":                   dataSourceGoogleComputeBackendService(),
 			"google_compute_backend_bucket":                    dataSourceGoogleComputeBackendBucket(),
 			"google_compute_default_service_account":           dataSourceGoogleComputeDefaultServiceAccount(),
-			"google_compute_disk":        					    dataSourceGoogleComputeDisk(),
+			"google_compute_disk":        		            dataSourceGoogleComputeDisk(),


Same comment around whitespace changes: could you revert them here and on the other lines in this file?

roaks3 · 2022-12-13T18:11:47Z

mmv1/third_party/terraform/website/docs/d/firebase_apple_app.html.markdown

+
+* `app_id` -
+  (Required)
+  The app_ip of name of the Firebase iosApp.


Looks like we want app_id instead of app_ip. I think this may be a mistake in the other Firebase datasources as well, so feel free to make those updates in this same PR if you'd like.

modular-magician · 2022-12-13T19:06:18Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 60 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 5 files changed, 150 insertions(+), 1 deletion(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-12-13T19:55:11Z

Tests analytics

Total tests: 2345
Passed tests 2098
Skipped tests: 246
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccLoggingBucketConfigProject_cmekSettings

modular-magician · 2022-12-13T19:56:30Z

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]

All tests passed
View the build log or the debug log for each test

modular-magician · 2022-12-13T23:24:10Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 60 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 5 files changed, 150 insertions(+), 1 deletion(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-12-14T00:12:43Z

Tests analytics

Total tests: 2347
Passed tests 2099
Skipped tests: 246
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccContainerCluster_withInvalidGatewayApiConfigChannel|TestAccLoggingBucketConfigProject_cmekSettings

modular-magician · 2022-12-14T00:13:56Z

Tests passed during RECORDING mode:
TestAccContainerCluster_withInvalidGatewayApiConfigChannel[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]

All tests passed
View the build log or the debug log for each test

modular-magician · 2022-12-14T16:00:36Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 60 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 5 files changed, 150 insertions(+), 1 deletion(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-12-14T16:08:51Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 60 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 5 files changed, 150 insertions(+), 1 deletion(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-12-14T16:41:07Z

Tests analytics

Total tests: 2347
Passed tests 2098
Skipped tests: 246
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccLoggingBucketConfigProject_cmekSettings|TestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withInvalidGatewayApiConfigChannel

modular-magician · 2022-12-14T16:42:26Z

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccContainerCluster_withInvalidGatewayApiConfigChannel[Debug log]

All tests passed
View the build log or the debug log for each test

modular-magician · 2022-12-14T17:02:21Z

Tests analytics

Total tests: 2347
Passed tests 2099
Skipped tests: 246
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccLoggingBucketConfigProject_cmekSettings|TestAccContainerCluster_withInvalidGatewayApiConfigChannel

modular-magician · 2022-12-14T17:03:37Z

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccContainerCluster_withInvalidGatewayApiConfigChannel[Debug log]

All tests passed
View the build log or the debug log for each test

mraouffouad · 2022-12-14T17:48:11Z

@roaks3 Thanks for reviewing. Please merge.

mraouffouad and others added 30 commits September 28, 2022 15:00

Update api.yaml

cd2e519

Update api.yaml

1b15c11

Update api.yaml

165fe20

Update api.yaml

e8e5952

Update terraform.yaml

7e4c7b6

Create firebase_apple_app_basic.tf.erb

ddf4945

Responding to tylerg-dev's comments

aa06508

Fixing the failing TestAccFirebaseAppleApp_firebaseAppleAppBasicExamp…

b4bdab7

…le test

Add a handwritten sweeper to hard-delete the AppleApp

538088e

Fix typo in update_mask

34d6a94

Fix var name in test

5810834

Add delete request body

8eba423

Change appId to app_id in the sweeper delete url

15bac81

Use custom_delete for deleting the AppleApp resource

c367f5e

Merge branch 'main' into ios_app

ff60f99

Update api.yaml

d332361

Remove the repeated block in terraform.api

6e89e74

Add a 5 sec in the post_delete template

9805363

Move the 5 sec delay to the custom delete code

46c1231

Add "Optional" to the deletion_policy description.

f4e7399

Merge branch 'GoogleCloudPlatform:main' into ios_app

d5e1d4e

Merge branch 'main' into ios_app

20641e3

Merge branch 'GoogleCloudPlatform:main' into ios_app

15f9662

Address melinath@ comments

0f57c62

Add a manual update test

1830e35

Remove unnecessary randomness. Also, move attributes to the vars sect…

5c8ca6b

…ion so they show up in docs.

Update mmv1/products/firebase/terraform.yaml

001787e

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

Update mmv1/products/firebase/terraform.yaml

7f47475

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

Update mmv1/products/firebase/terraform.yaml

6bce9c0

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

Update mmv1/third_party/terraform/tests/resource_firebase_apple_app_u…

c9ca82e

…pdate_test.go.erb Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

roaks3 requested changes Dec 13, 2022

View reviewed changes

Responding to roaks3's comments

4c81148

modular-magician requested a review from roaks3 December 13, 2022 18:50

Merge branch 'GoogleCloudPlatform:main' into ios_app

4a5e880

Merge branch 'GoogleCloudPlatform:main' into ios_app

fc7db85

mraouffouad added 2 commits December 14, 2022 10:44

Remove ws from data_source_google_firebase_web_app.go.erb

23917ac

Remove unneeded whitespaces from provider.go.erb

4be0ff3

roaks3 approved these changes Dec 14, 2022

View reviewed changes

roaks3 merged commit 7011e81 into GoogleCloudPlatform:main Dec 14, 2022

This was referenced Dec 14, 2022

Add Firebase AppleApp Data Source hashicorp/terraform-provider-google-beta#4978

Merged

Add Firebase AppleApp Data Source hashicorp/terraform-provider-google#13239

Merged

melinath added the service/firebasestorage label Jan 19, 2023

melinath added service/firebase and removed service/firebasestorage labels Feb 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Firebase AppleApp Data Source #6876

Add Firebase AppleApp Data Source #6876

mraouffouad commented Nov 28, 2022 •

edited

Loading

modular-magician commented Dec 9, 2022

mraouffouad commented Dec 9, 2022

mraouffouad commented Dec 12, 2022

roaks3 left a comment

roaks3 Dec 13, 2022

roaks3 Dec 14, 2022

roaks3 Dec 13, 2022

roaks3 Dec 13, 2022

modular-magician commented Dec 13, 2022

modular-magician commented Dec 13, 2022

modular-magician commented Dec 13, 2022

modular-magician commented Dec 13, 2022

modular-magician commented Dec 14, 2022

modular-magician commented Dec 14, 2022

modular-magician commented Dec 14, 2022

modular-magician commented Dec 14, 2022

modular-magician commented Dec 14, 2022

modular-magician commented Dec 14, 2022

modular-magician commented Dec 14, 2022

modular-magician commented Dec 14, 2022

mraouffouad commented Dec 14, 2022

Add Firebase AppleApp Data Source #6876

Add Firebase AppleApp Data Source #6876

Conversation

mraouffouad commented Nov 28, 2022 • edited Loading

modular-magician commented Dec 9, 2022

mraouffouad commented Dec 9, 2022

mraouffouad commented Dec 12, 2022

roaks3 left a comment

Choose a reason for hiding this comment

roaks3 Dec 13, 2022

Choose a reason for hiding this comment

roaks3 Dec 14, 2022

Choose a reason for hiding this comment

roaks3 Dec 13, 2022

Choose a reason for hiding this comment

roaks3 Dec 13, 2022

Choose a reason for hiding this comment

modular-magician commented Dec 13, 2022

Diff report

modular-magician commented Dec 13, 2022

Tests analytics

Action taken

modular-magician commented Dec 13, 2022

modular-magician commented Dec 13, 2022

Diff report

modular-magician commented Dec 14, 2022

Tests analytics

Action taken

modular-magician commented Dec 14, 2022

modular-magician commented Dec 14, 2022

Diff report

modular-magician commented Dec 14, 2022

Diff report

modular-magician commented Dec 14, 2022

Tests analytics

Action taken

modular-magician commented Dec 14, 2022

modular-magician commented Dec 14, 2022

Tests analytics

Action taken

modular-magician commented Dec 14, 2022

mraouffouad commented Dec 14, 2022

mraouffouad commented Nov 28, 2022 •

edited

Loading