Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Firebase AppleApp Data Source #6876

Merged
merged 52 commits into from
Dec 14, 2022
Merged

Add Firebase AppleApp Data Source #6876

merged 52 commits into from
Dec 14, 2022

Commits on Sep 28, 2022

  1. Update api.yaml

    @mraouffouad
    mraouffouad authored Sep 28, 2022
    Configuration menu
    Copy the full SHA
    cd2e519 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2022

  1. Update api.yaml

    @mraouffouad
    mraouffouad authored Sep 29, 2022
    Configuration menu
    Copy the full SHA
    1b15c11 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2022

  1. Update api.yaml

    @mraouffouad
    mraouffouad authored Sep 30, 2022
    Configuration menu
    Copy the full SHA
    165fe20 View commit details
    Browse the repository at this point in the history

  2. Update api.yaml

    @mraouffouad
    mraouffouad authored Sep 30, 2022
    Configuration menu
    Copy the full SHA
    e8e5952 View commit details
    Browse the repository at this point in the history

  3. Update terraform.yaml

    @mraouffouad
    mraouffouad authored Sep 30, 2022
    Configuration menu
    Copy the full SHA
    7e4c7b6 View commit details
    Browse the repository at this point in the history

  4. Create firebase_apple_app_basic.tf.erb

    @mraouffouad
    mraouffouad authored Sep 30, 2022
    Configuration menu
    Copy the full SHA
    ddf4945 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2022

  1. Responding to tylerg-dev's comments

    @mraouffouad
    mraouffouad committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    aa06508 View commit details
    Browse the repository at this point in the history

  2. Fixing the failing TestAccFirebaseAppleApp_firebaseAppleAppBasicExamp… 

    …le test
    @mraouffouad
    mraouffouad committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    b4bdab7 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2022

  1. Add a handwritten sweeper to hard-delete the AppleApp

    @mraouffouad
    mraouffouad committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    538088e View commit details
    Browse the repository at this point in the history

  2. Fix typo in update_mask

    @mraouffouad
    mraouffouad committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    34d6a94 View commit details
    Browse the repository at this point in the history

  3. Fix var name in test

    @mraouffouad
    mraouffouad committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    5810834 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2022

  1. Add delete request body

    @mraouffouad
    mraouffouad committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    8eba423 View commit details
    Browse the repository at this point in the history

  2. Change appId to app_id in the sweeper delete url

    @mraouffouad
    mraouffouad committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    15bac81 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. Use custom_delete for deleting the AppleApp resource

    @mraouffouad
    mraouffouad committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    c367f5e View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2022

  1. Merge branch 'main' into ios_app

    @mraouffouad
    mraouffouad authored Oct 18, 2022
    Configuration menu
    Copy the full SHA
    ff60f99 View commit details
    Browse the repository at this point in the history

  2. Update api.yaml

    @mraouffouad
    mraouffouad authored Oct 18, 2022
    Configuration menu
    Copy the full SHA
    d332361 View commit details
    Browse the repository at this point in the history

  3. Remove the repeated block in terraform.api

    @mraouffouad
    mraouffouad authored Oct 18, 2022
    Configuration menu
    Copy the full SHA
    6e89e74 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2022

  1. Add a 5 sec in the post_delete template

    @mraouffouad
    mraouffouad committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    9805363 View commit details
    Browse the repository at this point in the history

  2. Move the 5 sec delay to the custom delete code

    @mraouffouad
    mraouffouad committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    46c1231 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. Add "Optional" to the deletion_policy description.

    @mraouffouad
    mraouffouad authored Oct 20, 2022
    Configuration menu
    Copy the full SHA
    f4e7399 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'GoogleCloudPlatform:main' into ios_app

    @mraouffouad
    mraouffouad authored Oct 20, 2022
    Configuration menu
    Copy the full SHA
    d5e1d4e View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2022

  1. Merge branch 'main' into ios_app

    @mraouffouad
    mraouffouad authored Oct 21, 2022
    Configuration menu
    Copy the full SHA
    20641e3 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. Merge branch 'GoogleCloudPlatform:main' into ios_app

    @mraouffouad
    mraouffouad authored Nov 3, 2022
    Configuration menu
    Copy the full SHA
    15f9662 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2022

  1. Address melinath@ comments

    @mraouffouad
    mraouffouad committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    0f57c62 View commit details
    Browse the repository at this point in the history

  2. Add a manual update test

    @mraouffouad
    mraouffouad committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    1830e35 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2022

  1. Remove unnecessary randomness. Also, move attributes to the vars sect… 

    …ion so they show up in docs.
    @mraouffouad
    mraouffouad committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    5c8ca6b View commit details
    Browse the repository at this point in the history

  2. Update mmv1/products/firebase/terraform.yaml 

    Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
    @mraouffouad @melinath
    mraouffouad and melinath authored Nov 11, 2022
    Configuration menu
    Copy the full SHA
    001787e View commit details
    Browse the repository at this point in the history

  3. Update mmv1/products/firebase/terraform.yaml 

    Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
    @mraouffouad @melinath
    mraouffouad and melinath authored Nov 11, 2022
    Configuration menu
    Copy the full SHA
    7f47475 View commit details
    Browse the repository at this point in the history

  4. Update mmv1/products/firebase/terraform.yaml 

    Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
    @mraouffouad @melinath
    mraouffouad and melinath authored Nov 11, 2022
    Configuration menu
    Copy the full SHA
    6bce9c0 View commit details
    Browse the repository at this point in the history

  5. Update mmv1/third_party/terraform/tests/resource_firebase_apple_app_u… 

    …pdate_test.go.erb

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
    @mraouffouad @melinath
    mraouffouad and melinath authored Nov 11, 2022
    Configuration menu
    Copy the full SHA
    c9ca82e View commit details
    Browse the repository at this point in the history

  6. Update mmv1/third_party/terraform/tests/resource_firebase_apple_app_u… 

    …pdate_test.go.erb

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
    @mraouffouad @melinath
    mraouffouad and melinath authored Nov 11, 2022
    Configuration menu
    Copy the full SHA
    387eaff View commit details
    Browse the repository at this point in the history

  7. Update mmv1/third_party/terraform/tests/resource_firebase_apple_app_u… 

    …pdate_test.go.erb

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
    @mraouffouad @melinath
    mraouffouad and melinath authored Nov 11, 2022
    Configuration menu
    Copy the full SHA
    7dcb89a View commit details
    Browse the repository at this point in the history

  8. Adding back the test_vars_overrides.

    @mraouffouad
    mraouffouad authored Nov 11, 2022
    Configuration menu
    Copy the full SHA
    5b5ba72 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2022

  1. Merge branch 'GoogleCloudPlatform:main' into ios_app

    @mraouffouad
    mraouffouad authored Nov 27, 2022
    Configuration menu
    Copy the full SHA
    4cc80e4 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2022

  1. Add a Datasource for Firebase AppleApp

    @mraouffouad
    mraouffouad committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    0121239 View commit details
    Browse the repository at this point in the history

  2. Fix lint warnings

    @mraouffouad
    mraouffouad committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    89689ba View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2022

  1. Add documentations and fix the test

    @mraouffouad
    mraouffouad committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    aba4652 View commit details
    Browse the repository at this point in the history

  2. Update the test providers.

    @mraouffouad
    mraouffouad authored Dec 2, 2022
    Configuration menu
    Copy the full SHA
    fd0c71d View commit details
    Browse the repository at this point in the history

  3. Remove the providers from the AppleApp datasource tests

    @mraouffouad
    mraouffouad authored Dec 2, 2022
    Configuration menu
    Copy the full SHA
    745a62b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'GoogleCloudPlatform:main' into ios_app

    @mraouffouad
    mraouffouad authored Dec 2, 2022
    Configuration menu
    Copy the full SHA
    96a89f4 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2022

  1. Merge branch 'GoogleCloudPlatform:main' into ios_app

    @mraouffouad
    mraouffouad authored Dec 5, 2022
    Configuration menu
    Copy the full SHA
    358cd48 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'GoogleCloudPlatform:main' into ios_app

    @mraouffouad
    mraouffouad authored Dec 5, 2022
    Configuration menu
    Copy the full SHA
    0617222 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2022

  1. Add GA tags to the data source test and rename it to .go.erb

    @mraouffouad
    mraouffouad authored Dec 6, 2022
    Configuration menu
    Copy the full SHA
    5305c73 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. Merge branch 'main' into ios_app

    @mraouffouad
    mraouffouad authored Dec 7, 2022
    Configuration menu
    Copy the full SHA
    862b055 View commit details
    Browse the repository at this point in the history

  2. Fix tabs in Datasource map.

    @mraouffouad
    mraouffouad authored Dec 7, 2022
    Configuration menu
    Copy the full SHA
    aafecb0 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2022

  1. Merge branch 'GoogleCloudPlatform:main' into ios_app

    @mraouffouad
    mraouffouad authored Dec 9, 2022
    Configuration menu
    Copy the full SHA
    e8bf844 View commit details
    Browse the repository at this point in the history

  2. Add randomness to bundle_id to avoid collision.

    @mraouffouad
    mraouffouad authored Dec 9, 2022
    Configuration menu
    Copy the full SHA
    e50906c View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. Responding to roaks3's comments

    @mraouffouad
    mraouffouad committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    4c81148 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'GoogleCloudPlatform:main' into ios_app

    @mraouffouad
    mraouffouad authored Dec 13, 2022
    Configuration menu
    Copy the full SHA
    4a5e880 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'GoogleCloudPlatform:main' into ios_app

    @mraouffouad
    mraouffouad authored Dec 13, 2022
    Configuration menu
    Copy the full SHA
    fc7db85 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. Remove ws from data_source_google_firebase_web_app.go.erb

    @mraouffouad
    mraouffouad authored Dec 14, 2022
    Configuration menu
    Copy the full SHA
    23917ac View commit details
    Browse the repository at this point in the history

  2. Remove unneeded whitespaces from provider.go.erb

    @mraouffouad
    mraouffouad authored Dec 14, 2022
    Configuration menu
    Copy the full SHA
    4be0ff3 View commit details
    Browse the repository at this point in the history