Cloud Workstations - Workstation

[bschaatsbergen]

Fixes hashicorp/terraform-provider-google#12763

The leading pull request for this is: #7005, that should be merged first. (as I've split up the PRs for this new service)

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

workstations: removed invalid import formats from workstations resources

`google_workstations_workstation`

[modular-magician]

Oops! It looks like you're using an unknown release-note type in your changelog entries:

• REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @rileykarson, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

[modular-magician]

Tests analytics

Total tests: 2367
Passed tests 2116
Skipped tests: 247
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withInvalidGatewayApiConfigChannel|TestAccLoggingBucketConfigProject_cmekSettings|TestAccBigQueryDataTable_bigtable

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccContainerCluster_withInvalidGatewayApiConfigChannel[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccBigQueryDataTable_bigtable[Debug log]

All tests passed
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 130 insertions(+))
Terraform Beta: Diff ( 4 files changed, 825 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2445
Passed tests 2189
Skipped tests: 254
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccLoggingBucketConfigProject_cmekSettings|TestAccContainerCluster_failedCreation

[rileykarson]

I see this is a draft- let me know if you'd prefer I don't comment any more until it's marked ready! There isn't standard etiquette around drafts I am aware of so I'm never sure if I should wait or not.

[modular-magician]

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccContainerCluster_failedCreation[Debug log]

All tests passed
View the build log or the debug log for each test

[trodge]

/gcbrun

[bschaatsbergen]

I see this is a draft- let me know if you'd prefer I don't comment any more until it's marked ready! There isn't standard etiquette around drafts I am aware of so I'm never sure if I should wait or not.

Pulliing this ready for review now :)

[bschaatsbergen]

Heya @trodge, just fixed the issue raised in the generate-diffs check - could we rerun it please?

[SarahFrench]

Just a heads up that some of the Workstation tests merged into main recently have failed - hashicorp/terraform-provider-google#13847

The failure above for TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample is:

=== CONT  TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample
    provider_test.go:319: Step 1/2 error: Error running apply: exit status 1
        
        Error: Error creating service account: googleapi: Error 409: Service account cloud-workstations-kms already exists within project projects/PROJECT.
        Details:
        [
          {
            "@type": "type.googleapis.com/google.rpc.ResourceInfo",
            "resourceName": "projects/PROJECT/serviceAccounts/cloud-workstations-kms@PROJECT.iam.gserviceaccount.com"
          }
        ]
        , alreadyExists
        
          with google_service_account.default,
          on terraform_plugin_test.tf line 46, in resource "google_service_account" "default":
          46: resource "google_service_account" "default" {
        
--- FAIL: TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample (3106.41s)

I think this is due to the test now running across multiple PRs at once, versus running once at a time on the PR that added the test. My bad, I should have spotted during review!

[SarahFrench]

I think the test above can be fixed by adding the random suffix the end of service_account_id in the example used to make that test. I'm happy to open a separate PR for that, but I'm at EOD so would do it tomorrow at the earliest

[bschaatsbergen]

I'll prep a PR for this @SarahFrench 👍🏼

#7362

[rileykarson]

This was just a 500, not a synchronous request timeout. Gonna check this was intermittent / generate new logs by trying again:

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 192 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 10 files changed, 1072 insertions(+), 6 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 161 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 192 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 10 files changed, 1072 insertions(+), 6 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 161 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2482
Passed tests 2223
Skipped tests: 255
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccWorkstationsWorkstation_update|TestAccWorkstationsWorkstation_workstationBasicExample|TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample|TestAccFirebaserulesRelease_BasicRelease

[modular-magician]

Tests analytics

Total tests: 2482
Passed tests 2224
Skipped tests: 255
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample|TestAccWorkstationsWorkstation_update|TestAccWorkstationsWorkstation_workstationBasicExample

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccWorkstationsWorkstation_update[Error message] [Debug log]
TestAccWorkstationsWorkstation_workstationBasicExample[Error message] [Debug log]
TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[modular-magician]

The provider crashed while running the VCR tests in RECORDING mode
Please fix it to complete your PR
View the build log

[rileykarson]

(we hit a global timeout to cause that crash)

[bschaatsbergen]

Any idea what the error might indicate @rileykarson ?

[rileykarson]

The previous error was just the timeout manifesting in a different way.

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 192 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 10 files changed, 1072 insertions(+), 6 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 161 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2485
Passed tests 2226
Skipped tests: 255
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccWorkstationsWorkstation_workstationBasicExample|TestAccWorkstationsWorkstation_update|TestAccFirebaserulesRelease_BasicRelease|TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample

[bschaatsbergen]

Heading off to bed, if there's anything that needs to be fixed - feel free to commit in my branch, otherwise I'll address it tomororow morning 👌

[modular-magician]

Tests passed during RECORDING mode:
TestAccWorkstationsWorkstation_workstationBasicExample[Debug log]
TestAccWorkstationsWorkstation_update[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[bschaatsbergen]

Rebasing, should solve the failed test. Other tests now passed too - great. On phone now, can't rebase..

[rileykarson]

LGTM

Merging does the same thing as a rebase anyways, there's no need to do one unless there are merge conflicts or you're asked to by a reviewer!

[bschaatsbergen]

Amazing! I'll create another PR for the IAM resource tomorrow :)