Add random suffix to Cloud Workstations SA to prevent cross test runs from failing

[bschaatsbergen]

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
• Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

[modular-magician]

Oops! It looks like you're using an unknown release-note type in your changelog entries:

• REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

[bschaatsbergen]

I see a lot of SAs also being created as following:

resource "google_service_account" "test-account" {
  account_id   = "<%= ctx[:vars]['account_id'] %>"
  display_name = "Test Service Account"
}

What's preferred?

[bschaatsbergen]

I haven't defined random_suffix anywhere, but noticed it was present in many tests. Is it being injected automagically?

[rileykarson]

Yeah, it'll be injected when "<%= ctx[:vars]['account_id'] %>" is supplied (alongside a corresponding entry in terraform.yaml)

[bschaatsbergen]

I've used account_id and set it through the terraform.yaml like the other tests do, still confused how this will solve the issue - all the account_id entries in other tests are set to 'my-account'... will this not cause the same issue?

[rileykarson]

I see a lot of SAs also being created as following:...

That's the preferred method! Per your other comment, the random suffix is injected based on this pattern being used: https://googlecloudplatform.github.io/magic-modules/docs/how-to/add-mmv1-test/#example-configuration-file and https://googlecloudplatform.github.io/magic-modules/docs/how-to/add-mmv1-test/#results

That will add a simple value to documentation, but add the suffix to the test so that we ensure the value is unique.

[modular-magician]

Oops! It looks like you're using an unknown release-note type in your changelog entries:

• REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

[bschaatsbergen]

@rileykarson can you check my latest commit :)?

[rileykarson]

/gcbrun

[rileykarson]

Looks good, running tests to verify.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 3 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 1 file changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2483
Passed tests 2226
Skipped tests: 255
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample|TestAccFirebaserulesRelease_BasicRelease

[bschaatsbergen]

🤔

[rileykarson]

Re-recording is expected, since we changed the value.

[modular-magician]

Tests passed during RECORDING mode:
TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]

All tests passed
View the build log or the debug log for each test

[rileykarson]

Rake error can be ignored (rebase would resolve)