feat: add autoscaling option to Vertex Feature Store

[ghost]

Fixes hashicorp/terraform-provider-google#13344

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

PR Description

...

vertexai: added `scaling` field in `google_vertex_ai_featurestore`

[modular-magician]

Oops! It looks like you're using an unknown release-note type in your changelog entries:

• REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @zli82016, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[ghost]

I have generated the terraform for the changed resources and successfully run make test and make lint

Generating the terraform for all resources led to the unit tests breaking - suspect this is something to do with my environment

I'm not sure how to run the acceptance tests per the PR checklist

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 134 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 2 files changed, 134 insertions(+), 4 deletions(-))
TF Validator: Diff ( 3 files changed, 44 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2379
Passed tests 2129
Skipped tests: 248
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withInvalidGatewayApiConfigChannel

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccContainerCluster_withInvalidGatewayApiConfigChannel[Debug log]

All tests passed
View the build log or the debug log for each test

[ghost]

@zli82016 please could you take a look at this PR? I am not sure how to run the acceptance tests but all the other tests are passing OK.

[zli82016]

Hello, @browningjp-datatonic,
This is the documentation to run the acceptance tests. https://googlecloudplatform.github.io/magic-modules/docs/getting-started/run-provider-tests/#run-acceptance-tests

This is an example for field update acceptance tests. https://github.com/GoogleCloudPlatform/magic-modules/blob/520e78b5db2970a5b0bbbbd86427043842ad442b/mmv1/third_party/terraform/tests/resource_tpu_node_test.go

[zli82016]

Added @slevenick as the secondary reviewer.

[slevenick]

LGTM. One question, if the max_node_count is not defined, does this work correctly?

The API may set a default (though I'm not sure in this case) which could cause a permadiff

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 134 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 2 files changed, 134 insertions(+), 4 deletions(-))
TF Validator: Diff ( 3 files changed, 44 insertions(+), 3 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 134 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 2 files changed, 134 insertions(+), 4 deletions(-))
TF Validator: Diff ( 3 files changed, 44 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2389
Passed tests 2135
Skipped tests: 248
Failed tests: 6

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccDatastreamStream_update|TestAccDatastreamStream_datastreamStreamFullExample|TestAccDatastreamStream_datastreamStreamBasicExample|TestAccContainerCluster_withInvalidGatewayApiConfigChannel|TestAccComputeForwardingRule_update

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccDatastreamStream_update[Debug log]
TestAccDatastreamStream_datastreamStreamFullExample[Debug log]
TestAccDatastreamStream_datastreamStreamBasicExample[Debug log]
TestAccContainerCluster_withInvalidGatewayApiConfigChannel[Debug log]
TestAccComputeForwardingRule_update[Debug log]

All tests passed
View the build log or the debug log for each test

[zli82016]

Overall, LGTM. Just have one comment. The example file mmv1/templates/terraform/examples/vertex_ai_featurestore_scaling.tf.erb needs to be added to examples in https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/products/vertexai/terraform.yaml#L81. It will generate an example acceptance test automatically.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 206 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 206 insertions(+), 4 deletions(-))
TF Validator: Diff ( 3 files changed, 44 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2391
Passed tests 2137
Skipped tests: 248
Failed tests: 6

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccDatastreamStream_update|TestAccDatastreamStream_datastreamStreamFullExample|TestAccDatastreamStream_datastreamStreamBasicExample|TestAccContainerCluster_withInvalidGatewayApiConfigChannel|TestAccLoggingBucketConfigProject_cmekSettings|TestAccVertexAIFeaturestore_vertexAiFeaturestoreScalingExample

[modular-magician]

Tests passed during RECORDING mode:
TestAccDatastreamStream_update[Debug log]
TestAccDatastreamStream_datastreamStreamFullExample[Debug log]
TestAccDatastreamStream_datastreamStreamBasicExample[Debug log]
TestAccContainerCluster_withInvalidGatewayApiConfigChannel[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccVertexAIFeaturestore_vertexAiFeaturestoreScalingExample[Debug log]

All tests passed
View the build log or the debug log for each test

[zli82016]

Thanks for making the changes. Sorry, I have one more comment.

[ghost]

Thanks for making the changes. Sorry, I have one more comment.

Don't apologise! Fixed with the values you suggested

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 206 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 206 insertions(+), 4 deletions(-))
TF Validator: Diff ( 3 files changed, 44 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2394
Passed tests 2140
Skipped tests: 251
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccContainerCluster_withInvalidGatewayApiConfigChannel|TestAccComposerEnvironment_UpdateComposerV2|TestAccComposerEnvironment_ComposerV2

[modular-magician]

Tests passed during RECORDING mode:
TestAccContainerCluster_withInvalidGatewayApiConfigChannel[Debug log]
TestAccComposerEnvironment_UpdateComposerV2[Debug log]
TestAccComposerEnvironment_ComposerV2[Debug log]

All tests passed
View the build log or the debug log for each test

[zli82016]

LGTM