Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add autoscaling option to Vertex Feature Store #7045

Merged
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion mmv1/products/vertexai/api.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -481,9 +481,29 @@ objects:
properties:
- !ruby/object:Api::Type::Integer
name: 'fixedNodeCount'
required: true
exactly_one_of:
- online_serving_config.0.fixed_node_count
- online_serving_config.0.scaling
description: |
The number of nodes for each cluster. The number of nodes will not scale automatically but can be scaled manually by providing different values when updating.
- !ruby/object:Api::Type::NestedObject
name: 'scaling'
exactly_one_of:
- fixed_node_count
- scaling
This conversation was marked as resolved.
Show resolved Hide resolved
description: |
Online serving scaling configuration. Only one of fixedNodeCount and scaling can be set. Setting one will reset the other.
properties:
- !ruby/object:Api::Type::Integer
name: 'minNodeCount'
required: true
description: |
The minimum number of nodes to scale down to. Must be greater than or equal to 1.
- !ruby/object:Api::Type::Integer
name: 'maxNodeCount'
required: true
description: |
The maximum number of nodes to scale up to. Must be greater than minNodeCount, and less than or equal to 10 times of 'minNodeCount'.
- !ruby/object:Api::Type::NestedObject
name: 'encryptionSpec'
description: |
Expand Down
15 changes: 15 additions & 0 deletions mmv1/products/vertexai/terraform.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,21 @@ overrides: !ruby/object:Overrides::ResourceOverrides
kms_key_name: 'BootstrapKMSKeyInLocation(t, "us-central1").CryptoKey.Name'
ignore_read_extra:
- "force_destroy"
- !ruby/object:Provider::Terraform::Examples
name: "vertex_ai_featurestore_scaling"
primary_resource_id: "featurestore"
primary_resource_name: "fmt.Sprintf(\"terraform%s\", context[\"random_suffix\"])"
vars:
name: "terraform"
project: "appeng-flex"
kms_key_name: "kms-name"
test_env_vars:
org_id: :ORG_ID
billing_account: :BILLING_ACCT
test_vars_overrides:
kms_key_name: 'BootstrapKMSKeyInLocation(t, "us-central1").CryptoKey.Name'
ignore_read_extra:
- "force_destroy"
properties:
region: !ruby/object:Overrides::Terraform::PropertyOverride
default_from_api: true
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
resource "google_vertex_ai_featurestore" "featurestore" {
This conversation was marked as resolved.
Show resolved Hide resolved
name = "<%= ctx[:vars]['name'] %>"
labels = {
foo = "bar"
}
region = "us-central1"
online_serving_config {
scaling {
min_node_count = 2
max_node_count = 10
}
}
encryption_spec {
kms_key_name = "<%= ctx[:vars]['kms_key_name'] %>"
}
force_destroy = true
}