-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Do not set header X-Goog-User-Project header for the resource google_client_openid_userinfo" #7112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hello, @slevenick , what resources stop working after this change? I need to do some investigation. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 1 insertion(+), 11 deletions(-)) |
Check the test run from the night after this was merged. There are ~40 new test failures, most of which have the same error message of: It's a range from google_storage_hmac_key to google_storage_bucket_iam_member and google_storage_default_object_access_control But mostly bucket IAM member it looks like. See tests TestAccStorageBucketIam* and TestAccStorageTransferJob_* for some examples |
Thanks for the information. |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withInvalidGatewayApiConfigChannel|TestAccRegionInstanceGroupManager_stateful |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
Reverts #6954
This causes ~40 tests to start failing including TestAccStorageBucketIam*
Reverting for safety, as it appears some resources stop working after this change.
I'm not sure why VCR didn't catch this, but it could be that the only change in the request is within the header information which we likely don't match on.