Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Do not set header X-Goog-User-Project header for the resource google_client_openid_userinfo" #7112

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

slevenick
Copy link
Contributor

Reverts #6954

This causes ~40 tests to start failing including TestAccStorageBucketIam*

Reverting for safety, as it appears some resources stop working after this change.

I'm not sure why VCR didn't catch this, but it could be that the only change in the request is within the header information which we likely don't match on.


… google_client_openid_userinfo (#6954)"

This reverts commit 3411c65.
@slevenick slevenick requested a review from zli82016 January 11, 2023 21:42
Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zli82016
Copy link
Member

Hello, @slevenick , what resources stop working after this change? I need to do some investigation.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 1 insertion(+), 11 deletions(-))
Terraform Beta: Diff ( 2 files changed, 1 insertion(+), 11 deletions(-))
TF Validator: Diff ( 4 files changed, 4 insertions(+), 14 deletions(-))

@slevenick
Copy link
Contributor Author

Hello, @slevenick , what resources stop working after this change? I need to do some investigation.

Check the test run from the night after this was merged. There are ~40 new test failures, most of which have the same error message of:
googleapi: Error 400: User project specified in the request is invalid., invalid

It's a range from google_storage_hmac_key to google_storage_bucket_iam_member and google_storage_default_object_access_control

But mostly bucket IAM member it looks like.

See tests TestAccStorageBucketIam* and TestAccStorageTransferJob_* for some examples

@zli82016
Copy link
Member

Hello, @slevenick , what resources stop working after this change? I need to do some investigation.

Check the test run from the night after this was merged. There are ~40 new test failures, most of which have the same error message of: googleapi: Error 400: User project specified in the request is invalid., invalid

It's a range from google_storage_hmac_key to google_storage_bucket_iam_member and google_storage_default_object_access_control

But mostly bucket IAM member it looks like.

See tests TestAccStorageBucketIam* and TestAccStorageTransferJob_* for some examples

Thanks for the information.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2404
Passed tests 2150
Skipped tests: 251
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withInvalidGatewayApiConfigChannel|TestAccRegionInstanceGroupManager_stateful

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccContainerCluster_withInvalidGatewayApiConfigChannel[Debug log]

Tests failed during RECORDING mode:
TestAccRegionInstanceGroupManager_stateful[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants