This repository has been archived by the owner on Nov 27, 2024. It is now read-only.
Revert "Do not set header X-Goog-User-Project header for the resource google_client_openid_userinfo" #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… google_client_openid_userinfo (#6954)" (#7112) This reverts commit 3411c65d4290095d257b82591c06ee0d63460fa7. Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
requested review from
melinath
and removed request for
a team
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts GoogleCloudPlatform/magic-modules#6954
This causes ~40 tests to start failing including TestAccStorageBucketIam*
Reverting for safety, as it appears some resources stop working after this change.
I'm not sure why VCR didn't catch this, but it could be that the only change in the request is within the header information which we likely don't match on.
Derived from GoogleCloudPlatform/magic-modules#7112