revert plugin framework code

[megan07]

reverts plugin-framework code

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
• Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

provider: fixed crash when trying to configure the provider with invalid credentials

[modular-magician]

Oops! It looks like you're using an unknown release-note type in your changelog entries:

• REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 25 files changed, 678 insertions(+), 4685 deletions(-))
Terraform Beta: Diff ( 25 files changed, 721 insertions(+), 4982 deletions(-))
TF Validator: Diff ( 5 files changed, 36 insertions(+), 565 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2470
Passed tests 2212
Skipped tests: 256
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccApigeeAddonsConfig_apigeeAddonsTestExample

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccApigeeAddonsConfig_apigeeAddonsTestExample[Debug log]

All tests passed
View the build log or the debug log for each test

[rosmo]

Apparently the new plugin framework code also broke data source google_dns_keys (returned an empty list of object), so I believe there is more than just the crash issue at hand here.

[melinath]

@rosmo Is that issue already fixed in 4.53.1? If not, could you open an issue for it?

[rosmo]

It's fixed in 4.53.1. But it was broken in 4.53.0.

[megan07]

Hi @rosmo, are you able to create a new issue with what you experienced in 4.53.0? I'm making updates to that area of the code and would like to make sure your case is covered. Specifically I'd be interested in what your config looks like and what you're expecting (it returned an empty set of objects, should it have errored? or were there keys that it should have returned, etc). Thanks!