Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct organization IAM docs #7551

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Correct organization IAM docs #7551

merged 1 commit into from
Mar 29, 2023

Conversation

rileykarson
Copy link
Member

@rileykarson rileykarson commented Mar 29, 2023

These docs specify that org_id is optional and can be inferred from the provider block. That's not the case- there's no way to specify one on the provider (but there is a way to specify one in tests!). The different modes between IAM resource types described how projects worked at the time. However, nowadays, the target project is required for all project IAM resources as well (as of 4.0.0).

Also provide numeric org id examples- that'll make it more clear that organizations/ is not required, unlike the completely invalid string that was there before.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

@rileykarson rileykarson requested a review from a team as a code owner March 29, 2023 00:44
@rileykarson rileykarson requested review from c2thorn and removed request for a team March 29, 2023 00:44
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 8 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 1 file changed, 8 insertions(+), 10 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@rileykarson rileykarson merged commit 44a589c into main Mar 29, 2023
@rileykarson rileykarson deleted the rileykarson-patch-1 branch March 29, 2023 15:53
dannawang0221 pushed a commit to dannawang0221/magic-modules that referenced this pull request Mar 29, 2023
diogoEsteves42 pushed a commit to diogoEsteves42/magic-modules that referenced this pull request Mar 31, 2023
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Apr 11, 2023
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants