Skip to content
This repository has been archived by the owner on May 15, 2023. It is now read-only.

Conversation

modular-magician
Copy link
Collaborator

These docs specify that org_id is optional and can be inferred from the provider block. That's not the case- there's no way to specify one on the provider (but there is a way to specify one in tests!). The different modes between IAM resource types described how projects worked at the time. However, nowadays, the target project is required for all project IAM resources as well (as of 4.0.0).

Also provide numeric org id examples- that'll make it more clear that organizations/ is not required, unlike the completely invalid string that was there before.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

Derived from GoogleCloudPlatform/magic-modules#7551

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician requested a review from a team as a code owner March 29, 2023 16:05
@modular-magician modular-magician requested review from shuyama1 and removed request for a team March 29, 2023 16:05
@modular-magician modular-magician merged commit e7bbeb9 into GoogleCloudPlatform:main Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant