Deleted immutable attributes for initialUser and weeklySchedule so th…

[GauravJain21]

…at deleting/adding these properties doesn't force new cluster creation

Creating a cluster with the minimum fields works fine the first time. On re-running the same .tf file, it deletes the existing cluster and creates a new one.

We get the default values for automated backup policy from the API. This includes many fields. One of them is the weekly schedule. This field is marked as forceNew. The first time when we create the cluster without providing any automated backup policy, we get the default from the API. This default value gets persisted in the .tfstate file. On subsequent runs of terraform, Terraform sees that the automated backup policy is present in the state file but not in the .tf file. Since this field is marked as forceNew, the old cluster is deleted and a new one is created. This is highly undesirable.

Similarly, initialUser is marked as immutable while it is a mutable field. Addition/Deletion to this field causes existing cluster deletion and creation of a new one which is highly undesirable.

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
• Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

     AlloyDB: Deleted immutable flag for initalUser and weeklySchedule 

[melinath]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 10 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 1 file changed, 10 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2576
Passed tests 2300
Skipped tests: 267
Affected tests: 9

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccFirebaserulesRelease_BasicRelease|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccFrameworkProviderBasePath_setBasePath|TestAccFrameworkProviderMeta_setModuleName|TestAccDataSourceGoogleFirebaseAppleAppConfig|TestAccDataSourceDNSKeys_basic|TestAccDataSourceDnsRecordSet_basic|TestAccDataSourceDnsManagedZone_basic|TestAccDataSourceDNSKeys_noDnsSec

Get to know how VCR tests work

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccFrameworkProviderBasePath_setBasePath[Debug log]
TestAccFrameworkProviderMeta_setModuleName[Debug log]
TestAccDataSourceGoogleFirebaseAppleAppConfig[Debug log]
TestAccDataSourceDNSKeys_basic[Debug log]
TestAccDataSourceDnsRecordSet_basic[Debug log]
TestAccDataSourceDnsManagedZone_basic[Debug log]
TestAccDataSourceDNSKeys_noDnsSec[Debug log]

All tests passed
View the build log or the debug log for each test

[melinath]

This looks fairly straightforward and it looks like the downstream code for in-place updates is getting generated. However, it would be good to add additional update tests to make sure that all the fields we think are updatable can actually be updated. There is already an update test for alloydb, which can be extended to exercise a larger number of fields, for example to ensure that this issue is actually resolved and prevent it from recurring. See

magic-modules/mmv1/third_party/terraform/tests/resource_redis_instance_test.go

Line 77 in bf3305d

/* Validate that read replica is enabled on the instance without recreate

for a more mature example of an update test.

[GauravJain21]

Hey Stephen,
As the bug is pretty bad (causes DB to be torn down for minor config changes), we're requesting exception to go ahead with the fix. Kindly request your help to make this exception.

Once the current code is stabilised and doesn't have any glaring bugs (max 1-2 weeks), we will switch focus to writing sufficient automated tests to ensure these issues are caught early in development.

[melinath]

responded elsewhere.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 160 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 160 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2588
Passed tests 2304
Skipped tests: 268
Affected tests: 16

Action taken

Found 16 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccFrameworkProviderMeta_setModuleName|TestAccFrameworkProviderBasePath_setBasePath|TestAccFirebaserulesRelease_BasicRelease|TestAccFirebaseWebApp_firebaseWebAppBasicExample|TestAccFirebaseWebApp_firebaseWebAppFull|TestAccDataSourceGoogleFirebaseAppleAppConfig|TestAccComputeForwardingRule_update|TestAccAlloydbCluster_deleteAutomatedBackupPolicyAndInitialUser|TestAccAlloydbCluster_addAutomatedBackupPolicyAndInitialUser|TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example|TestAccDataSourceDNSKeys_basic|TestAccDataSourceDnsRecordSet_basic|TestAccDataSourceDNSKeys_noDnsSec|TestAccDataSourceDnsManagedZone_basic|TestAccComposerEnvironment_withEncryptionConfigComposer2|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample

Get to know how VCR tests work

[modular-magician]

Tests passed during RECORDING mode:
TestAccFrameworkProviderMeta_setModuleName[Debug log]
TestAccFrameworkProviderBasePath_setBasePath[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccFirebaseWebApp_firebaseWebAppBasicExample[Debug log]
TestAccFirebaseWebApp_firebaseWebAppFull[Debug log]
TestAccDataSourceGoogleFirebaseAppleAppConfig[Debug log]
TestAccComputeForwardingRule_update[Debug log]
TestAccAlloydbCluster_deleteAutomatedBackupPolicyAndInitialUser[Debug log]
TestAccAlloydbCluster_addAutomatedBackupPolicyAndInitialUser[Debug log]
TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example[Debug log]
TestAccDataSourceDNSKeys_basic[Debug log]
TestAccDataSourceDnsRecordSet_basic[Debug log]
TestAccDataSourceDNSKeys_noDnsSec[Debug log]
TestAccDataSourceDnsManagedZone_basic[Debug log]
TestAccComposerEnvironment_withEncryptionConfigComposer2[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]

All tests passed
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 160 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 160 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2588
Passed tests 2307
Skipped tests: 268
Affected tests: 13

Action taken

Found 13 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccFirebaserulesRelease_BasicRelease|TestAccFirebaseWebApp_firebaseWebAppFull|TestAccFirebaseWebApp_firebaseWebAppBasicExample|TestAccComposerEnvironment_withEncryptionConfigComposer2|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example|TestAccDataSourceGoogleFirebaseAppleAppConfig|TestAccFrameworkProviderMeta_setModuleName|TestAccDataSourceDNSKeys_basic|TestAccFrameworkProviderBasePath_setBasePath|TestAccDataSourceDnsRecordSet_basic|TestAccDataSourceDnsManagedZone_basic|TestAccDataSourceDNSKeys_noDnsSec

Get to know how VCR tests work

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccFirebaseWebApp_firebaseWebAppFull[Debug log]
TestAccFirebaseWebApp_firebaseWebAppBasicExample[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example[Debug log]
TestAccDataSourceGoogleFirebaseAppleAppConfig[Debug log]
TestAccFrameworkProviderMeta_setModuleName[Debug log]
TestAccDataSourceDNSKeys_basic[Debug log]
TestAccFrameworkProviderBasePath_setBasePath[Debug log]
TestAccDataSourceDnsRecordSet_basic[Debug log]
TestAccDataSourceDnsManagedZone_basic[Debug log]
TestAccDataSourceDNSKeys_noDnsSec[Debug log]

Tests failed during RECORDING mode:
TestAccComposerEnvironment_withEncryptionConfigComposer2[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[melinath]

LGTM - thanks for adding tests!

[melinath]

Failing test seems unrelated.

[rileykarson]

@melinath: Please make sure you review the changelog note in the future! I've adjusted this to:

IMPROVEMENTS:
* alloydb: added update support for `initial_user` and `automated_backup_policy.weekly_schedule` to `google_alloydb_cluster`