Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted immutable attributes for initialUser and weeklySchedule so th… #14187

Conversation

modular-magician
Copy link
Collaborator

…at deleting/adding these properties doesn't force new cluster creation

Creating a cluster with the minimum fields works fine the first time. On re-running the same .tf file, it deletes the existing cluster and creates a new one.

We get the default values for automated backup policy from the API. This includes many fields. One of them is the weekly schedule. This field is marked as forceNew. The first time when we create the cluster without providing any automated backup policy, we get the default from the API. This default value gets persisted in the .tfstate file. On subsequent runs of terraform, Terraform sees that the automated backup policy is present in the state file but not in the .tf file. Since this field is marked as forceNew, the old cluster is deleted and a new one is created. This is highly undesirable.

Similarly, initialUser is marked as immutable while it is a mutable field. Addition/Deletion to this field causes existing cluster deletion and creation of a new one which is highly undesirable.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

     AlloyDB: Deleted immutable flag for initalUser and weeklySchedule 

Derived from GoogleCloudPlatform/magic-modules#7552

hashicorp#7552)

* Deleted immutable attributes for initialUser and weeklySchedule so that deleting/adding these properties doesn't force new cluster creation

* Automated tests for initialUser and automatedBackupPolicy

* Add ImportStateVerifyIgnore for non-changing fields

* gofmt fixes

---------

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit bc60933 into hashicorp:main Apr 3, 2023
@github-actions
Copy link

github-actions bot commented May 5, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant