Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert changes that added RIT resource + datasource #7608

Merged
merged 2 commits into from
Apr 3, 2023

Conversation

rileykarson
Copy link
Member

This resource was added at both beta and GA but appears to only work at beta. While I'd fix-forward normally this is a handwritten resource and we're cutting the next release EOD tomorrow. This ensures that we don't end up mixing up branches and releasing the resource without a working GA API- a roll-forward will need to explicitly target beta only, or confirm that the GA API works as expected.

Upstream version of the changes to release branches in hashicorp/terraform-provider-google#14183 and hashicorp/terraform-provider-google-beta#5416

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

@rileykarson rileykarson requested a review from a team as a code owner April 3, 2023 19:26
@rileykarson rileykarson requested review from shuyama1 and removed request for a team April 3, 2023 19:26
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Resource google_compute_region_instance_template was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 9 files changed, 11 insertions(+), 5639 deletions(-))
Terraform Beta: Diff ( 9 files changed, 11 insertions(+), 5894 deletions(-))

@rileykarson rileykarson added the override-breaking-change Allows a potential breaking change to be merged label Apr 3, 2023
@rileykarson
Copy link
Member Author

Override: This resource was not released.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2544
Passed tests 2266
Skipped tests: 266
Affected tests: 12

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFirebaseWebApp_firebaseWebAppFull|TestAccFirebaseWebApp_firebaseWebAppBasicExample|TestAccComposerEnvironment_withEncryptionConfigComposer2|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example|TestAccDataSourceDnsRecordSet_basic|TestAccDataSourceGoogleFirebaseAppleAppConfig|TestAccDataSourceDNSKeys_noDnsSec|TestAccDataSourceDnsManagedZone_basic|TestAccFrameworkProviderMeta_setModuleName|TestAccDataSourceDNSKeys_basic|TestAccFrameworkProviderBasePath_setBasePath

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaseWebApp_firebaseWebAppFull[Debug log]
TestAccFirebaseWebApp_firebaseWebAppBasicExample[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example[Debug log]
TestAccDataSourceDnsRecordSet_basic[Debug log]
TestAccDataSourceGoogleFirebaseAppleAppConfig[Debug log]
TestAccDataSourceDNSKeys_noDnsSec[Debug log]
TestAccDataSourceDnsManagedZone_basic[Debug log]
TestAccFrameworkProviderMeta_setModuleName[Debug log]
TestAccDataSourceDNSKeys_basic[Debug log]
TestAccFrameworkProviderBasePath_setBasePath[Debug log]

Tests failed during RECORDING mode:
TestAccComposerEnvironment_withEncryptionConfigComposer2[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@rileykarson rileykarson deleted the revert-rit branch April 3, 2023 21:51
@rileykarson
Copy link
Member Author

rileykarson commented Apr 3, 2023

FYI @jingcongw: #7507 and #7535 have both been reverted and will need to be made again. I expect that you can largely roll-forward the changes after wrapping the appropriate beta guards around the resource/datasource/fields/tests

kimihrr pushed a commit to kimihrr/kimiah-magic-modules that referenced this pull request Apr 4, 2023
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Apr 11, 2023
maphad pushed a commit to maphad/magic-modules that referenced this pull request Apr 12, 2023
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
override-breaking-change Allows a potential breaking change to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants