-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert changes that added RIT resource + datasource #7608
Conversation
…form#7535)" This reverts commit baaeaee.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 9 files changed, 11 insertions(+), 5639 deletions(-)) |
Override: This resource was not released. |
Tests analyticsTotal tests: Action takenFound 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccFirebaseWebApp_firebaseWebAppFull|TestAccFirebaseWebApp_firebaseWebAppBasicExample|TestAccComposerEnvironment_withEncryptionConfigComposer2|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example|TestAccDataSourceDnsRecordSet_basic|TestAccDataSourceGoogleFirebaseAppleAppConfig|TestAccDataSourceDNSKeys_noDnsSec|TestAccDataSourceDnsManagedZone_basic|TestAccFrameworkProviderMeta_setModuleName|TestAccDataSourceDNSKeys_basic|TestAccFrameworkProviderBasePath_setBasePath |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
FYI @jingcongw: #7507 and #7535 have both been reverted and will need to be made again. I expect that you can largely roll-forward the changes after wrapping the appropriate beta guards around the resource/datasource/fields/tests |
This resource was added at both beta and GA but appears to only work at beta. While I'd fix-forward normally this is a handwritten resource and we're cutting the next release EOD tomorrow. This ensures that we don't end up mixing up branches and releasing the resource without a working GA API- a roll-forward will need to explicitly target beta only, or confirm that the GA API works as expected.
Upstream version of the changes to release branches in hashicorp/terraform-provider-google#14183 and hashicorp/terraform-provider-google-beta#5416
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)