Skip to content
This repository has been archived by the owner on Nov 27, 2024. It is now read-only.

Conversation

modular-magician
Copy link
Contributor

This resource was added at both beta and GA but appears to only work at beta. While I'd fix-forward normally this is a handwritten resource and we're cutting the next release EOD tomorrow. This ensures that we don't end up mixing up branches and releasing the resource without a working GA API- a roll-forward will need to explicitly target beta only, or confirm that the GA API works as expected.

Upstream version of the changes to release branches in hashicorp/terraform-provider-google#14183 and hashicorp/terraform-provider-google-beta#5416

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

Derived from GoogleCloudPlatform/magic-modules#7608

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician requested a review from a team as a code owner April 3, 2023 21:17
@modular-magician modular-magician requested review from roaks3 and removed request for a team April 3, 2023 21:17
@modular-magician modular-magician merged commit e08a093 into GoogleCloudPlatform:main Apr 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant