Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage_billing_model for BigQuery datasets #7615

Merged

Conversation

LucaPrete
Copy link
Member

@LucaPrete LucaPrete commented Apr 4, 2023

Fixes hashicorp/terraform-provider-google#12758

Adds storage_billing_model for BigQuery datasets.
Warning: This is WIP. The API is still in preview, so this can't be merged, yet.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.
bigquery: add `storage_billing_model` argument to `google_bigquery_dataset`

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 81 insertions(+))
Terraform Beta: Diff ( 3 files changed, 81 insertions(+))
TF Validator: Diff ( 3 files changed, 13 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2549
Passed tests 2270
Skipped tests: 275
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFirebaserulesRelease_BasicRelease|TestAccBigQueryDataset_storageBillModel|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example[Debug log]

Tests failed during RECORDING mode:
TestAccBigQueryDataset_storageBillModel[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@LucaPrete
Copy link
Member Author

[WIP] leaving it here but can't test it because the feature is still not publicly available

@LucaPrete
Copy link
Member Author

@wj-chen can you please confirm you can see the PR now?

@LucaPrete LucaPrete force-pushed the add_bq_billing_storage_model branch from 9677354 to 9734761 Compare June 22, 2023 16:14
@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jun 22, 2023
@Vadoid
Copy link

Vadoid commented Jul 5, 2023

@trodge Hi Thomas, considering compressed storage starts to be GA from today, please review this PR.

@LucaPrete LucaPrete force-pushed the add_bq_billing_storage_model branch from 9734761 to 7a6c089 Compare July 5, 2023 19:22
@LucaPrete LucaPrete marked this pull request as ready for review July 5, 2023 19:23
@LucaPrete
Copy link
Member Author

I confirm indeed tests now pass on my end. Rebased and resubmitted the PR to go through the tests here as well. Fingers crossed. @trodge please let me know if it looks ok to you.

@LucaPrete LucaPrete changed the title [Waiting for the feature to go GA] Add storage_billing_model for BigQuery datasets Add storage_billing_model for BigQuery datasets Jul 5, 2023
@LucaPrete
Copy link
Member Author

I think something remained appended here...checks are running since 13 hours :) Does anybody know how to unlock them?

@trodge
Copy link
Contributor

trodge commented Jul 10, 2023

/gcbrun

@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jul 10, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 81 insertions(+))
Terraform Beta: Diff ( 3 files changed, 81 insertions(+))
TF Conversion: Diff ( 3 files changed, 13 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2848
Passed tests 2548
Skipped tests: 295
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeTargetHttpProxy_targetHttpProxyHttpKeepAliveTimeoutExample|TestAccComputeTargetHttpsProxy_targetHttpsProxyHttpKeepAliveTimeoutExample|TestAccComputeFirewallPolicyRule_multipleRules|TestAccBigQueryDataset_storageBillModel

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeTargetHttpProxy_targetHttpProxyHttpKeepAliveTimeoutExample[Debug log]
TestAccComputeTargetHttpsProxy_targetHttpsProxyHttpKeepAliveTimeoutExample[Debug log]
TestAccBigQueryDataset_storageBillModel[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@trodge trodge merged commit f745759 into GoogleCloudPlatform:main Jul 10, 2023
8 checks passed
baskaran-md pushed a commit to baskaran-md/magic-modules that referenced this pull request Jul 10, 2023
…7615)

* [Waiting for the feature to go GA] Add storage_billing_model for BigQuery datasets

* updating precheck test function name

---------

Co-authored-by: Luca Prete <lucaprete@google.com>
Khaledmohamedrefaat pushed a commit to Khaledmohamedrefaat/magic-modules that referenced this pull request Jul 13, 2023
…7615)

* [Waiting for the feature to go GA] Add storage_billing_model for BigQuery datasets

* updating precheck test function name

---------

Co-authored-by: Luca Prete <lucaprete@google.com>
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
…7615)

* [Waiting for the feature to go GA] Add storage_billing_model for BigQuery datasets

* updating precheck test function name

---------

Co-authored-by: Luca Prete <lucaprete@google.com>
wj-chen pushed a commit to wj-chen/magic-modules that referenced this pull request Aug 1, 2023
…7615)

* [Waiting for the feature to go GA] Add storage_billing_model for BigQuery datasets

* updating precheck test function name

---------

Co-authored-by: Luca Prete <lucaprete@google.com>
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Aug 9, 2023
…7615)

* [Waiting for the feature to go GA] Add storage_billing_model for BigQuery datasets

* updating precheck test function name

---------

Co-authored-by: Luca Prete <lucaprete@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_bigquery_dataset: add support for storage_billing_model
4 participants