-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add storage_billing_model for BigQuery datasets #7615
Add storage_billing_model for BigQuery datasets #7615
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 81 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccFirebaserulesRelease_BasicRelease|TestAccBigQueryDataset_storageBillModel|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
[WIP] leaving it here but can't test it because the feature is still not publicly available |
@wj-chen can you please confirm you can see the PR now? |
9677354
to
9734761
Compare
@trodge Hi Thomas, considering compressed storage starts to be GA from today, please review this PR. |
9734761
to
7a6c089
Compare
I confirm indeed tests now pass on my end. Rebased and resubmitted the PR to go through the tests here as well. Fingers crossed. @trodge please let me know if it looks ok to you. |
I think something remained appended here...checks are running since 13 hours :) Does anybody know how to unlock them? |
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 81 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeTargetHttpProxy_targetHttpProxyHttpKeepAliveTimeoutExample|TestAccComputeTargetHttpsProxy_targetHttpsProxyHttpKeepAliveTimeoutExample|TestAccComputeFirewallPolicyRule_multipleRules|TestAccBigQueryDataset_storageBillModel |
Rerun these tests in REPLAYING mode to catch issues
|
…7615) * [Waiting for the feature to go GA] Add storage_billing_model for BigQuery datasets * updating precheck test function name --------- Co-authored-by: Luca Prete <lucaprete@google.com>
…7615) * [Waiting for the feature to go GA] Add storage_billing_model for BigQuery datasets * updating precheck test function name --------- Co-authored-by: Luca Prete <lucaprete@google.com>
…7615) * [Waiting for the feature to go GA] Add storage_billing_model for BigQuery datasets * updating precheck test function name --------- Co-authored-by: Luca Prete <lucaprete@google.com>
…7615) * [Waiting for the feature to go GA] Add storage_billing_model for BigQuery datasets * updating precheck test function name --------- Co-authored-by: Luca Prete <lucaprete@google.com>
…7615) * [Waiting for the feature to go GA] Add storage_billing_model for BigQuery datasets * updating precheck test function name --------- Co-authored-by: Luca Prete <lucaprete@google.com>
Fixes hashicorp/terraform-provider-google#12758
Adds storage_billing_model for BigQuery datasets.
Warning: This is WIP. The API is still in preview, so this can't be merged, yet.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.