Add storage_billing_model for BigQuery datasets (GoogleCloudPlatform#…

…7615)

* [Waiting for the feature to go GA] Add storage_billing_model for BigQuery datasets

* updating precheck test function name

---------

Co-authored-by: Luca Prete <lucaprete@google.com>

mmv1/products/bigquery/Dataset.yaml

@@ -356,3 +356,12 @@ properties:
       - 'und:ci': undetermined locale, case insensitive.
       - '': empty string. Default to case-sensitive behavior.
     default_from_api: true
+  - !ruby/object:Api::Type::String
+    name: 'storageBillingModel'
+    description: |
+      Specifies the storage billing model for the dataset.
+      Set this flag value to LOGICAL to use logical bytes for storage billing,
+      or to PHYSICAL to use physical bytes instead.
+
+      LOGICAL is the default if this flag isn't specified.
+    default_from_api: true

mmv1/third_party/terraform/tests/resource_big_query_dataset_test.go

@@ -167,6 +167,28 @@ func TestAccBigQueryDataset_cmek(t *testing.T) {
 	})
 }
 
+func TestAccBigQueryDataset_storageBillModel(t *testing.T) {
+	t.Parallel()
+
+	datasetID := fmt.Sprintf("tf_test_%s", RandString(t, 10))
+
+	VcrTest(t, resource.TestCase{
+		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
+		ProtoV5ProviderFactories: ProtoV5ProviderFactories(t),
+		CheckDestroy:             testAccCheckBigQueryDatasetDestroyProducer(t),
+		Steps: []resource.TestStep{
+			{
+				Config: testAccBigQueryDatasetStorageBillingModel(datasetID),
+			},
+			{
+				ResourceName:      "google_bigquery_dataset.test",
+				ImportState:       true,
+				ImportStateVerify: true,
+			},
+		},
+	})
+}
+
 func testAccAddTable(t *testing.T, datasetID string, tableID string) resource.TestCheckFunc {
 	// Not actually a check, but adds a table independently of terraform
 	return func(s *terraform.State) error {
@@ -389,3 +411,22 @@ resource "google_bigquery_dataset" "test" {
 }
 `, pid, datasetID, kmsKey)
 }
+
+func testAccBigQueryDatasetStorageBillingModel(datasetID string) string {
+	return fmt.Sprintf(`
+resource "google_bigquery_dataset" "test" {
+  dataset_id                      = "%s"
+  friendly_name                   = "foo"
+  description                     = "This is a foo description"
+  location                        = "EU"
+  default_partition_expiration_ms = 3600000
+  default_table_expiration_ms     = 3600000
+  storage_billing_model           = "PHYSICAL"
+
+  labels = {
+    env                         = "foo"
+    default_table_expiration_ms = 3600000
+  }
+}
+`, datasetID)
+}