Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Go 1.19 #7645

Merged
merged 2 commits into from
Apr 7, 2023
Merged

Upgrade Go 1.19 #7645

merged 2 commits into from
Apr 7, 2023

Conversation

zli82016
Copy link
Member

@zli82016 zli82016 commented Apr 5, 2023

Upgrade Go 1.19

Fixes hashicorp/terraform-provider-google#14102

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@zli82016 zli82016 requested a review from a team as a code owner April 5, 2023 20:05
@zli82016 zli82016 requested review from slevenick and removed request for a team April 5, 2023 20:05
@zli82016
Copy link
Member Author

zli82016 commented Apr 5, 2023

/gcbrun

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're waiting on any CI changes until ~tomorrow, so I can review then

@zli82016
Copy link
Member Author

zli82016 commented Apr 5, 2023

I think we're waiting on any CI changes until ~tomorrow, so I can review then

Yeah, sounds good.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 4 insertions(+), 47 deletions(-))
Terraform Beta: Diff ( 2 files changed, 4 insertions(+), 47 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2559
Passed tests 2280
Skipped tests: 275
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFirebaserulesRelease_BasicRelease|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example[Debug log]

All tests passed
View the build log or the debug log for each test

@zli82016 zli82016 merged commit 1f83359 into main Apr 7, 2023
jingcongw pushed a commit to jingcongw/magic-modules-test that referenced this pull request Apr 7, 2023
* Upgrade Go 1.19

* Do not upgrade tools
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Apr 11, 2023
* Upgrade Go 1.19

* Do not upgrade tools
maphad pushed a commit to maphad/magic-modules that referenced this pull request Apr 12, 2023
* Upgrade Go 1.19

* Do not upgrade tools
@rakeshmulugu
Copy link

rakeshmulugu commented Apr 20, 2023

  • I recently opened an issue with the terraform-google-provider repository to upgrade the Go language version bundled with Terraform providers, as the older version was causing vulnerabilities. The issue has since been closed after the reported changes were made.

  • However, after rebuilding the images with the latest versions of Terraform (1.4.5) and Google providers (4.62.1) I have noticed that the vulnerabilities related to Go 1.18 still persist. It appears that the providers are still using the older Go version.

  • Upon further investigation, I found that the go-version file in the repository still contains the Go version 1.18.1. This discrepancy might be the cause of the issue. I request the reopening of the issue to address this concern.

  • If you require any further details or clarification, please let me know, and I'll be happy to provide the necessary information. It is crucial that we resolve this issue to ensure the security and stability of our infrastructure.

MicrosoftTeams-image (3)

MicrosoftTeams-image (4)

ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
* Upgrade Go 1.19

* Do not upgrade tools
@SarahFrench SarahFrench mentioned this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Go lang version in providers to reduce vulnerabilities.
4 participants