-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Go 1.20 #9506
Upgrade to Go 1.20 #9506
Conversation
Check is failing:
|
Can we separate the PR to be one that updates the container and a second that updates the assets that use the container? We can check in the former then the latter |
a8031fe
to
7a0a3df
Compare
I've removed changes to Dockerfiles from this PR and they're now in this separate PR: #9530 |
I can see that the new container image made by merging this PR is now in container registry, so I can test this PR with /gcbrun |
/gcbrun |
This comment was marked as duplicate.
This comment was marked as duplicate.
1 similar comment
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-)) |
This comment was marked as duplicate.
This comment was marked as duplicate.
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccGKEHub2Fleet_gkehubFleetBasicExample_update|TestAccSpannerInstanceIamPolicy |
This comment was marked as duplicate.
This comment was marked as duplicate.
Rerun these tests in REPLAYING mode to catch issues
Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.
|
The test failure above is unrelated and is addressed by #9552 |
* Upgrade TPG/TPGB go.mod to Go 1.20 * Upgrade doctor script to check users have Go 1.20 for building the provider * Update workflows that interact with the provider codebase directly * Update tpgtools to Go 1.20 * Upgrade everything else from Go 1.19 to Go 1.20
This PR upgrades the Google providers (related systems) from Go 1.19 to Go 1.20.
Using Go 1.20 is needed to enable this work : hashicorp/terraform-provider-google#16244
Here's are PRs for the previous upgrade process:
Release Note Template for Downstream PRs (will be copied)