Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Go 1.20 #9506

Merged
merged 5 commits into from
Nov 30, 2023
Merged

Upgrade to Go 1.20 #9506

merged 5 commits into from
Nov 30, 2023

Conversation

SarahFrench
Copy link
Contributor

@SarahFrench SarahFrench commented Nov 21, 2023

This PR upgrades the Google providers (related systems) from Go 1.19 to Go 1.20.

Using Go 1.20 is needed to enable this work : hashicorp/terraform-provider-google#16244

Here's are PRs for the previous upgrade process:

Release Note Template for Downstream PRs (will be copied)


@SarahFrench
Copy link
Contributor Author

Check is failing:

Check for go in path...
go1.19.13 is installed, but go 1.20 or later is required. See https://golang.org/doc/install for information on installing it.

@ScottSuarez
Copy link
Contributor

Can we separate the PR to be one that updates the container and a second that updates the assets that use the container?

We can check in the former then the latter

@SarahFrench
Copy link
Contributor Author

I've removed changes to Dockerfiles from this PR and they're now in this separate PR: #9530

@SarahFrench
Copy link
Contributor Author

I can see that the new container image made by merging this PR is now in container registry, so I can test this PR with /gcbrun

@SarahFrench
Copy link
Contributor Author

/gcbrun

@modular-magician

This comment was marked as duplicate.

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician

This comment was marked as duplicate.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3254
Passed tests 2921
Skipped tests: 331
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccGKEHub2Fleet_gkehubFleetBasicExample_update|TestAccSpannerInstanceIamPolicy

Get to know how VCR tests work

@modular-magician

This comment was marked as duplicate.

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccGKEHub2Fleet_gkehubFleetBasicExample_update[Debug log]
TestAccSpannerInstanceIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$
TestAccGKEHub2Fleet_gkehubFleetBasicExample_update[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
View the build log or the debug log for each test

@SarahFrench
Copy link
Contributor Author

The test failure above is unrelated and is addressed by #9552

@SarahFrench SarahFrench merged commit 61f0388 into main Nov 30, 2023
9 checks passed
trodge pushed a commit to trodge/magic-modules that referenced this pull request Dec 8, 2023
* Upgrade TPG/TPGB go.mod to Go 1.20

* Upgrade doctor script to check users have Go 1.20 for building the provider

* Update workflows that interact with the provider codebase directly

* Update tpgtools to Go 1.20

* Upgrade everything else from Go 1.19 to Go 1.20
@SarahFrench SarahFrench deleted the upgrade-go-1.20 branch February 6, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants