Added a new datasource for fetching the available alloydb locations #7678
Conversation
Sync Forked Repo
… user from setting "password" or "host" for CLOUD_IAM_USER and CLOUD_IAM_SERVICE_ACCOUNT user types.
… or password field for CLOUD_IAM_USER and CLOUD_IAM_SERVICE_ACCOUNT
|
Tests passed during RECORDING mode: All tests passed |
|
Adding @NickElliot as initial reviewer (@zli82016 will do final review and merge afterwards) |
mmv1/third_party/terraform/website/docs/d/alloydb_locations.html.markdown
Outdated
Show resolved
Hide resolved
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 254 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccDataSourceAlloydbLocations_basic|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccAlloydbCluster_missingLocation|TestAccAlloydbBackup_missingLocation |
|
Tests passed during RECORDING mode: All tests passed |
|
LGTM! @zli82016 for final review |
| } | ||
|
|
||
| url, err := ReplaceVars(d, config, "{{AlloydbBasePath}}projects/{{project}}/locations") | ||
| log.Printf("[ERROR] kanthara url : %s", url) |
There was a problem hiding this comment.
Is this log required? Or is it just for your local development? You can remove it if it is not needed.
There was a problem hiding this comment.
@ravisiddhu , can you please remove this line? After that, I will merge the PR.
There was a problem hiding this comment.
@zli82016, It is not needed, I have removed it.
|
Overall LTGM. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 252 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccAlloydbBackup_missingLocation|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccAlloydbCluster_missingLocation|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccDataSourceAlloydbLocations_basic|TestAccTPUNode_tpuNodeFullExample |
|
Tests passed during RECORDING mode: All tests passed |
…oogleCloudPlatform#7678) * Added validation for "type" in cloud_sql_user_resource for preventing user from setting "password" or "host" for CLOUD_IAM_USER and CLOUD_IAM_SERVICE_ACCOUNT user types. * Removed validation and added documentation to prevent setting of host or password field for CLOUD_IAM_USER and CLOUD_IAM_SERVICE_ACCOUNT * Added a new data source for fetching the details of available alloydb locations * using go client libraries to call the apis * using go client library to call the apis * using go client library to call the apis * Using v1 and v1beta go client for ga and beta versions respectively * Using v1 and v1beta go client for ga and beta versions respectively * Revert "Added a new data source for fetching the details of available alloydb locations" This reverts commit a6791a3. * calling http calls using magic modules send request insted of alloydb go client * calling http calls using magic modules send request insted of alloydb go client
…oogleCloudPlatform#7678) * Added validation for "type" in cloud_sql_user_resource for preventing user from setting "password" or "host" for CLOUD_IAM_USER and CLOUD_IAM_SERVICE_ACCOUNT user types. * Removed validation and added documentation to prevent setting of host or password field for CLOUD_IAM_USER and CLOUD_IAM_SERVICE_ACCOUNT * Added a new data source for fetching the details of available alloydb locations * using go client libraries to call the apis * using go client library to call the apis * using go client library to call the apis * Using v1 and v1beta go client for ga and beta versions respectively * Using v1 and v1beta go client for ga and beta versions respectively * Revert "Added a new data source for fetching the details of available alloydb locations" This reverts commit a6791a3. * calling http calls using magic modules send request insted of alloydb go client * calling http calls using magic modules send request insted of alloydb go client
…oogleCloudPlatform#7678) * Added validation for "type" in cloud_sql_user_resource for preventing user from setting "password" or "host" for CLOUD_IAM_USER and CLOUD_IAM_SERVICE_ACCOUNT user types. * Removed validation and added documentation to prevent setting of host or password field for CLOUD_IAM_USER and CLOUD_IAM_SERVICE_ACCOUNT * Added a new data source for fetching the details of available alloydb locations * using go client libraries to call the apis * using go client library to call the apis * using go client library to call the apis * Using v1 and v1beta go client for ga and beta versions respectively * Using v1 and v1beta go client for ga and beta versions respectively * Revert "Added a new data source for fetching the details of available alloydb locations" This reverts commit a6791a3. * calling http calls using magic modules send request insted of alloydb go client * calling http calls using magic modules send request insted of alloydb go client
…oogleCloudPlatform#7678) * Added validation for "type" in cloud_sql_user_resource for preventing user from setting "password" or "host" for CLOUD_IAM_USER and CLOUD_IAM_SERVICE_ACCOUNT user types. * Removed validation and added documentation to prevent setting of host or password field for CLOUD_IAM_USER and CLOUD_IAM_SERVICE_ACCOUNT * Added a new data source for fetching the details of available alloydb locations * using go client libraries to call the apis * using go client library to call the apis * using go client library to call the apis * Using v1 and v1beta go client for ga and beta versions respectively * Using v1 and v1beta go client for ga and beta versions respectively * Revert "Added a new data source for fetching the details of available alloydb locations" This reverts commit a6791a3. * calling http calls using magic modules send request insted of alloydb go client * calling http calls using magic modules send request insted of alloydb go client
…oogleCloudPlatform#7678) * Added validation for "type" in cloud_sql_user_resource for preventing user from setting "password" or "host" for CLOUD_IAM_USER and CLOUD_IAM_SERVICE_ACCOUNT user types. * Removed validation and added documentation to prevent setting of host or password field for CLOUD_IAM_USER and CLOUD_IAM_SERVICE_ACCOUNT * Added a new data source for fetching the details of available alloydb locations * using go client libraries to call the apis * using go client library to call the apis * using go client library to call the apis * Using v1 and v1beta go client for ga and beta versions respectively * Using v1 and v1beta go client for ga and beta versions respectively * Revert "Added a new data source for fetching the details of available alloydb locations" This reverts commit a6791a3. * calling http calls using magic modules send request insted of alloydb go client * calling http calls using magic modules send request insted of alloydb go client
This PR is for hashicorp/terraform-provider-google#13812
A new datasource
google_alloydb_locationsfor fetching the details of available alloydb locations. It receivesprojectas arguments and returns the details of all the available alloydb locations.I have added documentation and tested this new data source with unit tests.
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.