Sync Forked Repo #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Upgrade DCL to v1.21.1 * Fix up formatting of mmv1/third_party/terraform/go.sum
* send two false fields * updates Co-authored-by: Edward Sun <sunedward@google.com>
…#6586) * Update import format for google_iap_brand resource * Update documentation for google_iap_brand name attribute * Clarify description of name attr; make more clear which format the API returns. * Implement import of `google_iap_brand` using name in 2-part format * Update import to set 4-part id, to match unimported resources
* Artifact Registry Data Source Added * Artifact Registry Resource Location Changes Updated
…e added instead (#6600)
Signed-off-by: toVersus <toversus2357@gmail.com> Signed-off-by: toVersus <toversus2357@gmail.com>
* Add tests for existing `dataSourceGoogleIamPolicyRead` function behaviour
* Add red (non-passing) tests for new `dataSourceGoogleIamPolicyRead` behaviour
* Update tests to check both numbers of bindings from config vs in policy_data output
This is necessary because policy_data will need to consolidate bindings, and state for binding{} blocks needs to keep data separate
* Update function to pass uncommented tests
* Refactor test setup
* Change structure of test input data to minimise processing in the test function + add and update test cases
Need to check if test assumptions like `bindings on the same role with different conditions, with the same title, are next sorted by condition expression` is correct or not
* WIP: Update sorting of bindings to include: role, condition presence, condition fields.
* Formatting changes to make .erb match output .go file
* Update tests to match the sorting behaviour of the API, update sorting function to pass tests
* Refactor existing tests for clarity
* Add tests for deduplication and complex sorting scenario
* Fix sorting bug where 'lesser' roles is incorrectly sorted to a later index in a list if it has a condition
* Refactor `dataSourceGoogleIamPolicyRead` to reduce looping and pull sorting function out into a named function
* Make binding map use human-readable keys
…avoid permadiffs in plans (#6473) * Stop provider sending empty description field, to avoid permadiffs in plans * Add test asserting that `description` fields are omitted from `policy_data` if it's not set in the config * Update existing IAM tests to include conditions with empty descriptions * Fix "Too many condition blocks" error in `google_project_iam_binding` test * Make titles unique between multiple `google_project_iam_binding` resources * Update new test to assert both policy_data match after resource creation finishes Previously this wasn't the case; the resource was Read from the API after create and saved to state, resulting in changes in the policy from the API being saved to state and causing diffs * Change tests to hardcode the title of the second condition This makes this branchs changes consistent and minimises the change on function signatures. Also, the new bindings are not imported so the data is not needed in the body of the test. * Allow IAM condition test generation in GA provider * Allow IAM condition docs generation in GA provider * Update context for IAM condition acctests to include descriptions and fields for bindings without descriptions * Update import step of acctests to navigate possible SDK bug * Fix variable name and expected policy order in admin IAM condition tests * Add missing member type to IAM condition test, update code comments * Change test back to using ImportStateVerify instead of ImportStateCheck for IAM condition acctests * Add checks to test steps, remove changes to handwritten tests & new test * Update comment about bindings with no descriptions * Add more explicit check that empty descriptions aren't stored in google_iam_policy data sources * Fix comment syntax * Add resources and import steps for `*_member` and `*_binding` IAM conditions without descriptions
Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
* change enable on adaptive_protection_config * Update resource_compute_security_policy_test.go.erb lined a bracket Co-authored-by: Edward Sun <sunedward@google.com>
Co-authored-by: Edward Sun <sunedward@google.com>
Co-authored-by: megan07 <mbang@hashicorp.com> Co-authored-by: Pawel Krawczyk <pawkra@google.com> Co-authored-by: pawel-grz-krawczyk <65188162+pawel-grz-krawczyk@users.noreply.github.com>
* Correcting miss-spelled word in the documentation Correcting miss-spelled word * Adding support for password validation user policy for Mysql. * Correction to the testing logic and spacing correction. * Adding flatten for new user level password policy. * Adding destroy check to sql_user test. * Fixing the test failure. * Fixing some definitions that I got wrong. * Update sql_database_instance_my_sql.tf.erb * Fixing some more issues that caused tests to fail * correcting typo * Update resource_sql_user_test.go * adding check for null * Update resource_sql_user_test.go
…gle_compute_backend_service (#6584)
* Mark GC policy legacy fields deprecated * Mark fields as deprecated in comments * Revert back to really deprecating the fields. * Update doc to recommend gc_rules.
…pe (beta) (#6789) * feat: add the iam resources for featurestore entitytype * fix: fix the unit test errors
* test * Empty entity bug fixed * First attempt * First attempt * completed adding workforce pool provider * fix bugs
…ine (#6728) * feat: add google_vertex_ai_index for Vertex AI Matching Engine * fix: increase timeouts to 60 min because 20 wasn't enough for creation * fix: change coe to make name computed instead of an input * fix: use costom flatten code to ignore_read a nested property's field * fix: add skip_import_test: true to the auto-gen test * feat: add a test with a manually updated ImportStateVerifyIgnore * Apply suggestions from code review [ci skip] Update descriptions based on the suggestions Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * refactor: use ignore_read_extra instead of a manual test * fix: use an empty object for bruteForceConfig * feat: define additional fields to api.yaml * feat: add an example to increase test coverage * feat: deal with contentsDeltaUri as an updatable field * fix: fix the error because the cosine distance type only supports unit l2 norm type This is the error message from the endpoint: "Index with `COSINE_DISTANCE` distanceMeasureType currently only supports `UNIT_L2_NORM` featureNormType." * feat: remove approximate_neighbors_count from an example with brute_force_config approximate_neighbors_count is required if tree-AH algorithm is used. from https://cloud.google.com/vertex-ai/docs/matching-engine/configuring-indexes#brute-force-config * test: add a handwritten test for patch * fix: add update_mask: true to use the mask as a url param * refactor: put 'input: true' on the fields patch couldn't update * feat: use custom pre update code for a nested object * fix: update the handwritten test accordingly * feat: add custom flatten code for is_complete_overwrite Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
* display_name not in response * use ignore_read instead Co-authored-by: Edward Sun <sunedward@google.com>
…permadiff on google_dataflow_job.labels (#6602) * changed_dataflow_job_read_function * Modify_Read_function_to_fix_the_Test_Failures * removing the skiIfVcr * ignoring the API values in additional_experiments attr * reverting ruby version * ignoring the read for additional_experiments * addressing the review comment and skipping the test TestAccDataflowJobWithAdditionalExperiments in VCR * commiting to run pipeline
…le_bigquery_data_transfer_config (#6784) * Added customize diff for params field in google_bigquery_data_transfer_config * Added test cases for params field for google_bigquery_data_transfer_config * Added unit tests to cover ForceNew behaviour of params field * Added handling for customizeDiff in google_bigquery_data_transfer_config * Added comments for parmasCustomizeDiff function in google_bigquery_data_transfer_config * Added test case for different data_source_id in resource_bigquery_data_transfer_config * Updated test case for different data_source_id in resource_bigquery_data_transfer_config * Updated error message for resource_bigquery_data_transfer_config_test.go * Updated test case for resource_bigquery_data_transfer_config_test.go
Co-authored-by: Edward Sun <sunedward@google.com>
#6894) * Split old README into separate pages in a 'Getting started' section * Aded instructions on how to view docs locally
…or bot management (#6857)
* Update use-built-provider.md * Update use-built-provider.md
…ng of rule field (#6904)
DESTROYED or DESTROY_SCHEDULED
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintto ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)