Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make google_notebooks_instance metadata field updatable #7945

Merged
merged 7 commits into from
May 18, 2023
Merged

Make google_notebooks_instance metadata field updatable #7945

merged 7 commits into from
May 18, 2023

Commits on May 15, 2023

  1. Added update tests proving that metadata is not updatable

    @melinath
    melinath committed May 15, 2023
    Configuration menu
    Copy the full SHA
    9e34626 View commit details
    Browse the repository at this point in the history

  2. Test fixes

    @melinath
    melinath committed May 15, 2023
    Configuration menu
    Copy the full SHA
    ffa79b8 View commit details
    Browse the repository at this point in the history

  3. Made notebooks instance metadata field updatable

    @melinath
    melinath committed May 15, 2023
    Configuration menu
    Copy the full SHA
    1ac238a View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. Added metadata to ImportStateVerifyIgnore for impacted tests

    @melinath
    melinath committed May 16, 2023
    Configuration menu
    Copy the full SHA
    08864ab View commit details
    Browse the repository at this point in the history

  2. Removed non-updatable fields from update test

    @melinath
    melinath committed May 16, 2023
    Configuration menu
    Copy the full SHA
    f380e41 View commit details
    Browse the repository at this point in the history

  3. Temporarily made metadata field not updatable to prove that only thes… 

    …e changes are required to make the tests pass
    @melinath
    melinath committed May 16, 2023
    Configuration menu
    Copy the full SHA
    f22a9e4 View commit details
    Browse the repository at this point in the history

  4. Revert "Temporarily made metadata field not updatable to prove that o… 

    …nly these changes are required to make the tests pass"

This reverts commit f22a9e4.
    @melinath
    melinath committed May 16, 2023
    Configuration menu
    Copy the full SHA
    b715457 View commit details
    Browse the repository at this point in the history