-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make google_notebooks_instance metadata field updatable #7945
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9e34626
Added update tests proving that metadata is not updatable
melinath ffa79b8
Test fixes
melinath 1ac238a
Made notebooks instance metadata field updatable
melinath 08864ab
Added metadata to ImportStateVerifyIgnore for impacted tests
melinath f380e41
Removed non-updatable fields from update test
melinath f22a9e4
Temporarily made metadata field not updatable to prove that only thes…
melinath b715457
Revert "Temporarily made metadata field not updatable to prove that o…
melinath File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
mmv1/templates/terraform/update_encoder/notebooks_instance.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
// Update requests use "items" as the api name instead of "metadata" | ||
// https://cloud.google.com/vertex-ai/docs/workbench/reference/rest/v1/projects.locations.instances/updateMetadataItems | ||
if metadata, ok := obj["metadata"]; ok { | ||
obj["items"] = metadata | ||
delete(obj, "metadata") | ||
} | ||
return obj, nil |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I understanding this correctly that we aren't ever checking that the metadata is updated on the server?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. The field is marked as
ignore_read
on the resource, so we never check what the value on the server is. I had to add it here because I introduced it as a new field in this test.I suspect that we would not use ignore_read like this if implementing the resource today - but fixing that wouldn't be trivial and is outside of the scope of the ticket. In the future I think we'd want to do something similar to hashicorp/terraform-provider-google#14293.