Add AlloyDB user support #8431

DanielRieske · 2023-07-23T15:09:28Z

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

google_alloydb_user

Closes: hashicorp/terraform-provider-google#14272

modular-magician · 2023-07-23T15:09:56Z

Hello! I am a robot. It looks like you are a community contributor. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2023-07-24T16:39:52Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 787 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 787 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 3 files changed, 91 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 106 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_alloydb_user (1 total tests)
Untested fields: cluster, user_id, database_roles, user_type

Please add acceptance tests which include these fields.

modular-magician · 2023-07-24T18:23:10Z

Tests analytics

Total tests: 2875
Passed tests 2573
Skipped tests: 299
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeFirewallPolicyRule_multipleRules|TestAccAlloydbUser_alloydbUserExample

Get to know how VCR tests work

modular-magician · 2023-07-24T18:32:12Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeFirewallPolicyRule_multipleRules[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccAlloydbUser_alloydbUserExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

DanielRieske · 2023-07-25T12:08:27Z

Added tests to increase test coverage for the missing fields, can we run the tests again?

modular-magician · 2023-07-25T17:26:01Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 827 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 4 files changed, 827 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 3 files changed, 91 insertions(+), 3 deletions(-))

modular-magician · 2023-07-25T19:11:19Z

Tests analytics

Total tests: 2874
Passed tests 2572
Skipped tests: 299
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbUser_alloydbUserIamUserExample|TestAccAlloydbUser_alloydbUserExample|TestAccContainerAwsNodePool_BetaBasicHandWritten

Get to know how VCR tests work

modular-magician · 2023-07-25T19:33:27Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbUser_alloydbUserIamUserExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbUser_alloydbUserExample[Error message] [Debug log]
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

DanielRieske · 2023-07-25T20:15:04Z

Anyway of getting the log where the test TestAccAlloydbUser_alloydbUserExample went wrong?

I tested them on my own account on which it passed.


terraform-provider-google git:(main) ✗ make testacc TEST=./google TESTARGS='-run=TestAccAlloydbUser_alloydbUserExample'
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google -v -run=TestAccAlloydbUser_alloydbUserExample -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccAlloydbUser_alloydbUserExample
=== PAUSE TestAccAlloydbUser_alloydbUserExample
=== CONT  TestAccAlloydbUser_alloydbUserExample
--- PASS: TestAccAlloydbUser_alloydbUserExample (909.38s)
PASS
ok      github.com/hashicorp/terraform-provider-google/google   910.034s

DanielRieske · 2023-07-26T10:36:27Z

I realised that I never ran the tests at the same time, by doing this I realised that the compute_networks being created didn't have a unique name and therefore failing.

terraform-provider-google git:(main) ✗ make testacc TEST=./google TESTARGS='-run=TestAccAlloydbUser_'
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google -v -run=TestAccAlloydbUser_ -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccAlloydbUser_alloydbUserExample
=== PAUSE TestAccAlloydbUser_alloydbUserExample
=== RUN   TestAccAlloydbUser_alloydbUserIamUserExample
=== PAUSE TestAccAlloydbUser_alloydbUserIamUserExample
=== CONT  TestAccAlloydbUser_alloydbUserExample
=== CONT  TestAccAlloydbUser_alloydbUserIamUserExample
--- PASS: TestAccAlloydbUser_alloydbUserExample (1136.85s)
--- PASS: TestAccAlloydbUser_alloydbUserIamUserExample (1171.33s)
PASS
ok      github.com/hashicorp/terraform-provider-google/google   1171.995s

slevenick · 2023-07-26T16:38:35Z

mmv1/templates/terraform/examples/alloydb_user_iam_user.tf.erb

+}
+
+resource "google_compute_network" "<%= ctx[:primary_resource_id] %>" {
+  name = "alloydb-cluster"


This should change to a parameterized value so it gets a random suffix attached. Right now this is causing the failure because it collides with another network named the same

@slevenick I am skipping the generation of tests because this particular resource does not work well with the autogenerated tests.

If we destroy the cluster or instance during the CheckDestroy phase that will result in Internal 500 errors when trying to verify if an user still exists, therefore I need to check it while the parent resource still exists.

That's.... frightening. What do we expect the user experience to be when they created a user within Terraform and then they destroyed it via another tool? They would hit the 500 and be confused about what is happening

Can you share either the error message in logs or a use case that triggers it? I can reach out to the internal team because returning a 500 on an attempted GET is pretty bad.

@slevenick I did not realise the impact in certain scenario's on users and didn't report it, for future contributions I will keep this in mind.

There are a few scenario's where this can happens but usually boils down to not having an instance in it's cluster.

I tested the following 2 scenario's:

You create a cluster and try to add an user without creating an instance.

2023-07-26T20:57:40.102+0200 [DEBUG] provider.terraform-provider-google: ---[ REQUEST ]--------------------------------------- 2023-07-26T20:57:40.102+0200 [DEBUG] provider.terraform-provider-google: POST /v1/projects/playground-x/locations/europe-west4/clusters/tf-test-alloydb-cluster/users?alt=json&userId=test HTTP/1.1 2023-07-26T20:57:40.102+0200 [DEBUG] provider.terraform-provider-google: Host: alloydb.googleapis.com 2023-07-26T20:57:40.102+0200 [DEBUG] provider.terraform-provider-google: User-Agent: Terraform/1.5.0 (+https://www.terraform.io) Terraform-Plugin-SDK/2.10.1 terraform-provider-google/dev 2023-07-26T20:57:40.103+0200 [DEBUG] provider.terraform-provider-google: Content-Length: 67 2023-07-26T20:57:40.103+0200 [DEBUG] provider.terraform-provider-google: Content-Type: application/json 2023-07-26T20:57:40.103+0200 [DEBUG] provider.terraform-provider-google: Accept-Encoding: gzip 2023-07-26T20:57:40.103+0200 [DEBUG] provider.terraform-provider-google: 2023-07-26T20:57:40.103+0200 [DEBUG] provider.terraform-provider-google: { 2023-07-26T20:57:40.103+0200 [DEBUG] provider.terraform-provider-google: "databaseRoles": [ 2023-07-26T20:57:40.103+0200 [DEBUG] provider.terraform-provider-google: "alloydbiamuser" 2023-07-26T20:57:40.103+0200 [DEBUG] provider.terraform-provider-google: ], 2023-07-26T20:57:40.103+0200 [DEBUG] provider.terraform-provider-google: "userType": "ALLOYDB_IAM_USER" 2023-07-26T20:57:40.103+0200 [DEBUG] provider.terraform-provider-google: } 2023-07-26T20:57:40.103+0200 [DEBUG] provider.terraform-provider-google: 2023-07-26T20:57:40.103+0200 [DEBUG] provider.terraform-provider-google: ----------------------------------------------------- 2023-07-26T20:57:40.263+0200 [DEBUG] provider.terraform-provider-google: 2023/07/26 20:57:40 [DEBUG] Google API Response Details: 2023-07-26T20:57:40.263+0200 [DEBUG] provider.terraform-provider-google: ---[ RESPONSE ]-------------------------------------- 2023-07-26T20:57:40.263+0200 [DEBUG] provider.terraform-provider-google: HTTP/2.0 500 Internal Server Error 2023-07-26T20:57:40.263+0200 [DEBUG] provider.terraform-provider-google: Alt-Svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000 2023-07-26T20:57:40.263+0200 [DEBUG] provider.terraform-provider-google: Cache-Control: private 2023-07-26T20:57:40.263+0200 [DEBUG] provider.terraform-provider-google: Content-Type: application/json; charset=UTF-8 2023-07-26T20:57:40.263+0200 [DEBUG] provider.terraform-provider-google: Date: Wed, 26 Jul 2023 18:57:40 GMT 2023-07-26T20:57:40.263+0200 [DEBUG] provider.terraform-provider-google: Server: ESF 2023-07-26T20:57:40.263+0200 [DEBUG] provider.terraform-provider-google: Vary: Origin 2023-07-26T20:57:40.263+0200 [DEBUG] provider.terraform-provider-google: Vary: X-Origin 2023-07-26T20:57:40.263+0200 [DEBUG] provider.terraform-provider-google: Vary: Referer 2023-07-26T20:57:40.263+0200 [DEBUG] provider.terraform-provider-google: X-Content-Type-Options: nosniff 2023-07-26T20:57:40.263+0200 [DEBUG] provider.terraform-provider-google: X-Frame-Options: SAMEORIGIN 2023-07-26T20:57:40.263+0200 [DEBUG] provider.terraform-provider-google: X-Xss-Protection: 0 2023-07-26T20:57:40.263+0200 [DEBUG] provider.terraform-provider-google: 2023-07-26T20:57:40.263+0200 [DEBUG] provider.terraform-provider-google: { 2023-07-26T20:57:40.263+0200 [DEBUG] provider.terraform-provider-google: "error": { 2023-07-26T20:57:40.263+0200 [DEBUG] provider.terraform-provider-google: "code": 500, 2023-07-26T20:57:40.263+0200 [DEBUG] provider.terraform-provider-google: "message": "An internal error has occurred (4e2d52b2-e97b-466a-9d22-a1a2c9b499bc)", 2023-07-26T20:57:40.263+0200 [DEBUG] provider.terraform-provider-google: "status": "INTERNAL" 2023-07-26T20:57:40.264+0200 [DEBUG] provider.terraform-provider-google: } 2023-07-26T20:57:40.264+0200 [DEBUG] provider.terraform-provider-google: }

│ Error: Error creating User: timeout while waiting for state to become 'success' (timeout: 1m0s) │ │ with google_alloydb_user.default, │ on main.tf line 61, in resource "google_alloydb_user" "user": │ 34: resource "google_alloydb_user" "user" {

You create a cluster, instance & user through Terraform and we delete the instance and try to pull the state of the user resource

2023-07-26T20:23:52.799+0200 [DEBUG] provider.terraform-provider-google: ---[ REQUEST ]--------------------------------------- 2023-07-26T20:23:52.799+0200 [DEBUG] provider.terraform-provider-google: GET /v1/projects/playground-x/locations/europe-west4/clusters/tf-test-alloydb-cluster/users/test?alt=json HTTP/1.1 2023-07-26T20:23:52.799+0200 [DEBUG] provider.terraform-provider-google: Host: alloydb.googleapis.com 2023-07-26T20:23:52.799+0200 [DEBUG] provider.terraform-provider-google: User-Agent: Terraform/1.5.0 (+https://www.terraform.io) Terraform-Plugin-SDK/2.10.1 terraform-provider-google/dev 2023-07-26T20:23:52.799+0200 [DEBUG] provider.terraform-provider-google: Content-Type: application/json 2023-07-26T20:23:52.799+0200 [DEBUG] provider.terraform-provider-google: Accept-Encoding: gzip 2023-07-26T20:23:52.799+0200 [DEBUG] provider.terraform-provider-google: 2023-07-26T20:23:52.799+0200 [DEBUG] provider.terraform-provider-google: 2023-07-26T20:23:52.800+0200 [DEBUG] provider.terraform-provider-google: ----------------------------------------------------- 2023-07-26T20:23:52.837+0200 [DEBUG] provider.terraform-provider-google: 2023/07/26 20:23:52 [DEBUG] Google API Response Details: 2023-07-26T20:23:52.837+0200 [DEBUG] provider.terraform-provider-google: ---[ RESPONSE ]-------------------------------------- 2023-07-26T20:23:52.837+0200 [DEBUG] provider.terraform-provider-google: HTTP/2.0 500 Internal Server Error 2023-07-26T20:23:52.837+0200 [DEBUG] provider.terraform-provider-google: Alt-Svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000 2023-07-26T20:23:52.837+0200 [DEBUG] provider.terraform-provider-google: Cache-Control: private 2023-07-26T20:23:52.837+0200 [DEBUG] provider.terraform-provider-google: Content-Type: application/json; charset=UTF-8 2023-07-26T20:23:52.837+0200 [DEBUG] provider.terraform-provider-google: Date: Wed, 26 Jul 2023 18:23:52 GMT 2023-07-26T20:23:52.837+0200 [DEBUG] provider.terraform-provider-google: Server: ESF 2023-07-26T20:23:52.837+0200 [DEBUG] provider.terraform-provider-google: Vary: Origin 2023-07-26T20:23:52.837+0200 [DEBUG] provider.terraform-provider-google: Vary: X-Origin 2023-07-26T20:23:52.837+0200 [DEBUG] provider.terraform-provider-google: Vary: Referer 2023-07-26T20:23:52.837+0200 [DEBUG] provider.terraform-provider-google: X-Content-Type-Options: nosniff 2023-07-26T20:23:52.837+0200 [DEBUG] provider.terraform-provider-google: X-Frame-Options: SAMEORIGIN 2023-07-26T20:23:52.837+0200 [DEBUG] provider.terraform-provider-google: X-Xss-Protection: 0 2023-07-26T20:23:52.837+0200 [DEBUG] provider.terraform-provider-google: 2023-07-26T20:23:52.837+0200 [DEBUG] provider.terraform-provider-google: { 2023-07-26T20:23:52.837+0200 [DEBUG] provider.terraform-provider-google: "error": { 2023-07-26T20:23:52.837+0200 [DEBUG] provider.terraform-provider-google: "code": 500, 2023-07-26T20:23:52.837+0200 [DEBUG] provider.terraform-provider-google: "message": "An internal error has occurred (044b08c2-93bd-4981-a397-05c5c1b32f2b)", 2023-07-26T20:23:52.837+0200 [DEBUG] provider.terraform-provider-google: "status": "INTERNAL" 2023-07-26T20:23:52.837+0200 [DEBUG] provider.terraform-provider-google: } 2023-07-26T20:23:52.837+0200 [DEBUG] provider.terraform-provider-google: }

│ Error: Error when reading or editing AlloydbUser "projects/playground-x/locations/europe-west4/clusters/tf-test-alloydb-cluster/users/test": googleapi: Error 500: An internal error has occurred (570d762a-8316-4854-b15c-a40116fb4e97) │ │ with google_alloydb_user.user, │ on main.tf line 61, in resource "google_alloydb_user" "user": │ 61: resource "google_alloydb_user" "user" {

While I was at it I tested what happens with an invalid cluster name and it got rejected as a 404.

Given these results I am unsure if this should be merged at this time.

@GauravJain21 please take a look at this

slevenick

Error is: global/networks/alloydb-cluster' already exists, alreadyExists

Please change the name to be parameterized so it gets randomized

DanielRieske · 2023-07-26T17:07:29Z

This was changed in the "handwritten" tests and should work.

modular-magician · 2023-07-26T17:31:44Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 827 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 4 files changed, 827 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 3 files changed, 91 insertions(+), 3 deletions(-))

modular-magician · 2023-07-26T19:16:13Z

Tests analytics

Total tests: 2886
Passed tests 2582
Skipped tests: 301
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccAlloydbUser_alloydbUserExample|TestAccAlloydbUser_alloydbUserIamUserExample

Get to know how VCR tests work

modular-magician · 2023-07-26T19:37:33Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbUser_alloydbUserExample[Debug log]
TestAccAlloydbUser_alloydbUserIamUserExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

slevenick · 2023-07-26T19:48:56Z

@GauravJain21 can you take a look at the error message here? This looks to be a bug on the service side, we shouldn't be getting a 500 response

slevenick

Needs some changes before merging, but the main questions come around the stability of this API for integration, especially around the 500 error returned in some cases.

At this point we should wait for @GauravJain21 to review

mmv1/products/alloydb/User.yaml

slevenick · 2023-07-26T19:56:33Z

mmv1/products/alloydb/User.yaml

+    description: |
+      The ID of the alloydb user.
+  - !ruby/object:Api::Type::ResourceRef
+    name: 'cluster'


Is it preferable to have this set up as a single parent resource rather than a series of project/location/cluster?

Generally we have each broken out into an individual field.

cc @GauravJain21

That would mean that the user has to set it's location and I'd argue this resource isn't a regional object on it's own but rather part of a regional object.

As the cluster dictates what region the user resides in I wouldn't give the user the option to specify location.

True. On the other hand existing resources like google_sql_user work this way, where the project and instance are both specified independently: https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/sql_user#project

The biggest difference here is that google_sql_user doesn't rely on a region in his end-point nor is it a field that can be set.
It is implied that it lives in the region where the instance resides in.

POST https://sqladmin.googleapis.com/v1/projects/{project}/instances/{instance}/users

I am curious what others believe the right approach is here.

mmv1/products/alloydb/User.yaml

slevenick · 2023-07-26T19:57:46Z

mmv1/templates/terraform/examples/alloydb_user_iam_user.tf.erb

+}
+
+resource "google_compute_network" "<%= ctx[:primary_resource_id] %>" {
+  name = "alloydb-cluster"


@GauravJain21 please take a look at this

modular-magician · 2023-07-27T01:22:23Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 887 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 4 files changed, 887 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 3 files changed, 91 insertions(+), 3 deletions(-))

modular-magician · 2023-07-27T02:39:28Z

Tests analytics

Total tests: 2891
Passed tests 2586
Skipped tests: 302
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccAlloydbUser_alloydbUserIamUser|TestAccAlloydbUser_alloydbUser

Get to know how VCR tests work

modular-magician · 2023-07-27T03:06:47Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbUser_alloydbUserIamUser[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccAlloydbUser_alloydbUser[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

DanielRieske · 2023-07-27T14:56:06Z

TestAccAlloydbUser_alloydbUser failed because of an incorrect cluster reference, I corrected the mistake and ran the tests on my own account.

➜  terraform-provider-google git:(main) ✗ make testacc TEST=./google TESTARGS='-run=TestAccAlloydbUser_'         
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google -v -run=TestAccAlloydbUser_ -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccAlloydbUser_alloydbUser
=== PAUSE TestAccAlloydbUser_alloydbUser
=== RUN   TestAccAlloydbUser_alloydbUserIamUser
=== PAUSE TestAccAlloydbUser_alloydbUserIamUser
=== CONT  TestAccAlloydbUser_alloydbUser
=== CONT  TestAccAlloydbUser_alloydbUserIamUser
--- PASS: TestAccAlloydbUser_alloydbUserIamUser (1173.06s)
--- PASS: TestAccAlloydbUser_alloydbUser (1232.61s)
PASS
ok      github.com/hashicorp/terraform-provider-google/google   1233.281s

Anyway we can re-run the tests?

modular-magician · 2023-07-27T15:23:24Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 945 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 4 files changed, 945 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 3 files changed, 91 insertions(+), 3 deletions(-))

modular-magician · 2023-07-27T17:14:05Z

Tests analytics

Total tests: 2891
Passed tests 2585
Skipped tests: 302
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccIapWebTypeAppEngineIamBindingGenerated|TestAccAlloydbUser_alloydbUser|TestAccAlloydbUser_alloydbUserIamUser

Get to know how VCR tests work

modular-magician · 2023-07-27T17:37:30Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbUser_alloydbUser[Debug log]
TestAccAlloydbUser_alloydbUserIamUser[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccIapWebTypeAppEngineIamBindingGenerated[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

slevenick · 2023-07-27T18:46:36Z

Tests look good, I'm going to hold off on more review until @GauravJain21 has a chance to look at this next week.

DanielRieske · 2023-08-10T12:07:24Z

Hi @GauravJain21, did you have an opportunity yet to take a look at this?

GauravJain21 · 2023-08-10T13:06:52Z

Hey Daniel, I am currently working on something else. I intend to review this next week or the week after. Best, Gaurav Jain

…

On Thu, Aug 10, 2023 at 5:37 PM Daniel Rieske ***@***.***> wrote: Hi @GauravJain21 <https://github.com/GauravJain21>, did you have an opportunity yet to take a look at this? — Reply to this email directly, view it on GitHub <#8431 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACTUA3NRCNBFM5JFUY2TOELXUTFIPANCNFSM6AAAAAA2USJU7U> . You are receiving this because you were mentioned.Message ID: ***@***.***>

DanielRieske · 2023-09-04T17:01:18Z

Hi @GauravJain21, anything I can do to help at this point?

GauravJain21 · 2023-09-05T05:04:39Z

Hey Daniel,
We have stopped taking in PR requests for major features from the external community contribution. An internal developer is working for adding Users API support to Terraform.
Best,
Gaurav

DanielRieske · 2023-09-05T18:38:58Z

@GauravJain21 Thank you for your response and sad to hear that major features created by the external community won't be accepted anymore.

Will there be an official statement on what type of contributions will or will not be considered? I truly enjoy working on this product and have thoroughly enjoyed contributing to it.

But if certain contributions won't be accepted anymore then I'd like to know to what extent so I won’t spend time on contributions that might not get accepted.

Thanks a lot!

alexgartner-bc · 2023-09-18T17:31:34Z

@GauravJain21 any update on this?

GauravJain21 · 2023-09-19T03:44:55Z

We are tracking it here. Can you close this as duplicate. PR has been raised.

DanielRieske added 3 commits July 23, 2023 15:43

feat: add AlloyDB user support

bfb1644

chore: changed expected timeout values

1d63878

feat: updated password properties and descriptions

c090453

modular-magician requested a review from slevenick July 23, 2023 15:09

modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jul 23, 2023

DanielRieske changed the title ~~feat: add AlloyDB user support~~ Add AlloyDB user support Jul 23, 2023

modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jul 24, 2023

chore: added new-line for pre-build validation

92a1a1c

modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jul 24, 2023

feat: added handwritten tests and updated docs

350325c

modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jul 25, 2023

bschaatsbergen mentioned this pull request Jul 25, 2023

[New resource] - google_alloydb_user #8447

Closed

5 tasks

bschaatsbergen mentioned this pull request Jul 25, 2023

[New resource] - AlloyDB Users hashicorp/terraform-provider-google#15287

Closed

chore: added random_suffix for parallel tests

7db7e17

modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jul 26, 2023

slevenick reviewed Jul 26, 2023

View reviewed changes

slevenick requested changes Jul 26, 2023

View reviewed changes

modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jul 26, 2023

slevenick requested changes Jul 26, 2023

View reviewed changes

feat: added additional update tests

7981267

modular-magician requested a review from slevenick July 27, 2023 01:05

modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Jul 27, 2023

feat: corrected compute network name in tests

44fa955

Merge branch 'GoogleCloudPlatform:main' into alloy_db_user_support

5e3592a

modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jul 27, 2023

feat: updated CheckDestroy with correct plan

eda0326

modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jul 27, 2023

DanielRieske closed this Sep 19, 2023

Add AlloyDB user support #8431

Add AlloyDB user support #8431

Conversation

DanielRieske commented Jul 23, 2023 • edited Loading

modular-magician commented Jul 23, 2023

modular-magician commented Jul 24, 2023

Diff report

Missing test report

modular-magician commented Jul 24, 2023

Tests analytics

Action taken

modular-magician commented Jul 24, 2023

Rerun these tests in REPLAYING mode to catch issues

DanielRieske commented Jul 25, 2023 • edited Loading

modular-magician commented Jul 25, 2023

Diff report

modular-magician commented Jul 25, 2023

Tests analytics

Action taken

modular-magician commented Jul 25, 2023

Rerun these tests in REPLAYING mode to catch issues

DanielRieske commented Jul 25, 2023

DanielRieske commented Jul 26, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

slevenick left a comment

Choose a reason for hiding this comment

DanielRieske commented Jul 26, 2023

modular-magician commented Jul 26, 2023

Diff report

modular-magician commented Jul 26, 2023

Tests analytics

Action taken

modular-magician commented Jul 26, 2023

Rerun these tests in REPLAYING mode to catch issues

slevenick commented Jul 26, 2023

slevenick left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

modular-magician commented Jul 27, 2023

Diff report

modular-magician commented Jul 27, 2023

Tests analytics

Action taken

modular-magician commented Jul 27, 2023

Rerun these tests in REPLAYING mode to catch issues

DanielRieske commented Jul 27, 2023

modular-magician commented Jul 27, 2023

Diff report

modular-magician commented Jul 27, 2023

Tests analytics

Action taken

modular-magician commented Jul 27, 2023

Rerun these tests in REPLAYING mode to catch issues

slevenick commented Jul 27, 2023

DanielRieske commented Aug 10, 2023

GauravJain21 commented Aug 10, 2023 via email

DanielRieske commented Sep 4, 2023

GauravJain21 commented Sep 5, 2023

DanielRieske commented Sep 5, 2023 • edited Loading

alexgartner-bc commented Sep 18, 2023

GauravJain21 commented Sep 19, 2023

DanielRieske commented Jul 23, 2023 •

edited

Loading

DanielRieske commented Jul 25, 2023 •

edited

Loading

DanielRieske commented Sep 5, 2023 •

edited

Loading