Users API changes #8920

pattukerman · 2023-09-12T01:00:47Z

AlloyDB hosts different resources in its public API, including Clusters, Instances, and Backups. All those have their corresponding Terraform integration. One new AlloyDB resource that got published in 2023 April is AlloyDB Users resource and API. This PR introduces support for it.

Release Note Template for Downstream PRs (will be copied)

`google_alloydb_user`

modular-magician · 2023-09-12T01:01:23Z

Hello! I am a robot. It looks like you are a: ~~Community Contributor~~ Googler ~~Core Contributor~~. Tests will run automatically.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2023-09-12T01:10:19Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 1063 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 1063 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 89 insertions(+))
TF OiCS: Diff ( 8 files changed, 295 insertions(+))

Remove the trailing empty line

modular-magician · 2023-09-12T01:32:43Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 1063 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 1068 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 89 insertions(+))
TF OiCS: Diff ( 8 files changed, 295 insertions(+))

modular-magician · 2023-09-12T02:43:59Z

Tests analytics

Total tests: 3032
Passed tests 2730
Skipped tests: 297
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbUser_updateRoles_IAM|TestAccAlloydbUser_updatePassword_BuiltIn|TestAccAlloydbUser_updateRoles_BuiltIn|TestAccAlloydbUser_alloydbUserBuiltinExample|TestAccAlloydbUser_alloydbUserIamExample

Get to know how VCR tests work

modular-magician · 2023-09-12T03:04:45Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbUser_updatePassword_BuiltIn[Debug log]
TestAccAlloydbUser_updateRoles_BuiltIn[Debug log]
TestAccAlloydbUser_alloydbUserBuiltinExample[Debug log]
TestAccAlloydbUser_alloydbUserIamExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbUser_updateRoles_IAM[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

pattukerman · 2023-09-13T22:40:44Z

The failing test is due to an issue with the AlloyDB Control Plane. The fix has been submitted and is waiting to be deployed. I'd appreciate an early feedback about the PR beforehand.

shuyama1 · 2023-09-13T22:58:59Z

The failing test is due to an issue with the AlloyDB Control Plane. The fix has been submitted and is waiting to be deployed. I'd appreciate an early feedback about the PR beforehand.

@pattukerman Thanks for the heads up. I'll start working on the review but will hold merging until the upstream fix.

Removing the test for now, since AlloyDB control plane deployment for the fix is taking time. The fix is about returning the database roles for a given user in sorted order, so it is not a breaking bug. I will re-add the test once the Control Plane deployment is done.

modular-magician · 2023-09-20T17:50:13Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 971 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 971 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 89 insertions(+))
TF OiCS: Diff ( 8 files changed, 295 insertions(+))

modular-magician · 2023-09-20T19:04:21Z

Tests analytics

Total tests: 3079
Passed tests 2779
Skipped tests: 299
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceGoogleServiceAccountIdToken_impersonation

Get to know how VCR tests work

modular-magician · 2023-09-20T19:07:16Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

shuyama1

First pass. will look into tests closely after

mmv1/products/alloydb/User.yaml

shuyama1 · 2023-09-20T20:58:45Z

mmv1/products/alloydb/User.yaml

+create_url: '{{cluster}}/users?userId={{user_id}}'
+update_url: '{{cluster}}/users?userId={{user_id}}'
+update_verb: :POST
+update_mask: false


If we're not using udpate mask for this resource, we can omit this field. The default is false

Sounds good, I'll remove the line.

mmv1/products/alloydb/User.yaml

modular-magician · 2023-09-21T20:07:16Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 971 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 971 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 89 insertions(+))
TF OiCS: Diff ( 8 files changed, 295 insertions(+))

modular-magician · 2023-09-21T21:20:46Z

Tests analytics

Total tests: 3081
Passed tests 2782
Skipped tests: 299
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

modular-magician · 2023-09-26T21:53:30Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 971 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 971 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 89 insertions(+))
TF OiCS: Diff ( 8 files changed, 295 insertions(+))

modular-magician · 2023-09-26T23:07:11Z

Tests analytics

Total tests: 3096
Passed tests 2797
Skipped tests: 299
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

GauravJain21 · 2023-09-27T07:08:20Z

Hey Shuya,
Can you please approve and merge this PR?

shuyama1

Some comments + questions. Sorry for the delay on reviewing it.

mmv1/products/alloydb/User.yaml

Add back the update test for IAM user.

modular-magician · 2023-10-02T19:04:56Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 1054 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 1054 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 89 insertions(+))
TF OiCS: Diff ( 8 files changed, 295 insertions(+))

modular-magician · 2023-10-03T01:04:41Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbUser_updateRoles_IAM[Error message] [Debug log]
TestAccAlloydbUser_alloydbUserIamExample[Error message] [Debug log]
TestAccAlloydbUser_updateRoles_BuiltIn[Error message] [Debug log]
TestAccAlloydbUser_alloydbUserBuiltinExample[Error message] [Debug log]
TestAccAlloydbUser_updatePassword_BuiltIn[Error message] [Debug log]
TestAccContainerNodePool_withKubeletConfig[Error message] [Debug log]
TestAccContainerNodePool_withUpgradeSettings[Error message] [Debug log]
TestAccContainerCluster_withAddons[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-10-03T03:57:58Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 1054 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 1054 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 89 insertions(+))
TF OiCS: Diff ( 8 files changed, 295 insertions(+))

modular-magician · 2023-10-03T05:10:50Z

Tests analytics

Total tests: 3115
Passed tests 2792
Skipped tests: 314
Affected tests: 9

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbUser_updateRoles_IAM|TestAccAlloydbUser_alloydbUserBuiltinExample|TestAccAlloydbUser_alloydbUserIamExample|TestAccAlloydbUser_updateRoles_BuiltIn|TestAccAlloydbUser_updatePassword_BuiltIn|TestAccContainerCluster_withAddons|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerNodePool_withKubeletConfig|TestAccSpannerInstanceIamPolicy

Get to know how VCR tests work

modular-magician · 2023-10-03T05:57:33Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbUser_updateRoles_IAM[Debug log]
TestAccAlloydbUser_alloydbUserBuiltinExample[Debug log]
TestAccAlloydbUser_alloydbUserIamExample[Debug log]
TestAccAlloydbUser_updateRoles_BuiltIn[Debug log]
TestAccSpannerInstanceIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbUser_updatePassword_BuiltIn[Error message] [Debug log]
TestAccContainerCluster_withAddons[Error message] [Debug log]
TestAccContainerNodePool_withUpgradeSettings[Error message] [Debug log]
TestAccContainerNodePool_withKubeletConfig[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

shuyama1 · 2023-10-03T17:18:46Z

/gcbrun

modular-magician · 2023-10-03T17:28:35Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 1054 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 1054 insertions(+), 7 deletions(-))
TF Conversion: Diff ( 1 file changed, 89 insertions(+))
TF OiCS: Diff ( 8 files changed, 295 insertions(+))

modular-magician · 2023-10-03T18:42:33Z

Tests analytics

Total tests: 3117
Passed tests 2797
Skipped tests: 314
Affected tests: 6

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbUser_updatePassword_BuiltIn|TestAccContainerNodePool_withKubeletConfig|TestAccContainerCluster_withAddons|TestAccContainerNodePool_withUpgradeSettings|TestAccHealthcareDatasetIamPolicy|TestAccDataSourceGoogleServiceAccountJwt

Get to know how VCR tests work

modular-magician · 2023-10-03T19:26:02Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbUser_updatePassword_BuiltIn[Debug log]
TestAccHealthcareDatasetIamPolicy[Debug log]
TestAccDataSourceGoogleServiceAccountJwt[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerNodePool_withKubeletConfig[Error message] [Debug log]
TestAccContainerCluster_withAddons[Error message] [Debug log]
TestAccContainerNodePool_withUpgradeSettings[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

GauravJain21 · 2023-10-04T05:39:48Z

/gcbrun

GauravJain21 · 2023-10-04T05:41:15Z

Hey Shuya,
The failing tests are not a part of AlloyDB service. Can you please merge this PR?

shuyama1 · 2023-10-04T16:56:13Z

Hey Shuya, The failing tests are not a part of AlloyDB service. Can you please merge this PR?

Thanks for taking a look at the PR. Yes, the failing tests are unrelated to the change of this PR and we don't need to worry about them. I'm giving a final pass now. I'll approve and merge the PR when it's ready to go

mmv1/products/alloydb/User.yaml

modular-magician · 2023-10-04T21:51:36Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 1049 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 1049 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 89 insertions(+))
TF OiCS: Diff ( 8 files changed, 295 insertions(+))

modular-magician · 2023-10-04T23:05:12Z

Tests analytics

Total tests: 3124
Passed tests 2800
Skipped tests: 318
Affected tests: 6

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbUser_updateRoles_BuiltIn|TestAccAlloydbUser_alloydbUserBuiltinExample|TestAccAlloydbUser_updateRoles_IAM|TestAccAlloydbUser_alloydbUserIamExample|TestAccAlloydbUser_updatePassword_BuiltIn|TestAccWorkstationsWorkstationConfig_update

Get to know how VCR tests work

modular-magician · 2023-10-05T00:08:54Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbUser_updateRoles_BuiltIn[Debug log]
TestAccAlloydbUser_alloydbUserBuiltinExample[Debug log]
TestAccAlloydbUser_alloydbUserIamExample[Debug log]
TestAccAlloydbUser_updatePassword_BuiltIn[Debug log]
TestAccWorkstationsWorkstationConfig_update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbUser_updateRoles_IAM[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

pattukerman · 2023-10-05T00:35:12Z

/gcbrun

modular-magician · 2023-10-05T00:47:45Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 1049 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 1049 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 89 insertions(+))
TF OiCS: Diff ( 8 files changed, 295 insertions(+))

modular-magician · 2023-10-05T02:00:54Z

Tests analytics

Total tests: 3124
Passed tests 2805
Skipped tests: 318
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbUser_updateRoles_IAM

Get to know how VCR tests work

modular-magician · 2023-10-05T02:22:29Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbUser_updateRoles_IAM[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

shuyama1

LGTM! Thank you!

Users API changes

1c5cb3e

modular-magician requested a review from shuyama1 September 12, 2023 01:01

Update User.yaml

3edae1e

Remove the trailing empty line

GauravJain21 mentioned this pull request Sep 19, 2023

Add AlloyDB user support #8431

Closed

5 tasks

shuyama1 reviewed Sep 20, 2023

View reviewed changes

Update User.yaml

305a5e1

modular-magician requested a review from shuyama1 September 21, 2023 19:58

GauravJain21 mentioned this pull request Sep 22, 2023

Add google_alloydb_user resouce w/ support for creating IAM users hashicorp/terraform-provider-google#14272

Closed

Merge branch 'GoogleCloudPlatform:main' into user-changes

f5a7501

shuyama1 reviewed Sep 27, 2023

View reviewed changes

mmv1/products/alloydb/User.yaml Show resolved Hide resolved

mmv1/products/alloydb/User.yaml Show resolved Hide resolved

mmv1/products/alloydb/User.yaml Show resolved Hide resolved

Update resource_alloydb_user_test.go

905e8dc

Add back the update test for IAM user.

modular-magician requested a review from shuyama1 October 2, 2023 18:56

Merge branch 'GoogleCloudPlatform:main' into user-changes

dd38126

Address comments

46b8c21

shuyama1 requested changes Oct 4, 2023

View reviewed changes

mmv1/products/alloydb/User.yaml Show resolved Hide resolved

mmv1/products/alloydb/User.yaml Outdated Show resolved Hide resolved

mmv1/products/alloydb/User.yaml Show resolved Hide resolved

mmv1/products/alloydb/User.yaml Outdated Show resolved Hide resolved

address comments

7e39080

modular-magician requested a review from shuyama1 October 4, 2023 21:42

Merge branch 'GoogleCloudPlatform:main' into user-changes

6f3fbb2

shuyama1 approved these changes Oct 5, 2023

View reviewed changes

shuyama1 merged commit 0575853 into GoogleCloudPlatform:main Oct 5, 2023
12 checks passed

trodge pushed a commit to trodge/magic-modules that referenced this pull request Oct 5, 2023

Users API changes (GoogleCloudPlatform#8920)

131d5f1

Users API changes #8920

Users API changes #8920

Conversation

pattukerman commented Sep 12, 2023 • edited by shuyama1 Loading

modular-magician commented Sep 12, 2023

modular-magician commented Sep 12, 2023

Diff report

modular-magician commented Sep 12, 2023

Diff report

modular-magician commented Sep 12, 2023

Tests analytics

Action taken

modular-magician commented Sep 12, 2023

Rerun these tests in REPLAYING mode to catch issues

pattukerman commented Sep 13, 2023

shuyama1 commented Sep 13, 2023

modular-magician commented Sep 20, 2023

Diff report

modular-magician commented Sep 20, 2023

Tests analytics

Action taken

modular-magician commented Sep 20, 2023

Rerun these tests in REPLAYING mode to catch issues

shuyama1 left a comment

Choose a reason for hiding this comment

shuyama1 Sep 20, 2023

Choose a reason for hiding this comment

pattukerman Sep 21, 2023

Choose a reason for hiding this comment

modular-magician commented Sep 21, 2023

Diff report

modular-magician commented Sep 21, 2023

Tests analytics

modular-magician commented Sep 26, 2023

Diff report

modular-magician commented Sep 26, 2023

Tests analytics

GauravJain21 commented Sep 27, 2023

shuyama1 left a comment

Choose a reason for hiding this comment

modular-magician commented Oct 2, 2023

Diff report

modular-magician commented Oct 3, 2023

modular-magician commented Oct 3, 2023

Diff report

modular-magician commented Oct 3, 2023

Tests analytics

Action taken

modular-magician commented Oct 3, 2023

Rerun these tests in REPLAYING mode to catch issues

shuyama1 commented Oct 3, 2023

modular-magician commented Oct 3, 2023

Diff report

modular-magician commented Oct 3, 2023

Tests analytics

Action taken

modular-magician commented Oct 3, 2023

Rerun these tests in REPLAYING mode to catch issues

GauravJain21 commented Oct 4, 2023

GauravJain21 commented Oct 4, 2023

shuyama1 commented Oct 4, 2023

modular-magician commented Oct 4, 2023

Diff report

modular-magician commented Oct 4, 2023

Tests analytics

Action taken

modular-magician commented Oct 5, 2023

Rerun these tests in REPLAYING mode to catch issues

pattukerman commented Oct 5, 2023

modular-magician commented Oct 5, 2023

Diff report

modular-magician commented Oct 5, 2023

Tests analytics

Action taken

modular-magician commented Oct 5, 2023

Rerun these tests in REPLAYING mode to catch issues

shuyama1 left a comment

Choose a reason for hiding this comment

pattukerman commented Sep 12, 2023 •

edited by shuyama1

Loading