-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add scaling_config to google_dataproc_metastore_service resource in google #8526
add scaling_config to google_dataproc_metastore_service resource in google #8526
Conversation
Hello! I am a robot. It looks like you are a community contributor. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 215 insertions(+), 5 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_dataproc_metastore_service" "primary" {
scaling_config {
scaling_factor = # value needed
}
}
|
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataprocMetastoreService_dataprocMetastoreServiceDpms2Example |
|
@@ -0,0 +1,21 @@ | |||
resource "google_dataproc_metastore_service" "<%= ctx[:primary_resource_id] %>" { | |||
service_id = "<%= ctx[:vars]['metastore_service_name'] %>" | |||
provider = google-beta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should only be present if the field is beta-only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, resolved in commit 7b02a51.
Currently failing for fractional values: $ make testacc TEST=./google-beta TESTARGS='-v -run=TestAccDataprocMetastoreService_dataprocMetastoreServiceDpms2ScalingFactorLt1Example' ==> Checking that code complies with gofmt requirements... go vet TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google-beta -v -v -run=TestAccDataprocMetastoreService_dataprocMetastoreServiceDpms2ScalingFactorLt1Example -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google-beta/version.ProviderVersion=acc" === RUN TestAccDataprocMetastoreService_dataprocMetastoreServiceDpms2ScalingFactorLt1Example === PAUSE TestAccDataprocMetastoreService_dataprocMetastoreServiceDpms2ScalingFactorLt1Example === CONT TestAccDataprocMetastoreService_dataprocMetastoreServiceDpms2ScalingFactorLt1Example vcr_utils.go:152: Step 1/2 error: Error running pre-apply refresh: exit status 1 Error: Attribute must be a whole number, got 1.1 with google_dataproc_metastore_service.dpms2_scaling_factor_lt1, on terraform_plugin_test.tf line 20, in resource "google_dataproc_metastore_service" "dpms2_scaling_factor_lt1": 20: scaling_factor = "1.1" --- FAIL: TestAccDataprocMetastoreService_dataprocMetastoreServiceDpms2ScalingFactorLt1Example (1.50s) FAIL FAIL github.com/hashicorp/terraform-provider-google-beta/google-beta 1.964s FAIL make: *** [GNUmakefile:15: testacc] Error 1
I'm struggling with a test, and would appreciate a second set of eyes. When I pass a fractional value to
Searching shows that this error ("Attribute must be a whole number") most often shows up when using a 32-bit terraform binary, but I've confirmed I have a 64 bit Go and a 64 bit terraform installed on my linux system. I'm unsure how to troubleshoot this further. I've considered removing the |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 335 insertions(+), 5 deletions(-)) |
Looks like this is only an issue with
|
- removed google-beta provider - removed fields from tests that require google-beta provider (gRPC)
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 310 insertions(+), 5 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataprocMetastoreService_dataprocMetastoreServiceDpms2ScalingFactorLt1Example|TestAccDataprocMetastoreService_dataprocMetastoreServiceDpms2ScalingFactorExample|TestAccDataprocMetastoreService_dataprocMetastoreServiceDpms2Example |
Rerun these tests in REPLAYING mode to catch issues$\textcolor{green}{\textsf{All tests passed!}} |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 311 insertions(+), 5 deletions(-)) |
Tests analyticsTotal tests:
|
…oogle (GoogleCloudPlatform#8526) * add scalingConfig object for google_dataproc_metastore_service * add an example of a DPMS 2 config * remove invalid value for instanceSize * WIP: Add tests for scaling_factor * changes for ga provider - removed google-beta provider - removed fields from tests that require google-beta provider (gRPC) * add exactly_one_of for instance_size and scaling_factor
…oogle (GoogleCloudPlatform#8526) * add scalingConfig object for google_dataproc_metastore_service * add an example of a DPMS 2 config * remove invalid value for instanceSize * WIP: Add tests for scaling_factor * changes for ga provider - removed google-beta provider - removed fields from tests that require google-beta provider (gRPC) * add exactly_one_of for instance_size and scaling_factor
…oogle (GoogleCloudPlatform#8526) * add scalingConfig object for google_dataproc_metastore_service * add an example of a DPMS 2 config * remove invalid value for instanceSize * WIP: Add tests for scaling_factor * changes for ga provider - removed google-beta provider - removed fields from tests that require google-beta provider (gRPC) * add exactly_one_of for instance_size and scaling_factor
…oogle (GoogleCloudPlatform#8526) * add scalingConfig object for google_dataproc_metastore_service * add an example of a DPMS 2 config * remove invalid value for instanceSize * WIP: Add tests for scaling_factor * changes for ga provider - removed google-beta provider - removed fields from tests that require google-beta provider (gRPC) * add exactly_one_of for instance_size and scaling_factor
…oogle (GoogleCloudPlatform#8526) * add scalingConfig object for google_dataproc_metastore_service * add an example of a DPMS 2 config * remove invalid value for instanceSize * WIP: Add tests for scaling_factor * changes for ga provider - removed google-beta provider - removed fields from tests that require google-beta provider (gRPC) * add exactly_one_of for instance_size and scaling_factor
…oogle (GoogleCloudPlatform#8526) * add scalingConfig object for google_dataproc_metastore_service * add an example of a DPMS 2 config * remove invalid value for instanceSize * WIP: Add tests for scaling_factor * changes for ga provider - removed google-beta provider - removed fields from tests that require google-beta provider (gRPC) * add exactly_one_of for instance_size and scaling_factor
This PR adds the
scaling_config
field to thegoogle_dataproc_metastore_service
beta resource. This PR fixes 15342The
scaling_config
field enables the user to create a DPMS2 service using Terraform.If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)