Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scaling_config to google_dataproc_metastore_service resource in google #8526

Merged
merged 6 commits into from
Aug 11, 2023

Commits on Jul 31, 2023

  1. Configuration menu
    Copy the full SHA
    881db0f View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Configuration menu
    Copy the full SHA
    362f2da View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0514f82 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. WIP: Add tests for scaling_factor

    Currently failing for fractional values:
    
    $ make testacc TEST=./google-beta TESTARGS='-v -run=TestAccDataprocMetastoreService_dataprocMetastoreServiceDpms2ScalingFactorLt1Example'
    ==> Checking that code complies with gofmt requirements...
    go vet
    TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google-beta -v -v -run=TestAccDataprocMetastoreService_dataprocMetastoreServiceDpms2ScalingFactorLt1Example -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google-beta/version.ProviderVersion=acc"
    === RUN   TestAccDataprocMetastoreService_dataprocMetastoreServiceDpms2ScalingFactorLt1Example
    === PAUSE TestAccDataprocMetastoreService_dataprocMetastoreServiceDpms2ScalingFactorLt1Example
    === CONT  TestAccDataprocMetastoreService_dataprocMetastoreServiceDpms2ScalingFactorLt1Example
        vcr_utils.go:152: Step 1/2 error: Error running pre-apply refresh: exit status 1
    
            Error: Attribute must be a whole number, got 1.1
    
              with google_dataproc_metastore_service.dpms2_scaling_factor_lt1,
              on terraform_plugin_test.tf line 20, in resource "google_dataproc_metastore_service" "dpms2_scaling_factor_lt1":
              20:     scaling_factor = "1.1"
    
    --- FAIL: TestAccDataprocMetastoreService_dataprocMetastoreServiceDpms2ScalingFactorLt1Example (1.50s)
    FAIL
    FAIL    github.com/hashicorp/terraform-provider-google-beta/google-beta 1.964s
    FAIL
    make: *** [GNUmakefile:15: testacc] Error 1
    vicenteg committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    2a411ed View commit details
    Browse the repository at this point in the history
  2. changes for ga provider

    - removed google-beta provider
    - removed fields from tests that require google-beta provider (gRPC)
    vicenteg committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    7b02a51 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Configuration menu
    Copy the full SHA
    4e62fb5 View commit details
    Browse the repository at this point in the history