Adding labels and namespace labels to the GKEHub namespace resource #8832
Conversation
…hings simpler in the review
…h the one from test env
|
Hello! I am a robot. It looks like you are a: @SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 265 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataprocClusterIamPolicy|TestAccGKEHub2Namespace_gkehubNamespaceBasicExample_update|TestAccGKEHub2Namespace_gkehubNamespaceBasicExample |
|
Rerun these tests in REPLAYING mode to catch issues
|
mmv1/third_party/terraform/services/gkehub2/resource_gke_hub_namespace_test.go
Outdated
Show resolved
Hide resolved
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 265 insertions(+)) |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 281 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDNSPolicy_dnsPolicyBasicExample|TestAccGKEHub2Namespace_gkehubNamespaceBasicExample_update|TestAccGKEHub2Namespace_gkehubNamespaceBasicExample |
|
Rerun these tests in REPLAYING mode to catch issues
|
…oogleCloudPlatform#8832) * Adding Terraform resources for Tenancy APIs in GKEHub * Segregating MembershipBinding and MembershipRBACRoleBinding to keep things simpler in the review * Fixing the docu URIs * Adding TF support for Tenancy API for Membership Binding * Adding dependent membership binding to the same commit chain * Making Scope un-updatable and replacing hard coded project number with the one from test env * Making Scope RRBAC updatable * Making Namespace immutable * Adding update test cases * Removing all memberships field from Scope since it is no longer supported * Removing all_memberships field for Scope from all test cases * Enhancing namespace resource with the labels fields * Adding more keys to test out the sorted comparison of keys in the map of labels * Adding more keys to test out the sorted comparison of keys in the update map
…oogleCloudPlatform#8832) * Adding Terraform resources for Tenancy APIs in GKEHub * Segregating MembershipBinding and MembershipRBACRoleBinding to keep things simpler in the review * Fixing the docu URIs * Adding TF support for Tenancy API for Membership Binding * Adding dependent membership binding to the same commit chain * Making Scope un-updatable and replacing hard coded project number with the one from test env * Making Scope RRBAC updatable * Making Namespace immutable * Adding update test cases * Removing all memberships field from Scope since it is no longer supported * Removing all_memberships field for Scope from all test cases * Enhancing namespace resource with the labels fields * Adding more keys to test out the sorted comparison of keys in the map of labels * Adding more keys to test out the sorted comparison of keys in the update map
…oogleCloudPlatform#8832) * Adding Terraform resources for Tenancy APIs in GKEHub * Segregating MembershipBinding and MembershipRBACRoleBinding to keep things simpler in the review * Fixing the docu URIs * Adding TF support for Tenancy API for Membership Binding * Adding dependent membership binding to the same commit chain * Making Scope un-updatable and replacing hard coded project number with the one from test env * Making Scope RRBAC updatable * Making Namespace immutable * Adding update test cases * Removing all memberships field from Scope since it is no longer supported * Removing all_memberships field for Scope from all test cases * Enhancing namespace resource with the labels fields * Adding more keys to test out the sorted comparison of keys in the map of labels * Adding more keys to test out the sorted comparison of keys in the update map
…oogleCloudPlatform#8832) * Adding Terraform resources for Tenancy APIs in GKEHub * Segregating MembershipBinding and MembershipRBACRoleBinding to keep things simpler in the review * Fixing the docu URIs * Adding TF support for Tenancy API for Membership Binding * Adding dependent membership binding to the same commit chain * Making Scope un-updatable and replacing hard coded project number with the one from test env * Making Scope RRBAC updatable * Making Namespace immutable * Adding update test cases * Removing all memberships field from Scope since it is no longer supported * Removing all_memberships field for Scope from all test cases * Enhancing namespace resource with the labels fields * Adding more keys to test out the sorted comparison of keys in the map of labels * Adding more keys to test out the sorted comparison of keys in the update map
Fixes hashicorp/terraform-provider-google#15700
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)