Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding labels and namespace labels to the GKEHub namespace resource #15732

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Adding labels and namespace labels to the GKEHub namespace resource #15732

merged 1 commit into from
Sep 6, 2023

Conversation

modular-magician
Copy link
Collaborator

Fixes #15700

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

gkehub2: added `labels`, `namespace_labels` fields to `google_gke_hub_namespace` resource

Derived from GoogleCloudPlatform/magic-modules#8832

@modular-magician
Adding labels and namespace labels to the GKEHub namespace resource (h…
bc04254 
…ashicorp#8832)

* Adding Terraform resources for Tenancy APIs in GKEHub

* Segregating MembershipBinding and MembershipRBACRoleBinding to keep things simpler in the review

* Fixing the docu URIs

* Adding TF support for Tenancy API for Membership Binding

* Adding dependent membership binding to the same commit chain

* Making Scope un-updatable and replacing hard coded project number with the one from test env

* Making Scope RRBAC updatable

* Making Namespace immutable

* Adding update test cases

* Removing all memberships field from Scope since it is no longer supported

* Removing all_memberships field for Scope from all test cases

* Enhancing namespace resource with the labels fields

* Adding more keys to test out the sorted comparison of keys in the map of labels

* Adding more keys to test out the sorted comparison of keys in the update map

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit c110b47 into hashicorp:main Sep 6, 2023
4 checks passed
@github-actions
Copy link

github-actions bot commented Oct 7, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable labels and namespace labels for the google_gke_hub_namespace resource
1 participant
@modular-magician