[AlloyDB] Named IP Range Support

[vmiglani]

Description -
Changes for supporting Named IP Ranges in Terraform. Going forward, the "network" field in AlloyDB cluster creation is being deprecated in favor or "network_config". While specifying the "network_config", customers can also specify an additional field "allocated_ip_range" which will then ensure that instances in this cluster are created from that range.

Issue - https://buganizer.corp.google.com/issues/295360787

alloydb: deprecated `network` field in favor of `network_config`.

alloydb: added `network_config` field to support named IP ranges.

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 294 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 4 files changed, 294 insertions(+), 13 deletions(-))
TF Conversion: Diff ( 1 file changed, 40 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 289 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 4 files changed, 289 insertions(+), 13 deletions(-))
TF Conversion: Diff ( 1 file changed, 40 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3048
Passed tests 2742
Skipped tests: 298
Affected tests: 8

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbInstance_createInstanceWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbCluster_withNetworkConfig|TestAccAlloydbCluster_withNetworkConfigAndAllocatedIPRange|TestAccAlloydbCluster_update|TestAccAlloydbCluster_continuousBackup_update|TestAccAlloydbCluster_AutomatedBackupPolicyHandlesMidnight|TestAccAlloydbCluster_continuousBackup_CMEKIsUpdatable|TestAccAlloydbCluster_restore

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbInstance_createInstanceWithNetworkConfigAndAllocatedIPRange[Debug log]
TestAccAlloydbCluster_withNetworkConfig[Debug log]
TestAccAlloydbCluster_withNetworkConfigAndAllocatedIPRange[Debug log]
TestAccAlloydbCluster_update[Debug log]
TestAccAlloydbCluster_continuousBackup_update[Debug log]
TestAccAlloydbCluster_AutomatedBackupPolicyHandlesMidnight[Debug log]
TestAccAlloydbCluster_continuousBackup_CMEKIsUpdatable[Debug log]
TestAccAlloydbCluster_restore[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[rileykarson]

@c2thorn have we tested this upgrade / can you file a bug in Future Major Release to track the eventual removal?

[c2thorn]

@rileykarson created hashicorp/terraform-provider-google#16119 and tested upgrading network -> network_config.network which worked without producing a diff

[rileykarson]

Thanks!

[rileykarson]

Note: During a deprecation we should upgrade all (or all but one) of the generated tests to use the new mechanism to specify the field. We should still keep the old one around in some handwritten tests, though. Filed as hashicorp/terraform-provider-google#16848.